From patchwork Tue Jan 15 18:42:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul A. Clarke" X-Patchwork-Id: 1025359 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-99281-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="tUbjzE/q"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43fK3N428Fz9s9G for ; Wed, 16 Jan 2019 05:43:12 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:mime-version:message-id :content-type:content-transfer-encoding; q=dns; s=default; b=fVO IFWxJcEMe3u/Ew4cDVzjnIDT3WSgroa0luEBbY+J4/605zWunMYlhlkJxfMjqTro RT2D7snDF1RrqPzDNlfQoit3TQyOYPDQ0WeLia61mCGrCJbMvEOsOuWLstt/ugDE LV30FfSihDYAG2j1ekBLklc8osfpVP0+5Dywi1xM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:mime-version:message-id :content-type:content-transfer-encoding; s=default; bh=u0Mufw07V T1GB/Np4JAIrvtnuh8=; b=tUbjzE/qrvtcF/atJRzyw7k1+ui8/clXJsP/tbz4D Zh1psa5/g9Ik1Pb4BY6Bzi0xcwUMcheJPpW76dAgbUploYZ6WWHtj2MedoN541FR 28L5VmkNjwb25f5KjLArNDi+j3A7NB+mqU9B6lp+wacnLhGep8dO5svsEsmymfZn +0= Received: (qmail 65943 invoked by alias); 15 Jan 2019 18:43:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 65931 invoked by uid 89); 15 Jan 2019 18:43:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:931, HTo:D*vnet.ibm.com, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com To: GNU C Library , Tulio Magno Quites Machado Filho From: Paul Clarke Subject: [PATCH][powerpc] Fix tiny bug in strncmp.c Date: Tue, 15 Jan 2019 12:42:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 x-cbid: 19011518-0016-0000-0000-00000975EC5F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010413; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000274; SDB=6.01146933; UDB=6.00597400; IPR=6.00927226; MB=3.00025142; MTD=3.00000008; XFM=3.00000015; UTC=2019-01-15 18:43:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19011518-0017-0000-0000-000041C9B1E7 Message-Id: A single underscore was omitted in sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of power8 version of strncmp instead of power9 version, with significant performance degradation. 2019-01-15 Paul A. Clarke * sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef. diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c index ab7379d..d2791ce 100644 --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c @@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden; /* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle ifunc symbol properly. */ libc_ifunc_redirected (__redirect_strncmp, strncmp, -# ifdef __LITTLE_ENDIAN_ +# ifdef __LITTLE_ENDIAN__ (hwcap2 & PPC_FEATURE2_ARCH_3_00) ? __strncmp_power9 : # endif