| Message ID | 87jzx83shb.fsf@oldenburg.str.redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | stdlib: Use long long int in stdlib/tst-llabs | expand |
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> On 2023-05-16 16:56, Florian Weimer via Libc-alpha wrote: > And adjust for GNU style. > > --- > stdlib/tst-llabs.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c > index be3cd78ceb..5e4d52def9 100644 > --- a/stdlib/tst-llabs.c > +++ b/stdlib/tst-llabs.c > @@ -25,29 +25,29 @@ > > static int do_test (void) > { > - long i; > + long long int i; > > - TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX); > - TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX); > - TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL); > - TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L); > - TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L); > - TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L); > - TEST_COMPARE(llabs(-1), 1); > - TEST_COMPARE(llabs(0), 0); > - TEST_COMPARE(llabs(1), 1); > + TEST_COMPARE (llabs (LLONG_MAX), LLONG_MAX); > + TEST_COMPARE (llabs (LLONG_MIN + 1), LLONG_MAX); > + TEST_COMPARE (llabs (0x00000000ffffffffL), 0x00000000ffffffffL); > + TEST_COMPARE (llabs (0x0000000100000000L), 0x0000000100000000L); > + TEST_COMPARE (llabs (0x80000000ffffffffL), 0x7fffffff00000001L); > + TEST_COMPARE (llabs (0x8000000100000000L), 0x7fffffff00000000L); > + TEST_COMPARE (llabs (-1), 1); > + TEST_COMPARE (llabs (0), 0); > + TEST_COMPARE (llabs (1), 1); > > for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), -i); > + TEST_COMPARE (llabs (i), -i); > > for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), i); > + TEST_COMPARE (llabs (i), i); > > for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), -i); > + TEST_COMPARE (llabs (i), -i); > > for (i = 0; i < INT_MAX; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), i); > + TEST_COMPARE (llabs (i), i); > > return EXIT_SUCCESS; > } > > base-commit: 89ade905c51a2488e85a28f9de413d8d9c1af82d >
diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c index be3cd78ceb..5e4d52def9 100644 --- a/stdlib/tst-llabs.c +++ b/stdlib/tst-llabs.c @@ -25,29 +25,29 @@ static int do_test (void) { - long i; + long long int i; - TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX); - TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX); - TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL); - TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L); - TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L); - TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L); - TEST_COMPARE(llabs(-1), 1); - TEST_COMPARE(llabs(0), 0); - TEST_COMPARE(llabs(1), 1); + TEST_COMPARE (llabs (LLONG_MAX), LLONG_MAX); + TEST_COMPARE (llabs (LLONG_MIN + 1), LLONG_MAX); + TEST_COMPARE (llabs (0x00000000ffffffffL), 0x00000000ffffffffL); + TEST_COMPARE (llabs (0x0000000100000000L), 0x0000000100000000L); + TEST_COMPARE (llabs (0x80000000ffffffffL), 0x7fffffff00000001L); + TEST_COMPARE (llabs (0x8000000100000000L), 0x7fffffff00000000L); + TEST_COMPARE (llabs (-1), 1); + TEST_COMPARE (llabs (0), 0); + TEST_COMPARE (llabs (1), 1); for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME) - TEST_COMPARE(llabs(i), -i); + TEST_COMPARE (llabs (i), -i); for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME) - TEST_COMPARE(llabs(i), i); + TEST_COMPARE (llabs (i), i); for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) - TEST_COMPARE(llabs(i), -i); + TEST_COMPARE (llabs (i), -i); for (i = 0; i < INT_MAX; i += LARGE_PRIME) - TEST_COMPARE(llabs(i), i); + TEST_COMPARE (llabs (i), i); return EXIT_SUCCESS; }