Message ID | 87h7x4rkxj.fsf@mid.deneb.enyo.de |
---|---|
State | New |
Headers | show |
Series | ckb_IQ locale: Add missing reorder-end keyword | expand |
28.04.2020 11:58 Florian Weimer <fw@deneb.enyo.de> wrote: > > This suppresses a non-fatal error during locale building. > > ----- > localedata/locales/ckb_IQ | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ > index 238c381edf..ef2f3fcf2d 100644 > --- a/localedata/locales/ckb_IQ > +++ b/localedata/locales/ckb_IQ > @@ -84,6 +84,8 @@ reorder-after <S0646> % ن > <S0648> % و > <S06C6> % ۆ > > +reorder-end > + > END LC_COLLATE > > LC_MONETARY Thank you, Florian. Are you sure there are no more such cases, other than these two (ckb_IQ and or_IN)? Regards, Rafal
* Rafal Luzynski: > 28.04.2020 11:58 Florian Weimer <fw@deneb.enyo.de> wrote: >> >> This suppresses a non-fatal error during locale building. >> >> ----- >> localedata/locales/ckb_IQ | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ >> index 238c381edf..ef2f3fcf2d 100644 >> --- a/localedata/locales/ckb_IQ >> +++ b/localedata/locales/ckb_IQ >> @@ -84,6 +84,8 @@ reorder-after <S0646> % ن >> <S0648> % و >> <S06C6> % ۆ >> >> +reorder-end >> + >> END LC_COLLATE >> >> LC_MONETARY > > Thank you, Florian. Are you sure there are no more such cases, other > than these two (ckb_IQ and or_IN)? I don't think so. I didn't see any other errors during the install-locales command for the supported locales. (The error should be fatal to the install operation, but that's a different bug.)
5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote: > > * Rafal Luzynski: > > > [...] > > Thank you, Florian. Are you sure there are no more such cases, other > > than these two (ckb_IQ and or_IN)? > > I don't think so. I didn't see any other errors during the > install-locales command for the supported locales. It would be nice to have a command that would scan all locale source code for missing reorder-end but nothing comes to my mind. It's not easy due to possible include directive. But better to fix those two bugs than to wait until we figure out how to find all such bugs (while maybe there are no more). No need to create a bugzilla ticket because this is not a user-visible bug. My suggestion: please squash those two patches into one commit as they are pretty trivial. Both patches LGTM (no matter if you follow this suggestion or not). Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com> Regards, Rafal
* Rafal Luzynski via Libc-alpha: > 5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote: >> >> * Rafal Luzynski: >> >> > [...] >> > Thank you, Florian. Are you sure there are no more such cases, other >> > than these two (ckb_IQ and or_IN)? >> >> I don't think so. I didn't see any other errors during the >> install-locales command for the supported locales. > > It would be nice to have a command that would scan all locale source code > for missing reorder-end but nothing comes to my mind. It's not easy due > to possible include directive. > > But better to fix those two bugs than to wait until we figure out how > to find all such bugs (while maybe there are no more). > > No need to create a bugzilla ticket because this is not a user-visible bug. > > My suggestion: please squash those two patches into one commit as they > are pretty trivial. > > Both patches LGTM (no matter if you follow this suggestion or not). > > Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com> Thanks, I've squashed them together and committed them. I know that Carlos is working on some localedef enhancements, maybe he can slip in the error handling fix as well. 8-)
On 5/8/20 4:53 AM, Florian Weimer wrote: > * Rafal Luzynski via Libc-alpha: > >> 5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote: >>> >>> * Rafal Luzynski: >>> >>>> [...] >>>> Thank you, Florian. Are you sure there are no more such cases, other >>>> than these two (ckb_IQ and or_IN)? >>> >>> I don't think so. I didn't see any other errors during the >>> install-locales command for the supported locales. >> >> It would be nice to have a command that would scan all locale source code >> for missing reorder-end but nothing comes to my mind. It's not easy due >> to possible include directive. >> >> But better to fix those two bugs than to wait until we figure out how >> to find all such bugs (while maybe there are no more). >> >> No need to create a bugzilla ticket because this is not a user-visible bug. >> >> My suggestion: please squash those two patches into one commit as they >> are pretty trivial. >> >> Both patches LGTM (no matter if you follow this suggestion or not). >> >> Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com> > > Thanks, I've squashed them together and committed them. > > I know that Carlos is working on some localedef enhancements, maybe he > can slip in the error handling fix as well. 8-) On my list to look at :-)
diff --git a/localedata/locales/ckb_IQ b/localedata/locales/ckb_IQ index 238c381edf..ef2f3fcf2d 100644 --- a/localedata/locales/ckb_IQ +++ b/localedata/locales/ckb_IQ @@ -84,6 +84,8 @@ reorder-after <S0646> % ن <S0648> % و <S06C6> % ۆ +reorder-end + END LC_COLLATE LC_MONETARY