From patchwork Fri May 27 11:55:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marko Myllynen X-Patchwork-Id: 627093 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rGPcC2bn1z9t3Z for ; Fri, 27 May 2016 21:56:11 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=fD9g94av; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:reply-to:to:from:subject:message-id:date :mime-version:content-type:content-transfer-encoding; q=dns; s= default; b=BPrUxnJc5VzlDpsQuzChNJSX66XDLLJVGk22mXYgyIJ0QJdLWHUH4 nCT082S5ZlXxJseGOV6Xn2j02C5GnozBXvIg0/kvN7jAaCZVYU2r8VePFdmxy3nr NPVBaFPIBmmD8kfxHZHEPhRVRFIlCMKj00JWM+vFbEocsxNQLDYFYk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:reply-to:to:from:subject:message-id:date :mime-version:content-type:content-transfer-encoding; s=default; bh=wcZZGGwDGvTbLx3aiONFnltzELY=; b=fD9g94avejTv1A6ov1eisYhVYdPL mSnx68N0VLjDhtDXMu16gt7ZMIIYxWALaPN/ODt/pfpWLaZHgO6CVPKvPnHcXyH+ 7sV2JXY0lIHStAxc40OnnTAZZlrPdjGbNK1LxrOKBQ6BPNhuKEjAx/BK2DeM81FF /CV0A5YVXVj29Hk= Received: (qmail 115317 invoked by alias); 27 May 2016 11:56:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 115307 invoked by uid 89); 27 May 2016 11:56:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Strictly, 2016-05-27 X-HELO: mail-wm0-f54.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:reply-to:to:from:subject:organization:message-id :date:user-agent:mime-version:content-transfer-encoding; bh=MLABC3I61m8qUI/Dnwa5f7WVsAOipS526zQykd+u1NQ=; b=IzdQBpekDNjf9nopGAhHpQ6v9NOE08bkQ4ukCvH9xVEbFw3IEKLVHCKH1U7AMp5e8l xaQX/aSGlkcKnQABsSi+wce7+8IKhRreK+S1J/EUeaElF+GZOeGrZl+ryVCIbwVQgyZ5 NADUwVHzWQcBrwc+oRQSGhhspQa0s9K7d97PBYQGwjKFPJCwIgMAK7EpUFqvLQu5NW2j okTddfd249pDqGLrnZzumgWjRamNFWTllyzi8O2ieDodt4EdApKNE9foAFUjnL2Vnuth Uw2SSwrHWaQjFg6UsHQP0tcXXYUAJav/RPERFJC0DTWrMCVYkipYj/8HQGks1f+FoEuc H0nw== X-Gm-Message-State: ALyK8tLCA45Yfml04Opr5csDqo43PKzGUqYUY5gqh48v1SwEhYU70IEj1dNVaI70t9GpDdxG X-Received: by 10.194.32.165 with SMTP id k5mr15542793wji.23.1464350157854; Fri, 27 May 2016 04:55:57 -0700 (PDT) Reply-To: Marko Myllynen To: GNU C Library From: Marko Myllynen Subject: [PATCH] localedef --old-style is a no-op Message-ID: <574835CB.5000401@redhat.com> Date: Fri, 27 May 2016 14:55:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Hi, The --old-style option for localedef is a no-op. Is the patch below to reflect this worth the effort (considering translations) or should we leave it as is? (I've already submitted a patch to man pages upstream to adjust the localedef(1) man page.) 2016-05-27 Marko Myllynen * locale/programs/localedef.c (oldstyle_tables): Remove. * locale/programs/localedef.h (oldstyle_tables): Likewise. Update old-style command line option description. --- locale/programs/localedef.c | 7 +------ locale/programs/localedef.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) Thanks, diff --git a/locale/programs/localedef.c b/locale/programs/localedef.c index bfc5d22..546d2cd 100644 --- a/locale/programs/localedef.c +++ b/locale/programs/localedef.c @@ -54,10 +54,6 @@ int verbose; /* If not zero suppress warnings and information messages. */ int be_quiet; -/* If not zero, produce old-style hash table instead of 3-level access - tables. */ -int oldstyle_tables; - /* If not zero force output even if warning were issued. */ static int force_output; @@ -128,7 +124,7 @@ static const struct argp_option options[] = { NULL, 0, NULL, 0, N_("Output control:") }, { "force", 'c', NULL, 0, N_("Create output even if warning messages were issued") }, - { "old-style", OPT_OLDSTYLE, NULL, 0, N_("Create old-style tables") }, + { "old-style", OPT_OLDSTYLE, NULL, 0, N_("Ignored, for backwards compatibility only") }, { "prefix", OPT_PREFIX, N_("PATH"), 0, N_("Optional output file prefix") }, { "posix", OPT_POSIX, NULL, 0, N_("Strictly conform to POSIX") }, { "quiet", OPT_QUIET, NULL, 0, @@ -311,7 +307,6 @@ parse_opt (int key, char *arg, struct argp_state *state) posix_conformance = 1; break; case OPT_OLDSTYLE: - oldstyle_tables = 1; break; case OPT_PREFIX: output_prefix = arg; diff --git a/locale/programs/localedef.h b/locale/programs/localedef.h index cb9386a..daed933 100644 --- a/locale/programs/localedef.h +++ b/locale/programs/localedef.h @@ -112,7 +112,6 @@ struct localedef_t /* Global variables of the localedef program. */ extern int verbose; extern int be_quiet; -extern int oldstyle_tables; extern const char *repertoire_global; extern int max_locarchive_open_retry; extern bool no_archive;