Message ID | 56E8E720.9010507@redhat.com |
---|---|
State | New |
Headers | show |
On 16 Mar 2016 00:54, Carlos O'Donell wrote: > On 02/29/2016 10:46 AM, Aurelien Jarno wrote: > > On 2016-02-19 23:38, Mike Frysinger wrote: > >> Aragonese is classified as "an" so set it. > >> --- > >> localedata/locales/an_ES | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES > >> index cc18c6b..e6d00f3 100644 > >> --- a/localedata/locales/an_ES > >> +++ b/localedata/locales/an_ES > >> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/ > >> country_ab2 "<U0045><U0053>" > >> country_ab3 "<U0045><U0053><U0050>" > >> country_num 724 > >> +lang_ab "<U0041><U004E>" > >> % E > >> country_car "<U0045>" > >> % aragonés > > > > This is correct > > This is not correct. You must use an abbreviation which matches > exactly in case with ISO 639 names. i didn't intend to use uppercase. i'll push your fix. i've also updated my linter to check for case here. > Please make sure you run: > `make localedata/install-locales DESTDIR=/tmp/glibc-install` > as a sanity check for these kinds of changes. i'd been running localedef on all the files when making changes, but looks like i had a bug in my script and was using the wrong datastore. i've fixed that now and it does show this error too. -mike
On 03/16/2016 02:44 PM, Mike Frysinger wrote: > On 16 Mar 2016 00:54, Carlos O'Donell wrote: >> On 02/29/2016 10:46 AM, Aurelien Jarno wrote: >>> On 2016-02-19 23:38, Mike Frysinger wrote: >>>> Aragonese is classified as "an" so set it. >>>> --- >>>> localedata/locales/an_ES | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES >>>> index cc18c6b..e6d00f3 100644 >>>> --- a/localedata/locales/an_ES >>>> +++ b/localedata/locales/an_ES >>>> @@ -134,6 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/ >>>> country_ab2 "<U0045><U0053>" >>>> country_ab3 "<U0045><U0053><U0050>" >>>> country_num 724 >>>> +lang_ab "<U0041><U004E>" >>>> % E >>>> country_car "<U0045>" >>>> % aragonés >>> >>> This is correct >> >> This is not correct. You must use an abbreviation which matches >> exactly in case with ISO 639 names. > > i didn't intend to use uppercase. i'll push your fix. i've also > updated my linter to check for case here. > >> Please make sure you run: >> `make localedata/install-locales DESTDIR=/tmp/glibc-install` >> as a sanity check for these kinds of changes. > > i'd been running localedef on all the files when making changes, but > looks like i had a bug in my script and was using the wrong datastore. > i've fixed that now and it does show this error too. Awesome. Thanks for fixing it!
diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES index e6d00f3..202732d 100644 --- a/localedata/locales/an_ES +++ b/localedata/locales/an_ES @@ -134,7 +134,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/ country_ab2 "<U0045><U0053>" country_ab3 "<U0045><U0053><U0050>" country_num 724 -lang_ab "<U0041><U004E>" +lang_ab "<U0061><U006E>" % E country_car "<U0045>" % aragonés