diff mbox

Test for profiling support (_mcount/gprof)

Message ID 55708a27-9691-0d85-c0bc-cf856b30987e@redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 15, 2017, 4:40 p.m. UTC 
On 08/15/2017 06:32 PM, Joseph Myers wrote:
> The new test in tests-special needs to be conditional on 
> run-built-tests=yes; right now it makes run-built-tests=no cross tests, as 
> with build-many-glibcs.py, fail as it tries to run tst-gmon natively.

Oops.  Like this?

Thanks,
Florian

Comments

Joseph Myers Aug. 15, 2017, 4:46 p.m. UTC | #1 
On Tue, 15 Aug 2017, Florian Weimer wrote:

> On 08/15/2017 06:32 PM, Joseph Myers wrote:
> > The new test in tests-special needs to be conditional on 
> > run-built-tests=yes; right now it makes run-built-tests=no cross tests, as 
> > with build-many-glibcs.py, fail as it tries to run tst-gmon natively.
> 
> Oops.  Like this?

This patch is OK.
diff mbox

Patch

gmon: Run tst-gmon-prof only for run-built-tests=yes

2017-08-15  Florian Weimer  <fweimer@redhat.com>

	* gmon/Makefile (tests-special): Add tst-gmon-prof only if
	run-built-tests.

diff --git a/gmon/Makefile b/gmon/Makefile
index 947e6b5905..39f11acec2 100644
--- a/gmon/Makefile
+++ b/gmon/Makefile
@@ -42,7 +42,9 @@  CFLAGS-tst-gmon.c := -pg
 LDFLAGS-tst-gmon := $(no-pie-ldflag)
 CRT-tst-gmon := $(csu-objpfx)gcrt1.o
 tst-gmon-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon.data
+ifeq ($(run-built-tests),yes)
 tests-special += $(objpfx)tst-gmon-gprof.out
+endif
 
 include ../Rules