From patchwork Tue Feb 24 17:11:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 443075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 62FE6140134 for ; Wed, 25 Feb 2015 04:22:33 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; q=dns; s=default; b=lk+ cSWmtmvTb/ab64104ekGdnVHOkxGy7WJLOqHGun6SuCD3821dngjtiL5nxWki/lu 7hVYdueHamqRJmm/IqWfWj4PLeJBjhJWUOtF6fbC0FYP6aoN4OkkOhnS7SI3CASr 9kulmWpIqOfxaeFt17HcgehDO9U2jeJ1QgA9BMec= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; s=default; bh=FIkrlsLc0 fKkR/h51XrbkdD6Sxc=; b=XRtZpXURmfo7U8B4jZvhMtt9srZQMPn7P04FjRql4 O2pHud4YZXprIBO4ufVe7O/4ZMukkDdqTAyO16oENopaSJS6KxmLzJeDS1xIZgAh NyDRrcaxviaioH3kIFCYIpD3kI4DMErG5Zz8G3dqU6VQchg6Y7vb6smYjDLouHPO pI= Received: (qmail 25166 invoked by alias); 24 Feb 2015 17:13:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25140 invoked by uid 89); 24 Feb 2015 17:13:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <54ECB0B4.1030602@redhat.com> Date: Tue, 24 Feb 2015 18:11:16 +0100 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: GNU C Library Subject: Missing security fix in elf/dl-open.c? Some downstreams include this hunk in their patches related to CVE-2010-3847 and CVE-2011-0536: I can't find this in glibc master. Is the hunk above needed, or is it just hardening? Index: glibc-2.12-2-gc4ccff1/elf/dl-object.c =================================================================== --- glibc-2.12-2-gc4ccff1.orig/elf/dl-object.c +++ glibc-2.12-2-gc4ccff1/elf/dl-object.c @@ -214,6 +214,9 @@ _dl_new_object (char *realname, const ch out: new->l_origin = origin; } + else if (INTUSE(__libc_enable_secure) && type == lt_executable) + /* The origin of a privileged program cannot be trusted. */ + new->l_origin = (char *) -1; return new; }