| Message ID | 20240517121732.1999176-1-avinal@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | support: Fix typo in xgetsockname error message | expand |
On 5/17/24 8:10 AM, Avinal Kumar wrote: > The error message in xgetsockname was incorrectly referring to a > different function. This commit fixes that. > > Suggested-by: Arjun Shankar <arjun@redhat.com> > Signed-off-by: Avinal Kumar <avinal@redhat.com> As a Red Hat employee you are covered under the corporate assignment unless your work contract explicitly has you owning your contributions (in which case you would need a personal assignment or contribution under DCO). Please clarify: (a) Are you contributing under Red Hat's corporate assignment to the FSF? (b) Are you contributing under DCO? In which case the file's copyright statement needs updating. Looking forward to a v2. > --- > It's small but happy to get stated with glibc :) > --- > support/xgetsockname.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/xgetsockname.c b/support/xgetsockname.c > index fd1a42ea1e..4f53a874d2 100644 > --- a/support/xgetsockname.c > +++ b/support/xgetsockname.c > @@ -26,5 +26,5 @@ void > xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen) > { > if (getsockname (fd, sa, plen) != 0) > - FAIL_EXIT1 ("setsockopt (%d): %m", fd); > + FAIL_EXIT1 ("getsockname (%d): %m", fd); > }
Thank you Carlos for the clarification. I was not aware of such rules. a) No, I am not contributing under Red Hat's corporate assignment. b) This should be the case since I am personally interested in contributing. I will send a revised patch soon with corrections. On Fri, May 17, 2024 at 1:49 PM Carlos O'Donell <carlos@redhat.com> wrote: > On 5/17/24 8:10 AM, Avinal Kumar wrote: > > The error message in xgetsockname was incorrectly referring to a > > different function. This commit fixes that. > > > > Suggested-by: Arjun Shankar <arjun@redhat.com> > > Signed-off-by: Avinal Kumar <avinal@redhat.com> > > As a Red Hat employee you are covered under the corporate assignment > unless your > work contract explicitly has you owning your contributions (in which case > you would > need a personal assignment or contribution under DCO). > > Please clarify: > > (a) Are you contributing under Red Hat's corporate assignment to the FSF? > > (b) Are you contributing under DCO? In which case the file's copyright > statement > needs updating. > > Looking forward to a v2. > > > --- > > It's small but happy to get stated with glibc :) > > --- > > support/xgetsockname.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/support/xgetsockname.c b/support/xgetsockname.c > > index fd1a42ea1e..4f53a874d2 100644 > > --- a/support/xgetsockname.c > > +++ b/support/xgetsockname.c > > @@ -26,5 +26,5 @@ void > > xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen) > > { > > if (getsockname (fd, sa, plen) != 0) > > - FAIL_EXIT1 ("setsockopt (%d): %m", fd); > > + FAIL_EXIT1 ("getsockname (%d): %m", fd); > > } > > -- > Cheers, > Carlos. > >
diff --git a/support/xgetsockname.c b/support/xgetsockname.c index fd1a42ea1e..4f53a874d2 100644 --- a/support/xgetsockname.c +++ b/support/xgetsockname.c @@ -26,5 +26,5 @@ void xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen) { if (getsockname (fd, sa, plen) != 0) - FAIL_EXIT1 ("setsockopt (%d): %m", fd); + FAIL_EXIT1 ("getsockname (%d): %m", fd); }
The error message in xgetsockname was incorrectly referring to a different function. This commit fixes that. Suggested-by: Arjun Shankar <arjun@redhat.com> Signed-off-by: Avinal Kumar <avinal@redhat.com> --- It's small but happy to get stated with glibc :) --- support/xgetsockname.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)