From patchwork Wed Mar 27 16:45:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 1916932 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NzIy2orz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V4Xd76fwWz1yWv for ; Thu, 28 Mar 2024 03:46:51 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26334385E453 for ; Wed, 27 Mar 2024 16:46:50 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 2C466385E449 for ; Wed, 27 Mar 2024 16:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C466385E449 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C466385E449 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711557951; cv=none; b=IRcba/t/3YPc1vI1+5eKrlRq9JOvse51XWbCjXsmvUVWRVMz/zhsPL+lPWhecVbYfexUuKYXAcobHEXDioKkQfLSs/VqvTa+DBEfFpcQAanI1sHMVIYTJ6kkgcpV0GVomgdXfWlwNLiq9N/RwwAeNdRrlunpXHFGOxHz45N0E7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711557951; c=relaxed/simple; bh=V2QOHmynST+A06BJ1vVs7hRXKEsIYCDGCjaalv4frLA=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=QvBS1OP8m8DeIEEwUHXg+llE34eSMaKLJQfeHlq3HqgIRBXnT1WYUMmt0wFSDtQq6/bnXrN9pacrhGk9Uh1OgwKWJ5tjeHVN/2u/kYyXJNZkNsA1/kD86KvBg+r9LzxLC0T/XL7spfRgyJIjlx36EtkLF6E/RlpYYd1cAww1qeM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1e04ac4209eso289315ad.1 for ; Wed, 27 Mar 2024 09:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711557947; x=1712162747; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b/uJsYX5TjTzzmu5D77iSjXX+egw1x7sUXQBSMn9NVQ=; b=NzIy2orztUY6MoK+1ELOiDQg5QBFZ1h4R7q8oU1WvPbdHRC6d4WUPdr3ZAdUoBPabR dXco7n3wm+8Qr0NS0/hcZ2D6jM0p8ywJdNag56jTS1CzN9AMv1NPdoXcmNYmNZvzxE+I euNH9WTPU7zfCrJHHhh41AfMj0Ttw5D7qdewyw6q+DH05qMCa58HYx1P1mjrBVxa6kWO KQ9YeC2Bsf9i6cGX3tb63MkfrN5/SEgVL9wYVhoK5WJ2K1EXVwY2YJLzy68u7iUcQpfu xL5LaTFPEEK+Ph6d7d1QNRUOb0gkUbfrza8++aRBYhIRxQMazLQO9I7ZRfUz1VImAa/a /Pzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711557947; x=1712162747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b/uJsYX5TjTzzmu5D77iSjXX+egw1x7sUXQBSMn9NVQ=; b=HmWKqB0zjfkLpDpujaPHH32hVmgyukfqTk5g+Bj7g7LGffQhF3UMuQzlePtrAaRo+I gNHHFi9QxyF3Uq1whtr4oHHZcnlP/9p2gVSl2FuMDk4+3iPf04Hz7BvQjIwgMYCW1EVP zGCnr2qxDN80OTvwvU9kIafjzADH0yiLN1W8OO1kAsm8ugK0DpQdnLw5KmhhhUO0+LYU YDlvH9rYbnmzgQvS8cTzINOJssKPSmmlAgdw1TWT6iPwDhJVnsXHQFCwG6369v8W3vt+ AJMEAu1jIvNS4pAjgvCL1ViXxiRXqeBOeZ3tv0lklfb0rTM8cHE0WX5TBVdP57u8Sn6y lq/w== X-Gm-Message-State: AOJu0YytV9yN9nsekQgF8MMVp0Dq1jjH1+QISWTxosuwiqEszunsx2yF OMJYgncBA/q71g4m1VYgDNSr5pcYLbhZZGCWsFHo2C99uvzvyfWXXN34boMSzu6q/5ug/g0WHp3 V X-Google-Smtp-Source: AGHT+IH8DnKj18Cs39bQKQP7EPMH3JH38UoYmnL08nrJj2wumeZO5kYU5Tlxs3e9s09a+2UrYOJGjQ== X-Received: by 2002:a17:902:ce05:b0:1e0:e1dc:f27 with SMTP id k5-20020a170902ce0500b001e0e1dc0f27mr205423plg.69.1711557947483; Wed, 27 Mar 2024 09:45:47 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c3:b18e:67c4:6248:3d8a:f386]) by smtp.gmail.com with ESMTPSA id c4-20020a170903234400b001e20578b524sm858593plh.252.2024.03.27.09.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 09:45:46 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer , "H . J . Lu" Subject: [PATCH 07/15] math: Fix isnanf128 static build Date: Wed, 27 Mar 2024 13:45:19 -0300 Message-Id: <20240327164527.3717523-8-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327164527.3717523-1-adhemerval.zanella@linaro.org> References: <20240327164527.3717523-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Some static implementation of float128 routines might call __isnanf128, which is not provided by the static object. Checked on x86_64-linux-gnu. --- math/Makefile | 1 + sysdeps/ieee754/float128/float128_private.h | 2 +- sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/math/Makefile b/math/Makefile index f1d210797d..516fa72a26 100644 --- a/math/Makefile +++ b/math/Makefile @@ -372,6 +372,7 @@ libm-test-funcs-auto-static = \ # libm-test-funcs-auto-static libm-test-funcs-noauto-static = \ fmod \ + isnan \ # libm-test-funcs-noauto-static libm-test-funcs-narrow-static = libm-test-funcs-all-static = $(libm-test-funcs-auto-static) $(libm-test-funcs-noauto-static) diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h index 38a8bdd0fe..672bf3cccf 100644 --- a/sysdeps/ieee754/float128/float128_private.h +++ b/sysdeps/ieee754/float128/float128_private.h @@ -352,7 +352,7 @@ #define frexpl frexpf128 #define getpayloadl getpayloadf128 #define isinfl isinff128_do_not_use -#define isnanl isnanf128_do_not_use +#define isnanl isnanf128 #define ldexpl ldexpf128 #define llrintl llrintf128 #define llroundl llroundf128 diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/float128/s_isnanf128.c index 59f71533ce..b73a4e80d7 100644 --- a/sysdeps/ieee754/float128/s_isnanf128.c +++ b/sysdeps/ieee754/float128/s_isnanf128.c @@ -11,7 +11,11 @@ #include "../ldbl-128/s_isnanl.c" #if !IS_IN (libm) #include +#ifdef SHARED hidden_ver (__isnanf128_impl, __isnanf128) +#else +strong_alias (__isnanf128_impl, __isnanf128) +#endif _weak_alias (__isnanf128_impl, isnanl) versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34); #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34))