Message ID | 20240112092628.2464455-4-cederman@gaisler.com |
---|---|
State | New |
Headers | show |
Series | sparc: Treat the version field in the FPU control word as reserved | expand |
On 12/01/24 06:26, Daniel Cederman wrote: > The FSR version field is read-only and might be non-zero. > > This allows math/test-fpucw* to correctly pass when the version is > non-zero. > > Signed-off-by: Daniel Cederman <cederman@gaisler.com> It looks reasonable to mask off the version _FPU_RESERVED. It also means that it would be change by __setfpucw, although afaik the ISA guarantee that it can not be changed anyway. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > sysdeps/sparc/fpu/fpu_control.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h > index 9313743f86..36a2bf5d07 100644 > --- a/sysdeps/sparc/fpu/fpu_control.h > +++ b/sysdeps/sparc/fpu/fpu_control.h > @@ -42,7 +42,7 @@ > #define _FPU_RC_ZERO 0x40000000 > #define _FPU_RC_NEAREST 0x0 /* RECOMMENDED */ > > -#define _FPU_RESERVED 0x30300000 /* Reserved bits in cw */ > +#define _FPU_RESERVED 0x303e0000 /* Reserved bits in cw */ > > > /* Now two recommended cw */
Hello Adhemerval, Can you apply this to master if you are ok with the patch? /Daniel On 2024-01-12 18:42, Adhemerval Zanella Netto wrote: > > > On 12/01/24 06:26, Daniel Cederman wrote: >> The FSR version field is read-only and might be non-zero. >> >> This allows math/test-fpucw* to correctly pass when the version is >> non-zero. >> >> Signed-off-by: Daniel Cederman <cederman@gaisler.com> > > It looks reasonable to mask off the version _FPU_RESERVED. It also > means that it would be change by __setfpucw, although afaik the ISA > guarantee that it can not be changed anyway. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > >> --- >> sysdeps/sparc/fpu/fpu_control.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h >> index 9313743f86..36a2bf5d07 100644 >> --- a/sysdeps/sparc/fpu/fpu_control.h >> +++ b/sysdeps/sparc/fpu/fpu_control.h >> @@ -42,7 +42,7 @@ >> #define _FPU_RC_ZERO 0x40000000 >> #define _FPU_RC_NEAREST 0x0 /* RECOMMENDED */ >> >> -#define _FPU_RESERVED 0x30300000 /* Reserved bits in cw */ >> +#define _FPU_RESERVED 0x303e0000 /* Reserved bits in cw */ >> >> >> /* Now two recommended cw */
It seems I forgot to push this one, it is done now. On 15/02/24 06:31, Daniel Cederman wrote: > Hello Adhemerval, > > Can you apply this to master if you are ok with the patch? > > /Daniel > > On 2024-01-12 18:42, Adhemerval Zanella Netto wrote: >> >> >> On 12/01/24 06:26, Daniel Cederman wrote: >>> The FSR version field is read-only and might be non-zero. >>> >>> This allows math/test-fpucw* to correctly pass when the version is >>> non-zero. >>> >>> Signed-off-by: Daniel Cederman <cederman@gaisler.com> >> >> It looks reasonable to mask off the version _FPU_RESERVED. It also >> means that it would be change by __setfpucw, although afaik the ISA >> guarantee that it can not be changed anyway. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> >> >>> --- >>> sysdeps/sparc/fpu/fpu_control.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h >>> index 9313743f86..36a2bf5d07 100644 >>> --- a/sysdeps/sparc/fpu/fpu_control.h >>> +++ b/sysdeps/sparc/fpu/fpu_control.h >>> @@ -42,7 +42,7 @@ >>> #define _FPU_RC_ZERO 0x40000000 >>> #define _FPU_RC_NEAREST 0x0 /* RECOMMENDED */ >>> -#define _FPU_RESERVED 0x30300000 /* Reserved bits in cw */ >>> +#define _FPU_RESERVED 0x303e0000 /* Reserved bits in cw */ >>> /* Now two recommended cw */
diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h index 9313743f86..36a2bf5d07 100644 --- a/sysdeps/sparc/fpu/fpu_control.h +++ b/sysdeps/sparc/fpu/fpu_control.h @@ -42,7 +42,7 @@ #define _FPU_RC_ZERO 0x40000000 #define _FPU_RC_NEAREST 0x0 /* RECOMMENDED */ -#define _FPU_RESERVED 0x30300000 /* Reserved bits in cw */ +#define _FPU_RESERVED 0x303e0000 /* Reserved bits in cw */ /* Now two recommended cw */
The FSR version field is read-only and might be non-zero. This allows math/test-fpucw* to correctly pass when the version is non-zero. Signed-off-by: Daniel Cederman <cederman@gaisler.com> --- sysdeps/sparc/fpu/fpu_control.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)