diff mbox series

[v6,5/5] NEWS: Mention DT_RELR support

Message ID 20220310200329.1935466-6-hjl.tools@gmail.com
State New
Headers show
Series Support DT_RELR relative relocation format | expand

Commit Message

H.J. Lu March 10, 2022, 8:03 p.m. UTC
---
 NEWS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Adhemerval Zanella March 29, 2022, 5:25 p.m. UTC | #1
On 10/03/2022 17:03, H.J. Lu via Libc-alpha wrote:
> ---
>  NEWS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS b/NEWS
> index 626eeabf5d..5d64b794f1 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -9,7 +9,8 @@ Version 2.36
>  
>  Major new features:
>  
> -  [Add new features here]
> +* Support DT_RELR relative relocation format generated with the linker

Maybe

 * Support for DT_RELR relocation relocation format has been added to
   glibc.  This is a new ELF section type that improves the size of relative
   relocations in shared object files and position independent
   executables (PIE).  DT_RELR support requires linker support for
   -z pack-relative-relocs option, which is supported for some abi in recent
   binutils versions.


> +  option, -z pack-relative-relocs.
>  
>  Deprecated and removed features, and other changes affecting compatibility:
>
H.J. Lu March 29, 2022, 10:22 p.m. UTC | #2
On Tue, Mar 29, 2022 at 10:25 AM Adhemerval Zanella via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
>
>
> On 10/03/2022 17:03, H.J. Lu via Libc-alpha wrote:
> > ---
> >  NEWS | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/NEWS b/NEWS
> > index 626eeabf5d..5d64b794f1 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -9,7 +9,8 @@ Version 2.36
> >
> >  Major new features:
> >
> > -  [Add new features here]
> > +* Support DT_RELR relative relocation format generated with the linker
>
> Maybe
>
>  * Support for DT_RELR relocation relocation format has been added to
>    glibc.  This is a new ELF section type that improves the size of relative
>    relocations in shared object files and position independent
>    executables (PIE).  DT_RELR support requires linker support for
>    -z pack-relative-relocs option, which is supported for some abi in recent
>    binutils versions.
>
>
> > +  option, -z pack-relative-relocs.
> >
> >  Deprecated and removed features, and other changes affecting compatibility:
> >

How about this?

* Support for DT_RELR relative relocation format has been added to
  glibc.  This is a new ELF dynamic tag that improves the size of
  relative relocations in shared object files and position independent
  executables (PIE).  DT_RELR generation requires linker support for
  -z pack-relative-relocs option, which is supported for some targets
  in recent binutils versions.
Fangrui Song March 29, 2022, 11:34 p.m. UTC | #3
On 2022-03-29, H.J. Lu via Libc-alpha wrote:
>On Tue, Mar 29, 2022 at 10:25 AM Adhemerval Zanella via Libc-alpha
><libc-alpha@sourceware.org> wrote:
>>
>>
>>
>> On 10/03/2022 17:03, H.J. Lu via Libc-alpha wrote:
>> > ---
>> >  NEWS | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/NEWS b/NEWS
>> > index 626eeabf5d..5d64b794f1 100644
>> > --- a/NEWS
>> > +++ b/NEWS
>> > @@ -9,7 +9,8 @@ Version 2.36
>> >
>> >  Major new features:
>> >
>> > -  [Add new features here]
>> > +* Support DT_RELR relative relocation format generated with the linker
>>
>> Maybe
>>
>>  * Support for DT_RELR relocation relocation format has been added to
>>    glibc.  This is a new ELF section type that improves the size of relative
>>    relocations in shared object files and position independent
>>    executables (PIE).  DT_RELR support requires linker support for
>>    -z pack-relative-relocs option, which is supported for some abi in recent
>>    binutils versions.
>>
>>
>> > +  option, -z pack-relative-relocs.
>> >
>> >  Deprecated and removed features, and other changes affecting compatibility:
>> >
>
>How about this?
>
>* Support for DT_RELR relative relocation format has been added to
>  glibc.  This is a new ELF dynamic tag that improves the size of
>  relative relocations in shared object files and position independent
>  executables (PIE).  DT_RELR generation requires linker support for
>  -z pack-relative-relocs option, which is supported for some targets
>  in recent binutils versions.
>

Perhaps more specific (a user may want to know what "recent" means): for x86-64 in binutils 2.38.
It may or may not be worth adding words to imply that ld support for other targets will come in the future:)
Adhemerval Zanella March 30, 2022, 2:20 p.m. UTC | #4
On 29/03/2022 20:34, Fangrui Song wrote:
> On 2022-03-29, H.J. Lu via Libc-alpha wrote:
>> On Tue, Mar 29, 2022 at 10:25 AM Adhemerval Zanella via Libc-alpha
>> <libc-alpha@sourceware.org> wrote:
>>>
>>>
>>>
>>> On 10/03/2022 17:03, H.J. Lu via Libc-alpha wrote:
>>> > ---
>>> >  NEWS | 3 ++-
>>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>>> >
>>> > diff --git a/NEWS b/NEWS
>>> > index 626eeabf5d..5d64b794f1 100644
>>> > --- a/NEWS
>>> > +++ b/NEWS
>>> > @@ -9,7 +9,8 @@ Version 2.36
>>> >
>>> >  Major new features:
>>> >
>>> > -  [Add new features here]
>>> > +* Support DT_RELR relative relocation format generated with the linker
>>>
>>> Maybe
>>>
>>>  * Support for DT_RELR relocation relocation format has been added to
>>>    glibc.  This is a new ELF section type that improves the size of relative
>>>    relocations in shared object files and position independent
>>>    executables (PIE).  DT_RELR support requires linker support for
>>>    -z pack-relative-relocs option, which is supported for some abi in recent
>>>    binutils versions.
>>>
>>>
>>> > +  option, -z pack-relative-relocs.
>>> >
>>> >  Deprecated and removed features, and other changes affecting compatibility:
>>> >
>>
>> How about this?
>>
>> * Support for DT_RELR relative relocation format has been added to
>>  glibc.  This is a new ELF dynamic tag that improves the size of
>>  relative relocations in shared object files and position independent
>>  executables (PIE).  DT_RELR generation requires linker support for
>>  -z pack-relative-relocs option, which is supported for some targets
>>  in recent binutils versions.
>>
> 

Look ok.

> Perhaps more specific (a user may want to know what "recent" means): for x86-64 in binutils 2.38.
> It may or may not be worth adding words to imply that ld support for other targets will come in the future:)

I think 'recent' should be ok since we don't know if distros will backport it
(so tying to a version might be misleading).
diff mbox series

Patch

diff --git a/NEWS b/NEWS
index 626eeabf5d..5d64b794f1 100644
--- a/NEWS
+++ b/NEWS
@@ -9,7 +9,8 @@  Version 2.36
 
 Major new features:
 
-  [Add new features here]
+* Support DT_RELR relative relocation format generated with the linker
+  option, -z pack-relative-relocs.
 
 Deprecated and removed features, and other changes affecting compatibility: