Message ID | 20220126195737.45163-1-mark@klomp.org |
---|---|
State | New |
Headers | show |
Series | Guard tst-valgrind-smoke.out with run-built-tests | expand |
On 26/01/2022 16:57, Mark Wielaard wrote: > Prevent tst-valgrind-smoke from running when run-built-tests is not yes. LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > elf/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > Resent as separate PATCH to get it into patchwork. > > diff --git a/elf/Makefile b/elf/Makefile > index daafb5cf12..775c755291 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -530,7 +530,9 @@ endif > endif > endif > > +ifeq ($(run-built-tests),yes) > tests-special += $(objpfx)tst-valgrind-smoke.out > +endif > $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test > $(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \ > '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
Hi, On Wed, Jan 26, 2022 at 05:08:48PM -0300, Adhemerval Zanella wrote: > On 26/01/2022 16:57, Mark Wielaard wrote: > > Prevent tst-valgrind-smoke from running when run-built-tests is not yes. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Thanks. The patchwork trybot is also green. Pushed, Mark
diff --git a/elf/Makefile b/elf/Makefile index daafb5cf12..775c755291 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -530,7 +530,9 @@ endif endif endif +ifeq ($(run-built-tests),yes) tests-special += $(objpfx)tst-valgrind-smoke.out +endif $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test $(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \ '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)