From patchwork Mon Jul 19 16:38:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 1507132 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=D09OD3K4; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GT6z94vCXz9sRN for ; Tue, 20 Jul 2021 02:40:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 328ED3959E40 for ; Mon, 19 Jul 2021 16:40:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 328ED3959E40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626712835; bh=Q31k362FMo+DsLJOdCEFrEZdZfUuzcJgr1gmwlPt70o=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=D09OD3K43MKzGYYNnd9zeRYh4ikPmgXKtw26VPcDeAUoiF1Vpru4YJOlbuZ+fwbRw HRu//7PQuhHwzkVpVIN2emhvFZOELrdA3ahXFrrIgzK0osgKiLOFpZpzgxsNA5pUNr LdT1xJLtHjLTIRKC381SR9iCazk6bhdHMJQT+KfM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id E80E93848406 for ; Mon, 19 Jul 2021 16:38:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E80E93848406 Received: by mail-pg1-x529.google.com with SMTP id 37so19617967pgq.0 for ; Mon, 19 Jul 2021 09:38:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q31k362FMo+DsLJOdCEFrEZdZfUuzcJgr1gmwlPt70o=; b=DxggeXSK6KLzp4+BhTuyVvRKI9hskkX36shHZgUyPKjoZ2KiRQu2TREjxIJMhNb/X0 qk8akyAK42iKC+SrKsu/+riZfuRZZA+5lOugipqYTe35LFooQnoyJa2tFr6jIQacUlvn FssQXW1w5X9/UVHVg69o9duq8iMsMXtil+lbkguJPi6jPwNmG5IVjB1DKWiUUa6OKQGG odjTMdz1kXWnxw+OXHf4hzbgyQRh9MGX3tVQsUPFn4t7cE1xNO3o7JDzIKfoYtKAJb8W Hm+S8nj+MlRSz62mjzgkfGmOx3rRY8+CW54+nGtcEdRA1KJruwZ8DVFbalJ2UeVZ7F8K fDrw== X-Gm-Message-State: AOAM531iEDlMFiJ0eF6z+z+LOclUApiNGhwZ9tEIM//QhZp1eOV1C7Fb w1rFlskaqWjE0lmMWeU2EuPMUJTi60UwNw== X-Google-Smtp-Source: ABdhPJy4/1f5aSJU6zWKGyi+CNO8PCYMKrRsYnQGZ6gGWqhqPp2Clf/bzMZX3Yd38X6lofvDFMGQ+A== X-Received: by 2002:a63:5117:: with SMTP id f23mr25987193pgb.200.1626712732962; Mon, 19 Jul 2021 09:38:52 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:1133:c8a4:b05d:5ba9:3665]) by smtp.gmail.com with ESMTPSA id l2sm20074055pfc.157.2021.07.19.09.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 09:38:52 -0700 (PDT) To: libc-alpha@sourceware.org, Carlos O'Donell Subject: [PATCH 2/4] time: Ignore interval nanoseconds on tst-itimer Date: Mon, 19 Jul 2021 13:38:44 -0300 Message-Id: <20210719163846.2954193-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210719163846.2954193-1-adhemerval.zanella@linaro.org> References: <20210719163846.2954193-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Running the test on a 4.4 kernel within KVM, the precision used on ITIMER_VIRTUAL and ITIMER_PROF seems to different than the one used for ITIMER_REAL (it seems the same used for CLOCK_REALTIME_COARSE and CLOCK_MONOTONIC_COARSE). I did not see it on other kernels, for instance 5.11 and 4.15. To avoid trying to guess the resolution used, do not check the nanosecond internal values for the specific timers. Checked on i686-linux-gnu with a 4.4 kernel. --- time/tst-itimer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/time/tst-itimer.c b/time/tst-itimer.c index 929c2b74c7..554caa75f2 100644 --- a/time/tst-itimer.c +++ b/time/tst-itimer.c @@ -74,6 +74,9 @@ do_test (void) { TEST_COMPARE (it_old.it_interval.tv_sec, 10); TEST_COMPARE (it_old.it_interval.tv_usec, 20); + /* Some systems might use a different precision for ITIMER_VIRTUAL + and ITIMER_iPROF and thus the value might be adjusted. To avoid + trying to guess the resolution, we do not check it. */ } /* Create a periodic timer and check if the return value is the one @@ -87,7 +90,8 @@ do_test (void) TEST_COMPARE (setitimer (timers[i], &(struct itimerval) { 0 }, &it_old), 0); TEST_COMPARE (it.it_interval.tv_sec, it_old.it_interval.tv_sec); - TEST_COMPARE (it.it_interval.tv_usec, it_old.it_interval.tv_usec); + if (timers[i] == ITIMER_REAL) + TEST_COMPARE (it.it_interval.tv_usec, it_old.it_interval.tv_usec); if (sizeof (time_t) == 4) continue;