Message ID | 20201221042854.1467431-1-siddhesh@sourceware.org |
---|---|
State | New |
Headers | show
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=sourceware.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=PDOvOPpr; dkim-atps=neutral Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CzmhK66GQz9sVk for <incoming@patchwork.ozlabs.org>; Mon, 21 Dec 2020 15:29:21 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E5B5F385E005; Mon, 21 Dec 2020 04:29:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5B5F385E005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608524960; bh=Zt55O8OwfmHBSI8Dmxg113l7bk316wDSCMDVnYE5ATY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PDOvOPpraKJk7WRAqgioPLTARr1XdNQwFv+tx0AnmLmV8MGNGmP51qr3S1Pyjq4uG 4+cWm+j2+60/OWrzlAremFR+JdRTSkg2FkeCO81WyrfgIFkpL+bS47Q8jOXgVTifbN LvJEtYaJPyYmebyjddco9J3/4JmqIfqBhpX+8aII= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id 71E56385DC37 for <libc-alpha@sourceware.org>; Mon, 21 Dec 2020 04:29:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71E56385DC37 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EA8333412FD; Mon, 21 Dec 2020 04:29:15 +0000 (UTC) Received: from pdx1-sub0-mail-a2.g.dreamhost.com (100-96-87-21.trex.outbound.svc.cluster.local [100.96.87.21]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 31E33340F8F; Mon, 21 Dec 2020 04:29:15 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a2.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 21 Dec 2020 04:29:15 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Tank-Gusty: 6dd9ef2d03d85aea_1608524955510_1082115063 X-MC-Loop-Signature: 1608524955510:3860409604 X-MC-Ingress-Time: 1608524955510 Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id C07D582462; Sun, 20 Dec 2020 20:29:14 -0800 (PST) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id 2D5AE7E5C7; Sun, 20 Dec 2020 20:29:10 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a2 To: libc-alpha@sourceware.org Subject: [COMMITTED] iconv add iconv_close before the function returned with bad value. Date: Mon, 21 Dec 2020 09:58:54 +0530 Message-Id: <20201221042854.1467431-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20191214081851.378-1-liqingqing3@huawei.com> References: <20191214081851.378-1-liqingqing3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Siddhesh Poyarekar <siddhesh@sourceware.org> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
[COMMITTED] iconv add iconv_close before the function returned with bad value.
|
expand
|
diff --git a/iconv/tst-iconv5.c b/iconv/tst-iconv5.c index 8211843e4f..09cec9c4bf 100644 --- a/iconv/tst-iconv5.c +++ b/iconv/tst-iconv5.c @@ -72,6 +72,7 @@ convert (const char *tocode, const char *fromcode, char *inbufp, { printf ("iconv failed: from: %s, to: %s: %s", fromcode, tocode, strerror (errno)); + iconv_close (ic); return -1; } }
From: liqingqing <liqingqing3@huawei.com> Fixed up whitespaces and committed -- Siddhesh add iconv_close before the function returned with bad value. --- iconv/tst-iconv5.c | 1 + 1 file changed, 1 insertion(+)