Message ID | 20191007130749.29272-1-pvorel@suse.cz |
---|---|
State | Accepted |
Headers | show |
Series | <dirent.h>: Remove wrong comment about getdents64() declaration | expand |
* Petr Vorel: > Originally the public interface for getdents64 was declared in > <unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>. > > Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>") > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > include/dirent.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/dirent.h b/include/dirent.h > index 3736803bce..1f0121f3d9 100644 > --- a/include/dirent.h > +++ b/include/dirent.h > @@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf, > __off_t *__restrict __basep) > __THROW __nonnull ((2, 4)); > > -/* These functions are only implemented on Linux. The public > - interface for getdents64 is declared in <unistd.h>. */ > +/* These functions are only implemented on Linux. */ > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes) > attribute_hidden; > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes); Looks good to me, thanks. I assume you don't have commit access. I can install the patch for you. Florian
Hi Florian, ... > > -/* These functions are only implemented on Linux. The public > > - interface for getdents64 is declared in <unistd.h>. */ > > +/* These functions are only implemented on Linux. */ > > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes) > > attribute_hidden; > > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes); > Looks good to me, thanks. I assume you don't have commit access. I can > install the patch for you. Thanks for review. No, I don't have commit access :). > Florian Kind regards, Petr
* Petr Vorel: > Hi Florian, > > ... >> > -/* These functions are only implemented on Linux. The public >> > - interface for getdents64 is declared in <unistd.h>. */ >> > +/* These functions are only implemented on Linux. */ >> > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes) >> > attribute_hidden; >> > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes); > >> Looks good to me, thanks. I assume you don't have commit access. I can >> install the patch for you. > Thanks for review. No, I don't have commit access :). Thanks, I've messaged the patch a little bit and pushed it for yoy. Florian
Hi Florian, > > ... > >> > -/* These functions are only implemented on Linux. The public > >> > - interface for getdents64 is declared in <unistd.h>. */ > >> > +/* These functions are only implemented on Linux. */ > >> > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes) > >> > attribute_hidden; > >> > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes); > >> Looks good to me, thanks. I assume you don't have commit access. I can > >> install the patch for you. > > Thanks for review. No, I don't have commit access :). > Thanks, I've messaged the patch a little bit and pushed it for yoy. Thanks a lot! BTW I've noticed discussion on ML about dropping ChangeLogs, but I guess it'll be dropped after 2.31 release. > Florian Kind regards, Petr
* Petr Vorel: > BTW I've noticed discussion on ML about dropping ChangeLogs, > but I guess it'll be dropped after 2.31 release. I'm not sure about that yet. But it was easy to add the ChangeLog entry so that I could push the fix now. Thanks, Florian
diff --git a/include/dirent.h b/include/dirent.h index 3736803bce..1f0121f3d9 100644 --- a/include/dirent.h +++ b/include/dirent.h @@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf, __off_t *__restrict __basep) __THROW __nonnull ((2, 4)); -/* These functions are only implemented on Linux. The public - interface for getdents64 is declared in <unistd.h>. */ +/* These functions are only implemented on Linux. */ extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes) attribute_hidden; extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
Originally the public interface for getdents64 was declared in <unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>. Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- include/dirent.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)