From patchwork Tue Jan 19 21:18:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 570133 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5815E1402D8 for ; Wed, 20 Jan 2016 08:18:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=Irv+tr36; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=BRHCM9+40/Oi70ZI5AzH3Mp3uyuKr hVm7A/r8P/Z7amM7Q1pJ6sP6mIqB4KaqUMTC9ogJ2HF3b44vtQuYb1W4NvgsRQpv HsdEldlSXZeqmeUzqWJ8LOlLjSmzE32pgYWEYK90Ux8994/MXXmhcErHNNIfCKpK TfhqK3FCQ9QbGg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=ZNfLJ1goGlSq5Faob0AGRKD/Lr0=; b=Irv +tr36k3rkYhLrIfMyXG+YwQAtzRsb1NiRzO+AZk8IimXUVlpbR/QCRb3nxU9lgSC +fdAq2gWJaP4VCUhwCpKGR7LOwWo9KxgOaJt/3FoBROdMstwyCxlFUOOdXU/pEXl R9FG/Uz0B6oMXRHDhJC5Vwp1RTvXaXhqbM7zH240= Received: (qmail 39825 invoked by alias); 19 Jan 2016 21:18:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 39807 invoked by uid 89); 19 Jan 2016 21:18:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=468, ghz, incident, Default X-HELO: smtp.gentoo.org Date: Tue, 19 Jan 2016 16:18:40 -0500 From: Mike Frysinger To: libc-alpha@sourceware.org Subject: increasing default timeout significantly Message-ID: <20160119211840.GJ14840@vapier.lan> Mail-Followup-To: libc-alpha@sourceware.org MIME-Version: 1.0 Content-Disposition: inline is there a compelling reason to keep the default timeout so low ? the vast majority of timeouts i've seen w/glibc tests are due to: - slow system (e.g. <1 GHz cpu) - loaded system (e.g. lots of parallelism) even then, i've seen timeouts on system i don't generally consider slow, or even loaded, and considering TIMEOUT is set to <=10 in ~60 tests (and <=20 in ~75 tests), it seems i'm not alone. i've just gotten in the habit of doing `export TIMEOUTFACTOR=10` on all my setups. in the edge case where there is a bug in the test and the timeout is hit, i think we all agree that's either a problem with the test or a real bug in the library somewhere. in either case, the incident rate should be low, so catering to that seems like the wrong trade-off. -mike --- a/test-skeleton.c +++ b/test-skeleton.c @@ -46,8 +46,9 @@ #endif #ifndef TIMEOUT - /* Default timeout is two seconds. */ -# define TIMEOUT 2 + /* Default timeout is twenty seconds. Tests should normally complete faster + than this, but if they don't, that's abnormal (a bug) anyways. */ +# define TIMEOUT 20 #endif #define OPT_DIRECT 1000