Message ID | 20150213175310.GB23372@suse.de |
---|---|
State | New |
Headers | show |
On Fri, Feb 13, 2015 at 05:53:10PM +0000, Mel Gorman wrote: > (No code change since v2 but am updating the changelog as local testing > indicates the patch fixes 17195 and allows similar problems > to be tuned. Note that bug 17195 is marked as a duplicate of bug 1128 but > they are different bugs as 1128 is concerned with sbrk where as 17195 is > hitting madvise) > It's been a week since V2 was posted and V3 only updated the changelog so sending a ping mail asking for review as per the glibc contribution checklist. Thanks.
On 02/17/2015 03:08 PM, Mel Gorman wrote: > On Fri, Feb 13, 2015 at 05:53:10PM +0000, Mel Gorman wrote: >> (No code change since v2 but am updating the changelog as local testing >> indicates the patch fixes 17195 and allows similar problems >> to be tuned. Note that bug 17195 is marked as a duplicate of bug 1128 but >> they are different bugs as 1128 is concerned with sbrk where as 17195 is >> hitting madvise) >> > > It's been a week since V2 was posted and V3 only updated the changelog > so sending a ping mail asking for review as per the glibc contribution > checklist. Under review by me. Thanks for the ping. I won't get to this until Friday or next Monday though. I got blocked on a couple of other things. http://patchwork.sourceware.org/patch/5068/ Cheers, Carlos.
diff --git a/ChangeLog b/ChangeLog index dc1ed1ba1249..b860b2fe1850 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2015-02-10 Mel Gorman <mgorman@suse.de> + + * malloc/arena.c (free): Apply trim threshold to per-thread heaps + as well as the main arena. + 2015-02-06 Carlos O'Donell <carlos@systemhalted.org> * version.h (RELEASE): Set to "stable". diff --git a/malloc/arena.c b/malloc/arena.c index 886defb074a2..a78d4835a825 100644 --- a/malloc/arena.c +++ b/malloc/arena.c @@ -696,7 +696,7 @@ heap_trim (heap_info *heap, size_t pad) } top_size = chunksize (top_chunk); extra = (top_size - pad - MINSIZE - 1) & ~(pagesz - 1); - if (extra < (long) pagesz) + if (extra < (long) mp_.trim_threshold) return 0; /* Try to shrink. */