From patchwork Thu Jul 10 12:52:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 368666 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B32911400A0 for ; Thu, 10 Jul 2014 22:53:04 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-type:content-transfer-encoding :in-reply-to; q=dns; s=default; b=djF+UQ7Q0Fh/Mq499Dw3z9F6M403X9 a8KPMCsysKaYtV77SffU3HQlt9fn/htbKsyyjGIubLQJertWliaISugbAF5d/dRf eZ2dKR/ZP2KrT/GrMQ9zN1Nv3gmuF9xQwNHUOaZSdQZ82oexYLvNrjI37i2B/Tq7 uya4dgtNA7BS8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=default; bh=OD8pP4YVmWdA0nzJjiqvjseIbrM=; b=EnPp Bs8PZceG9ihaRwoFda4X/PwrX2n2Nf+wvXhYHebjn5KCevyPznh30ipqAwh404JW dK0mhuAEaqZYRCvav51GF6vAfKQ5p+CawZjeP2ymq0AUC/9dhT5ILKP0JEAhB5Lv hecbxV+m21BoyzAPbFhhttvwEY45bHiWpVeL2VI= Received: (qmail 32017 invoked by alias); 10 Jul 2014 12:52:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 31882 invoked by uid 89); 10 Jul 2014 12:52:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Date: Thu, 10 Jul 2014 14:52:22 +0200 From: Jakub Jelinek To: Jason Merrill , "Joseph S. Myers" Cc: Manuel =?iso-8859-1?B?TPNwZXotSWLh8WV6?= , Gcc Patch List , Richard Biener , Siddhesh Poyarekar , "Carlos O'Donell" , GNU C Library Subject: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2) Message-ID: <20140710125222.GI31640@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <53BDB402.20309@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53BDB402.20309@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) On Wed, Jul 09, 2014 at 05:28:34PM -0400, Jason Merrill wrote: > On 07/09/2014 10:40 AM, Manuel López-Ibáñez wrote: > >>All of these warnings (-Wsizeof-pointer-memaccess, -Wsizeof-array-argument > >>and -Wmemset-transposed-args) are implemented in a hackish way, because we > >>fold everything too early. Perhaps for such analysis we want a FOLDED_EXPR > >>which would have arguments what it has been folded to and the original tree, > >>for the purposes of code generation the first argument would be used and > >>the second one only for the analysis. We don't have that many spots where > >>we need the original trees to be analyzed yet for it to be worth it though > >>IMHO. > > > >But if we keep adding hacks around it, there will never be progress > >and the person(s) who take the challenge of properly fixing this will > >not only have to deal with the task itself but also with all the ugly > >and obscure hacks added year after year. > > I'm planning to address this soon, hopefully this stage 1. So like this then? As the testcases show, only literal zero (0, 0L, '\0', u'\0', U'\0' etc.) alone is now recognized, 0 - 0 or (int) 0 don't count. On Richard's request I'm stripping the special INTEGER_CSTs early again. The C FE uses a bitmask on the side (similarly how it already handles sizeof). 2014-07-10 Jakub Jelinek PR middle-end/61294 gcc/c-family/ * c.opt (Wmemset-transposed-args): New warning. gcc/c/ * c-parser.c (c_parser_expr_list): Add new argument literal_zero_mask. If non-NULL, call c_parser_check_literal_zero. (c_parser_check_literal_zero): New function. (c_parser_postfix_expression_after_primary): Adjust c_parser_expr_list caller, handle -Wmemset-transposed-args. gcc/cp/ * cp-tree.h (LITERAL_ZERO_P): Define. * parser.c (cp_parser_parenthesized_expression_list): Add want_literal_zero_p argument, if true, for literal zeros insert INTEGER_CSTs with LITERAL_ZERO_P flag set. (cp_parser_postfix_expression): Adjust cp_parser_parenthesized_expression_list caller, handle -Wmemset-transposed-args. (literal_zeros): New variable. gcc/ * doc/invoke.texi (-Wmemset-transposed-args): Document. gcc/testsuite/ * c-c++-common/Wmemset-transposed-args1.c: New test. * c-c++-common/Wmemset-transposed-args2.c: New test. * g++.dg/warn/Wmemset-transposed-args-1.C: New test. Jakub --- gcc/c/c-parser.c.jj 2014-07-09 13:20:33.000000000 +0200 +++ gcc/c/c-parser.c 2014-07-10 14:15:27.221202422 +0200 @@ -1204,7 +1204,8 @@ static struct c_expr c_parser_expression static struct c_expr c_parser_expression_conv (c_parser *); static vec *c_parser_expr_list (c_parser *, bool, bool, vec **, location_t *, - tree *, vec *); + tree *, vec *, + unsigned int * = NULL); static void c_parser_omp_construct (c_parser *); static void c_parser_omp_threadprivate (c_parser *); static void c_parser_omp_barrier (c_parser *); @@ -7655,6 +7656,7 @@ c_parser_postfix_expression_after_primar tree ident, idx; location_t sizeof_arg_loc[3]; tree sizeof_arg[3]; + unsigned int literal_zero_mask; unsigned int i; vec *exprlist; vec *origtypes = NULL; @@ -7709,12 +7711,13 @@ c_parser_postfix_expression_after_primar sizeof_arg[i] = NULL_TREE; sizeof_arg_loc[i] = UNKNOWN_LOCATION; } + literal_zero_mask = 0; if (c_parser_next_token_is (parser, CPP_CLOSE_PAREN)) exprlist = NULL; else exprlist = c_parser_expr_list (parser, true, false, &origtypes, sizeof_arg_loc, sizeof_arg, - &arg_loc); + &arg_loc, &literal_zero_mask); c_parser_skip_until_found (parser, CPP_CLOSE_PAREN, "expected %<)%>"); orig_expr = expr; @@ -7724,6 +7727,18 @@ c_parser_postfix_expression_after_primar expr.value, exprlist, sizeof_arg, sizeof_ptr_memacc_comptypes); + if (warn_memset_transposed_args + && DECL_BUILT_IN_CLASS (expr.value) == BUILT_IN_NORMAL + && DECL_FUNCTION_CODE (expr.value) == BUILT_IN_MEMSET + && vec_safe_length (exprlist) == 3 + && integer_zerop ((*exprlist)[2]) + && (literal_zero_mask & (1 << 2)) != 0 + && (!integer_zerop ((*exprlist)[1]) + || (literal_zero_mask & (1 << 1)) == 0)) + warning_at (expr_loc, OPT_Wmemset_transposed_args, + "% used with constant zero length parameter; " + "this could be due to transposed parameters"); + expr.value = c_build_function_call_vec (expr_loc, arg_loc, expr.value, exprlist, origtypes); @@ -7891,6 +7906,36 @@ c_parser_expression_conv (c_parser *pars return expr; } +/* Helper function of c_parser_expr_list. Check if IDXth (0 based) + argument is a literal zero alone and if so, set it in literal_zero_mask. */ + +static inline void +c_parser_check_literal_zero (c_parser *parser, unsigned *literal_zero_mask, + unsigned int idx) +{ + if (idx >= HOST_BITS_PER_INT) + return; + + c_token *tok = c_parser_peek_token (parser); + switch (tok->type) + { + case CPP_NUMBER: + case CPP_CHAR: + case CPP_WCHAR: + case CPP_CHAR16: + case CPP_CHAR32: + /* If a parameter is literal zero alone, remember it + for -Wmemset-transposed-args warning. */ + if (integer_zerop (tok->value) + && !TREE_OVERFLOW (tok->value) + && (c_parser_peek_2nd_token (parser)->type == CPP_COMMA + || c_parser_peek_2nd_token (parser)->type == CPP_CLOSE_PAREN)) + *literal_zero_mask |= 1U << idx; + default: + break; + } +} + /* Parse a non-empty list of expressions. If CONVERT_P, convert functions and arrays to pointers and lvalues to rvalues. If FOLD_P, fold the expressions. If LOCATIONS is non-NULL, save the @@ -7905,7 +7950,8 @@ static vec * c_parser_expr_list (c_parser *parser, bool convert_p, bool fold_p, vec **p_orig_types, location_t *sizeof_arg_loc, tree *sizeof_arg, - vec *locations) + vec *locations, + unsigned int *literal_zero_mask) { vec *ret; vec *orig_types; @@ -7923,6 +7969,8 @@ c_parser_expr_list (c_parser *parser, bo if (sizeof_arg != NULL && c_parser_next_token_is_keyword (parser, RID_SIZEOF)) cur_sizeof_arg_loc = c_parser_peek_2nd_token (parser)->location; + if (literal_zero_mask) + c_parser_check_literal_zero (parser, literal_zero_mask, 0); expr = c_parser_expr_no_commas (parser, NULL); if (convert_p) expr = convert_lvalue_to_rvalue (loc, expr, true, true); @@ -7949,6 +7997,8 @@ c_parser_expr_list (c_parser *parser, bo cur_sizeof_arg_loc = c_parser_peek_2nd_token (parser)->location; else cur_sizeof_arg_loc = UNKNOWN_LOCATION; + if (literal_zero_mask) + c_parser_check_literal_zero (parser, literal_zero_mask, idx + 1); expr = c_parser_expr_no_commas (parser, NULL); if (convert_p) expr = convert_lvalue_to_rvalue (loc, expr, true, true); --- gcc/cp/cp-tree.h.jj 2014-07-09 13:20:33.922835883 +0200 +++ gcc/cp/cp-tree.h 2014-07-10 13:16:01.066372163 +0200 @@ -4187,6 +4187,10 @@ more_aggr_init_expr_args_p (const aggr_i #define SIZEOF_EXPR_TYPE_P(NODE) \ TREE_LANG_FLAG_0 (SIZEOF_EXPR_CHECK (NODE)) +/* True if INTEGER_CST is a zero literal seen in function argument list. */ +#define LITERAL_ZERO_P(NODE) \ + (INTEGER_CST_CHECK (NODE)->base.nothrow_flag) + /* An enumeration of the kind of tags that C++ accepts. */ enum tag_types { none_type = 0, /* Not a tag type. */ --- gcc/cp/parser.c.jj 2014-07-09 13:20:33.844836255 +0200 +++ gcc/cp/parser.c 2014-07-10 14:00:37.915749580 +0200 @@ -1929,7 +1929,7 @@ static tree cp_parser_postfix_open_squar static tree cp_parser_postfix_dot_deref_expression (cp_parser *, enum cpp_ttype, tree, bool, cp_id_kind *, location_t); static vec *cp_parser_parenthesized_expression_list - (cp_parser *, int, bool, bool, bool *); + (cp_parser *, int, bool, bool, bool *, bool = false); /* Values for the second parameter of cp_parser_parenthesized_expression_list. */ enum { non_attr = 0, normal_attr = 1, id_attr = 2 }; static void cp_parser_pseudo_destructor_name @@ -6074,7 +6074,8 @@ cp_parser_postfix_expression (cp_parser args = (cp_parser_parenthesized_expression_list (parser, non_attr, /*cast_p=*/false, /*allow_expansion_p=*/true, - /*non_constant_p=*/NULL)); + /*non_constant_p=*/NULL, + /*want_literal_zero_p=*/warn_memset_transposed_args)); if (is_builtin_constant_p) { parser->integral_constant_expression_p @@ -6142,6 +6143,30 @@ cp_parser_postfix_expression (cp_parser } } + if (warn_memset_transposed_args) + { + if (TREE_CODE (postfix_expression) == FUNCTION_DECL + && DECL_BUILT_IN_CLASS (postfix_expression) == BUILT_IN_NORMAL + && DECL_FUNCTION_CODE (postfix_expression) == BUILT_IN_MEMSET + && vec_safe_length (args) == 3 + && integer_zerop ((*args)[2]) + && LITERAL_ZERO_P ((*args)[2]) + && !(integer_zerop ((*args)[1]) + && LITERAL_ZERO_P ((*args)[1]))) + warning (OPT_Wmemset_transposed_args, + "% used with constant zero length " + "parameter; this could be due to transposed " + "parameters"); + + /* Replace LITERAL_ZERO_P INTEGER_CSTs with normal ones + to avoid leaking those into folder and middle-end. */ + unsigned int i; + tree arg; + FOR_EACH_VEC_SAFE_ELT (args, i, arg) + if (TREE_CODE (arg) == INTEGER_CST && LITERAL_ZERO_P (arg)) + (*args)[i] = build_int_cst (TREE_TYPE (arg), 0); + } + if (TREE_CODE (postfix_expression) == COMPONENT_REF) { tree instance = TREE_OPERAND (postfix_expression, 0); @@ -6630,6 +6655,10 @@ cp_parser_postfix_dot_deref_expression ( return postfix_expression; } +/* Cache of LITERAL_ZERO_P constants. */ + +static GTY(()) tree literal_zeros[itk_none]; + /* Parse a parenthesized expression-list. expression-list: @@ -6654,14 +6683,18 @@ cp_parser_postfix_dot_deref_expression ( plain identifier argument, normal_attr for an attribute that wants an expression, or non_attr if we aren't parsing an attribute list. If NON_CONSTANT_P is non-NULL, *NON_CONSTANT_P indicates whether or - not all of the expressions in the list were constant. */ + not all of the expressions in the list were constant. + WANT_LITERAL_ZERO_P is true if the caller is interested in + LITERAL_ZERO_P INTEGER_CSTs. FIXME: once we don't fold everything + immediately, this can be removed. */ static vec * cp_parser_parenthesized_expression_list (cp_parser* parser, int is_attribute_list, bool cast_p, bool allow_expansion_p, - bool *non_constant_p) + bool *non_constant_p, + bool want_literal_zero_p) { vec *expression_list; bool fold_expr_p = is_attribute_list != non_attr; @@ -6724,7 +6757,50 @@ cp_parser_parenthesized_expression_list *non_constant_p = true; } else - expr = cp_parser_assignment_expression (parser, cast_p, NULL); + { + expr = NULL_TREE; + cp_token *tok = cp_lexer_peek_token (parser->lexer); + switch (tok->type) + { + case CPP_NUMBER: + case CPP_CHAR: + case CPP_WCHAR: + case CPP_CHAR16: + case CPP_CHAR32: + /* If a parameter is literal zero alone, remember it + for -Wmemset-transposed-args warning. */ + if (integer_zerop (tok->u.value) + && !TREE_OVERFLOW (tok->u.value) + && want_literal_zero_p + && (cp_lexer_peek_nth_token (parser->lexer, 2)->type + == CPP_COMMA + || cp_lexer_peek_nth_token (parser->lexer, 2)->type + == CPP_CLOSE_PAREN)) + { + unsigned int i; + for (i = 0; i < itk_none; ++i) + if (TREE_TYPE (tok->u.value) == integer_types[i]) + break; + if (i < itk_none && literal_zeros[i]) + expr = literal_zeros[i]; + else + { + expr = copy_node (tok->u.value); + LITERAL_ZERO_P (expr) = 1; + if (i < itk_none) + literal_zeros[i] = expr; + } + /* Consume the 0 token (or '\0', 0LL etc.). */ + cp_lexer_consume_token (parser->lexer); + } + break; + default: + break; + } + if (expr == NULL_TREE) + expr = cp_parser_assignment_expression (parser, cast_p, + NULL); + } if (fold_expr_p) expr = fold_non_dependent_expr (expr); --- gcc/c-family/c.opt.jj 2014-07-09 13:20:33.841836272 +0200 +++ gcc/c-family/c.opt 2014-07-10 13:16:01.162371729 +0200 @@ -518,6 +518,10 @@ Wmain LangEnabledBy(C ObjC C++ ObjC++,Wpedantic, 2, 0) ; +Wmemset-transposed-args +C ObjC C++ ObjC++ Var(warn_memset_transposed_args) Warning LangEnabledBy(C ObjC C++ ObjC++,Wall) +Warn about suspicious call to memset where the third argument is constant zero and second is not zero + Wmissing-braces C ObjC C++ ObjC++ Var(warn_missing_braces) Warning LangEnabledBy(C ObjC,Wall) Warn about possibly missing braces around initializers --- gcc/doc/invoke.texi.jj 2014-07-09 13:20:33.567837626 +0200 +++ gcc/doc/invoke.texi 2014-07-10 14:24:23.419458164 +0200 @@ -257,8 +257,8 @@ Objective-C and Objective-C++ Dialects}. -Wno-int-to-pointer-cast -Wno-invalid-offsetof @gol -Winvalid-pch -Wlarger-than=@var{len} -Wunsafe-loop-optimizations @gol -Wlogical-op -Wlogical-not-parentheses -Wlong-long @gol --Wmain -Wmaybe-uninitialized -Wmissing-braces -Wmissing-field-initializers @gol --Wmissing-include-dirs @gol +-Wmain -Wmaybe-uninitialized -Wmemset-transposed-args -Wmissing-braces @gol +-Wmissing-field-initializers -Wmissing-include-dirs @gol -Wno-multichar -Wnonnull -Wno-overflow -Wopenmp-simd @gol -Woverlength-strings -Wpacked -Wpacked-bitfield-compat -Wpadded @gol -Wparentheses -Wpedantic-ms-format -Wno-pedantic-ms-format @gol @@ -4683,6 +4683,18 @@ Warn when the @code{sizeof} operator is declared as an array in a function definition. This warning is enabled by default for C and C++ programs. +@item -Wmemset-transposed-args +@opindex Wmemset-transposed-args +@opindex Wno-memset-transposed-args +Warn for suspicious calls to the memset built-in function, if the +second argument is not zero and third argument is zero. This warns e.g.@ +about @code{memset (buf, sizeof buf, 0);} where most probably +@code{memset (buf, 0, sizeof buf);} was meant instead. The diagnostics +is only emitted if the third argument is literal zero, if it is some expression +that is folded to zero, or e.g. a cast of zero to some type etc., it +is far less likely that user has mistakenly exchanged the arguments and +no warning is emitted. This warning is enabled by @option{-Wall}. + @item -Waddress @opindex Waddress @opindex Wno-address --- gcc/testsuite/c-c++-common/Wmemset-transposed-args1.c.jj 2014-07-10 13:16:01.145371805 +0200 +++ gcc/testsuite/c-c++-common/Wmemset-transposed-args1.c 2014-07-10 13:56:16.251092460 +0200 @@ -0,0 +1,31 @@ +/* { dg-do compile } */ +/* { dg-options "-Wall" } */ + +typedef __SIZE_TYPE__ size_t; +extern +#ifdef __cplusplus +"C" +#endif +void *memset (void *, int, size_t); +char buf[1024]; + +void +foo () +{ + memset (buf, sizeof buf, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, '\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, L'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, 1, 1 - 1); + memset (buf, 1, 0 - 0); + memset (buf, 0, 0); + memset (buf, '\0', 0); + memset (buf, L'\0', 0); + memset (buf, 1 - 1, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, 0 - 0, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0L); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0UL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0LL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0ULL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, (int) 0); + memset (buf, sizeof buf, -0); +} --- gcc/testsuite/c-c++-common/Wmemset-transposed-args2.c.jj 2014-07-10 13:52:47.425157923 +0200 +++ gcc/testsuite/c-c++-common/Wmemset-transposed-args2.c 2014-07-10 13:54:47.954539662 +0200 @@ -0,0 +1,20 @@ +/* { dg-do compile { target { c || c++11 } } } */ +/* { dg-options "-Wall" } */ +/* { dg-additional-options "-std=gnu99" { target c } } */ + +typedef __SIZE_TYPE__ size_t; +extern +#ifdef __cplusplus +"C" +#endif +void *memset (void *, int, size_t); +char buf[1024]; + +void +foo () +{ + memset (buf, sizeof buf, u'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, U'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, u'\0', 0); + memset (buf, U'\0', 0); +} --- gcc/testsuite/g++.dg/warn/Wmemset-transposed-args-1.C.jj 2014-07-10 13:16:01.144371809 +0200 +++ gcc/testsuite/g++.dg/warn/Wmemset-transposed-args-1.C 2014-07-10 13:16:01.144371809 +0200 @@ -0,0 +1,74 @@ +// { dg-do compile } +// { dg-options "-Wall" } + +typedef __SIZE_TYPE__ size_t; +extern "C" void *memset (void *, int, size_t); +char buf[1024]; +namespace std +{ + extern "C" void *memset (void *, int, size_t); +} + +template +void +foo () +{ + memset (buf, sizeof buf, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, '\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, L'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, N); + memset (buf, 1, 1 - 1); + memset (buf, 1, 0 - 0); + memset (buf, 1, N - N); + memset (buf, 0, 0); + memset (buf, 1 - 1, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, 0 - 0, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0L); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0UL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0LL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, 0ULL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + memset (buf, sizeof buf, (int) 0); + memset (buf, sizeof buf, -0); +} + +template +void +baz () +{ + std::memset (buf, sizeof buf, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, '\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, L'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, N); + std::memset (buf, 1, 1 - 1); + std::memset (buf, 1, 0 - 0); + std::memset (buf, 1, N - N); + std::memset (buf, 0, 0); + std::memset (buf, 1 - 1, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, 0 - 0, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0L); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0UL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0LL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0ULL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, (int) 0); + std::memset (buf, sizeof buf, -0); +} + +void +bar () +{ + foo<0> (); + std::memset (buf, sizeof buf, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, '\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, L'\0'); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, 1, 1 - 1); + std::memset (buf, 1, 0 - 0); + std::memset (buf, 0, 0); + std::memset (buf, 1 - 1, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, 0 - 0, 0); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0L); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0UL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0LL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, 0ULL); /* { dg-warning ".memset. used with constant zero length parameter; this could be due to transposed parameters" } */ + std::memset (buf, sizeof buf, (int) 0); + std::memset (buf, sizeof buf, -0); +}