| Message ID | 1501243954-46361-1-git-send-email-akhilesh.k@samsung.com |
|---|---|
| State | New |
| Headers | show |
Akhilesh Kumar <akhilesh.k@samsung.com> wrote: > Since TIWAN is the part for Republic Of China > Made symmetry between SINT MAARTEN,SAINT MARTIN and TIWAN > https://www.iso.org/obp/ui/#search "Page 9" > > [#BZ 21858] > iso-3166.def : Fix English short Name for TIWAN > --- > locale/iso-3166.def | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/locale/iso-3166.def b/locale/iso-3166.def > index 52997b4..653a038 100644 > --- a/locale/iso-3166.def > +++ b/locale/iso-3166.def > @@ -224,7 +224,7 @@ DEFINE_COUNTRY_CODE ("SWAZILAND", SZ, SWZ, 748) > DEFINE_COUNTRY_CODE ("SWEDEN", SE, SWE, 752) > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) I don’t really see why that is an improvement. > DEFINE_COUNTRY_CODE ("TAJIKISTAN", TJ, TJK, 762) > DEFINE_COUNTRY_CODE ("TANZANIA, UNITED REPUBLIC OF", TZ, TZA, 834) > DEFINE_COUNTRY_CODE ("THAILAND", TH, THA, 764)
> > @@ -224,7 +224,7 @@ DEFINE_COUNTRY_CODE ("SWAZILAND", SZ, SWZ, 748) > > DEFINE_COUNTRY_CODE ("SWEDEN", SE, SWE, 752) > > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) > > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) > > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) > > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) > > I don’t really see why that is an improvement. This patch only make consistency Like DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534) DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663) Query:- 1- > looks some countries info are missing Like “KOSOVA” ? 2- > Also Fron 1997 Hong Kong a sovereign state for “China” why country_num is different for “Hong Kong”, "China" and TAIWAN ? Some is found for other countries 3- >I believe this data is taken from iso.org is it mandatory ? > > DEFINE_COUNTRY_CODE ("TAJIKISTAN", TJ, TJK, 762) > > DEFINE_COUNTRY_CODE ("TANZANIA, UNITED REPUBLIC OF", TZ, TZA, 834) > > DEFINE_COUNTRY_CODE ("THAILAND", TH, THA, 764)
AKHILESH KUMAR <akhilesh.k@samsung.com> wrote: >> > @@ -224,7 +224,7 @@ DEFINE_COUNTRY_CODE ("SWAZILAND", SZ, SWZ, 748) >> > DEFINE_COUNTRY_CODE ("SWEDEN", SE, SWE, 752) >> > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) >> > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) >> > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) >> > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) >> >> I don’t really see why that is an improvement. > > > This patch only make consistency > Like > DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534) > DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663) > > > Query:- > 1- > looks some countries info are missing Like “KOSOVA” ? Maybe we don’t need an entry for Kosovo if we don’t have a locale for Kosovo anyway at the moment.
>>> > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) >>> > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) >>> > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) >>> > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) >>> >>> I don’t really see why that is an improvement. >> >> >> This patch only make consistency >> Like >> DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534) >> DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663) >> >> >> Query:- >> 1- > looks some countries info are missing Like “KOSOVA” ? > >Maybe we don’t need an entry for Kosovo if we don’t have a locale for >Kosovo anyway at the moment. > Agree, Since no locale for “KOSOVA” currently, So we can Ignore this case Regarding current changes, They are related with consistency Akhilesh
AKHILESH KUMAR <akhilesh.k@samsung.com> wrote: >>>> > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) >>>> > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) >>>> > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) >>>> > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) >>>> >>>> I don’t really see why that is an improvement. >>> >>> >>> This patch only make consistency >>> Like >>> DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534) >>> DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663) >>> >>> >>> Query:- >>> 1- > looks some countries info are missing Like “KOSOVA” ? >> >>Maybe we don’t need an entry for Kosovo if we don’t have a locale for >>Kosovo anyway at the moment. >> > > Agree, Since no locale for “KOSOVA” currently, So we can Ignore this case > Regarding current changes, They are related with consistency I don’t get the consistency argument here, the current text already looks fine to me.
diff --git a/locale/iso-3166.def b/locale/iso-3166.def index 52997b4..653a038 100644 --- a/locale/iso-3166.def +++ b/locale/iso-3166.def @@ -224,7 +224,7 @@ DEFINE_COUNTRY_CODE ("SWAZILAND", SZ, SWZ, 748) DEFINE_COUNTRY_CODE ("SWEDEN", SE, SWE, 752) DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756) DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760) -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158) +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158) DEFINE_COUNTRY_CODE ("TAJIKISTAN", TJ, TJK, 762) DEFINE_COUNTRY_CODE ("TANZANIA, UNITED REPUBLIC OF", TZ, TZA, 834) DEFINE_COUNTRY_CODE ("THAILAND", TH, THA, 764)