Message ID | 1415953601-5254-1-git-send-email-mashimiao.fnst@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
On Nov 14, 2014, Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> wrote: > According to the description of race in manual, function addmntent should be > marked as MT-Safe race:stream. Thanks for catching this. We need a ChangeLog entry to go with the patch, something like: 2014-11-14 Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> * manual/sysinfo.texi (addmntent): It is actually MT-Safe, because the potential race is on the user-supplied stream. If nobody objects till Monday, I'll check this in on Tuesday along with the ChangeLog entry above. Thanks! > -@safety{@prelim{}@mtunsafe{@mtasurace{:stream} @mtslocale{}}@asunsafe{@asucorrupt{}}@acunsafe{@acucorrupt{}}} > +@safety{@prelim{}@mtsafe{@mtsrace{:stream} @mtslocale{}}@asunsafe{@asucorrupt{}}@acunsafe{@acucorrupt{}}}
On Nov 14, 2014, Alexandre Oliva <aoliva@redhat.com> wrote: > On Nov 14, 2014, Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> wrote: >> According to the description of race in manual, function addmntent should be >> marked as MT-Safe race:stream. > Thanks for catching this. We need a ChangeLog entry to go with the > patch, something like: > 2014-11-14 Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> > * manual/sysinfo.texi (addmntent): It is actually MT-Safe, > because the potential race is on the user-supplied stream. > If nobody objects till Monday, I'll check this in on Tuesday along with > the ChangeLog entry above. I've just checked it in. Thanks again,
diff --git a/manual/sysinfo.texi b/manual/sysinfo.texi index 1c9f51b..e6c44d6 100644 --- a/manual/sysinfo.texi +++ b/manual/sysinfo.texi @@ -790,7 +790,7 @@ end of file reached, @comment mntent.h @comment BSD @deftypefun int addmntent (FILE *@var{stream}, const struct mntent *@var{mnt}) -@safety{@prelim{}@mtunsafe{@mtasurace{:stream} @mtslocale{}}@asunsafe{@asucorrupt{}}@acunsafe{@acucorrupt{}}} +@safety{@prelim{}@mtsafe{@mtsrace{:stream} @mtslocale{}}@asunsafe{@asucorrupt{}}@acunsafe{@acucorrupt{}}} @c addmntent @mtasurace:stream @mtslocale @asucorrupt @acucorrupt @c fseek dup @asucorrupt @acucorrupt [no @aculock] @c encode_name ok