From patchwork Tue Jun 3 23:36:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 355672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 33357140091 for ; Wed, 4 Jun 2014 09:37:00 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=bi0bJ+jbWO+h+WMZN8VchoTIyEdjVEA USJa5rXADlhGm9DmdXOG9GLLM3jpWDYGXgRTVZxFviJe6W9ZD1VlYJ5WyjgmMqto Q4lVqKhkN2ZcSJCMsKu/3LMGTJpO3nCeJtJIIzU7Zn2VSc/CLU6T0CVOLx/p0eFZ JYAVSotPEIsU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; s=default; bh=cVEYUI1zbkX5Iiwl4uXCkul+y50=; b=vT+UR 0UBpu6+cCHuATsOqLEO5xTsLRDqC2MUDBr6U1FW4CflOgUSXZScZinL5fmESxhoS bUsH0nzCpcX1TfMcZsWAIqnKJnGOIt6E2nIYpCV7cup/6AbScDcdE4L2DHKGsc9d SwFnxeqZ6aeYYWRcBa5BB6wZvVjBGDxDXyKTZk= Received: (qmail 10005 invoked by alias); 3 Jun 2014 23:36:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 9976 invoked by uid 89); 3 Jun 2014 23:36:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: hall.aurel32.net From: Aurelien Jarno To: libc-alpha@sourceware.org Cc: Aurelien Jarno Subject: [RFC PATCH 1/4] resolv: improve comments about nserv and nservall Date: Wed, 4 Jun 2014 01:36:40 +0200 Message-Id: <1401838603-22101-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1401838603-22101-1-git-send-email-aurelien@aurel32.net> References: <1401838603-22101-1-git-send-email-aurelien@aurel32.net> The current comments concerning nserv and nservall are not really clear and lead to confusion when reviewing an already complex code. Improve them, there real meaning have been confirmed by a code analysis. --- resolv/res_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resolv/res_init.c b/resolv/res_init.c index ea133f8..bdec4d9 100644 --- a/resolv/res_init.c +++ b/resolv/res_init.c @@ -153,9 +153,9 @@ __res_vinit(res_state statp, int preinit) { char *cp, **pp; int n; char buf[BUFSIZ]; - int nserv = 0; /* number of nameserver records read from file */ + int nserv = 0; /* number of IPv4 nameservers read from file */ #ifdef _LIBC - int nservall = 0; /* number of NS records read, nserv IPv4 only */ + int nservall = 0; /* number of (IPv4 + IPV6) nameservers read from file */ #endif int haveenv = 0; int havesearch = 0;