From patchwork Thu Aug 3 10:28:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 797137 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-82666-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="fxRSfD2f"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xNR9P2fQtz9s65 for ; Thu, 3 Aug 2017 20:28:41 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; q=dns; s=default; b=T7nY DoRKjHIPVLlgFABkMY7JR82gMdl2yXHTcP44kbJTML1J3IzLEh7nTYp/48W7xbnj Ag/s6+LgTzIGaCKSxrrqsfGMT7BSDeg7bs4cLsGtFV87msHc9Zor3NjdArPBwlLt l5nQrVDBsSPFBgwN3Lp2AJ9sqimMmD0uwKImpgs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; s=default; bh=xb/A0txRGU wMNLWgZuEiftjIujw=; b=fxRSfD2fjgmbaGZZ0srPF+zORZMW4LxL+eJNVnUyc1 97kcoiFF5EUh7xZmmsdg9oIB70CFtbLz2ZBNQMfknpI9YpumeO+Qd8iqStFvkYwN PAEjgHKQJvOFWUL91UFLNRZxLZFrsXN+Hbvcak85lMVkW4NzJDY5oHgeP8wcYo2K k= Received: (qmail 89648 invoked by alias); 3 Aug 2017 10:28:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89630 invoked by uid 89); 3 Aug 2017 10:28:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1943 X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 82AC1356CC Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer@redhat.com Subject: Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo To: Samuel Thibault , libc-alpha@sourceware.org References: <20170803002352.62vnzxfs7jnu236t@var.youpi.perso.aquilenet.fr> <20170803003626.zwmxsoskpoihgfzn@var.youpi.perso.aquilenet.fr> <20170803085418.gy5v5pk5h6jlcdhb@var.youpi.perso.aquilenet.fr> From: Florian Weimer Message-ID: <128f21d2-6e76-feb8-5e85-a13feba1b51e@redhat.com> Date: Thu, 3 Aug 2017 12:28:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170803085418.gy5v5pk5h6jlcdhb@var.youpi.perso.aquilenet.fr> On 08/03/2017 10:54 AM, Samuel Thibault wrote: > Samuel Thibault, on jeu. 03 août 2017 02:36:26 +0200, wrote: >> Samuel Thibault, on jeu. 03 août 2017 02:23:52 +0200, wrote: >>> * posix/tst-rfc3484.c: Include and >>> (__inet6_scopeid_pton): New function. >> >> And likewise for tst-rfc3484-2 and tst-rfc3484-3. > > Err inet/tst-inet6_scopeid_pton.c also needs it, but how is this > supposed to link when __inet6_scopeid_pton is marked attribute_hidden? The attached patch should fix this. Thanks, Florian __inet6_scopeid_pton: Remove attribute_hidden, internal_function The hidden attribute was overridden by libc_hidden_proto on GNU/Linux. It is incorrect because the function is used from nscd. internal_function is not supposed to be used across DSO boundaries, so this commit removes it (again, due to the use in nscd). 2017-08-03 Florian Weimer * inet/net-internal.h (__inet6_scopeid_pton): Remove attribute_hidden, internal_function. * inet/inet6_scopeid_pton.c (__inet6_scopeid_pton): Remove internal_function. diff --git a/inet/inet6_scopeid_pton.c b/inet/inet6_scopeid_pton.c index e09b1cb..cc8803f 100644 --- a/inet/inet6_scopeid_pton.c +++ b/inet/inet6_scopeid_pton.c @@ -28,7 +28,7 @@ /* Parse SOURCE as a scope ID for ADDRESS. Return 0 on success and -1 on error. */ -internal_function int +int __inet6_scopeid_pton (const struct in6_addr *address, const char *scope, uint32_t *result) { diff --git a/inet/net-internal.h b/inet/net-internal.h index 2b2632c..b213589 100644 --- a/inet/net-internal.h +++ b/inet/net-internal.h @@ -25,8 +25,7 @@ #include int __inet6_scopeid_pton (const struct in6_addr *address, - const char *scope, uint32_t *result) - internal_function attribute_hidden; + const char *scope, uint32_t *result); libc_hidden_proto (__inet6_scopeid_pton)