diff mbox

i386: Replace internal_function attribute for __mcount_internal

Message ID 093b5b96-00cb-cc87-e3b1-56f3fa6b3f0d@redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 15, 2017, 12:25 p.m. UTC 
On 08/15/2017 02:19 PM, H.J. Lu wrote:
> On Tue, Aug 15, 2017 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> With the separate test patch I posted ([PATCH] Test for profiling
>> support (_mcount/gprof)), is this now okay to commit?
>>
> 
> Does the new test fail without the __mcount_internal patch?

Yes, it does.  The executable does not generate any profiling data:

$ cat gmon/tst-gmon-gprof.out
FAIL

Florian

Comments

H.J. Lu Aug. 15, 2017, 12:34 p.m. UTC | #1 
On Tue, Aug 15, 2017 at 5:25 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 08/15/2017 02:19 PM, H.J. Lu wrote:
>> On Tue, Aug 15, 2017 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> With the separate test patch I posted ([PATCH] Test for profiling
>>> support (_mcount/gprof)), is this now okay to commit?
>>>
>>
>> Does the new test fail without the __mcount_internal patch?
>
> Yes, it does.  The executable does not generate any profiling data:
>

Great.  The patch is OK.

Thanks.
diff mbox

Patch

--- expected
+++ actual
@@ -1,2 +0,0 @@ 
-f1 2000
-f2 1000