From patchwork Tue Sep 6 10:27:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1674673 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=oFngGjmU; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MMM6Z26l4z1yh5 for ; Tue, 6 Sep 2022 20:28:22 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFBEF3850865 for ; Tue, 6 Sep 2022 10:28:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFBEF3850865 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662460099; bh=2G1VQd6GEkKHFRXHPfvtjEPwAf9uOHpyUxE7HiQuFx4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=oFngGjmUx6xiwyRCzB32Situ4rNWhDJkRuhilrgHqAIHd9v8E+uBpEghkBxrJohs5 615c3gjZpvYAYcqG4/CL7Mj7HvwLCpjxJLQ3sxRRLTaF4LXz/k4XDRyHnK9xuk43qG QyeV4rN/kxQRaOivLFwzobgmxhgiFs9mMn7k6pc8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2A0B43851400 for ; Tue, 6 Sep 2022 10:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A0B43851400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-E5npyVdEOZyqQ45NNsftdQ-1; Tue, 06 Sep 2022 06:27:20 -0400 X-MC-Unique: E5npyVdEOZyqQ45NNsftdQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 432F1805AF5 for ; Tue, 6 Sep 2022 10:27:20 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F5DC4010E3C for ; Tue, 6 Sep 2022 10:27:19 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v2 0/3] Restore support for _r_debug copy relocations & interposition X-From-Line: 564187d57abfb2aa436d2facb6965336fc8e0a4e Mon Sep 17 00:00:00 2001 Message-Id: Date: Tue, 06 Sep 2022 12:27:16 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" The previous version used an optimization for symbol lookups that is not valid in the presence of interposition. This version performs a full unversioned symbol lookup with scope traversal instead. This way, an interposing definition in a shared object is picked up as well. Tested on i686-linux-gnu, built with build-many-glibcs.py. Thanks, Florian Florian Weimer (3): elf: Introduce separate _r_debug_array variable elf: Introduce _dl_debug_change_state elf: Restore support for _r_debug interpositions and copy relocations elf/Makefile | 9 +++ elf/dl-close.c | 6 +- elf/dl-debug.c | 144 ++++++++++++++++++++++++++----------- elf/dl-load.c | 6 +- elf/dl-open.c | 5 +- elf/rtld.c | 9 +-- elf/tst-dlmopen4-nonpic.c | 2 + elf/tst-dlmopen4-pic.c | 2 + elf/tst-dlmopen4.c | 22 ++++++ sysdeps/generic/ldsodefs.h | 20 ++++-- 10 files changed, 165 insertions(+), 60 deletions(-) create mode 100644 elf/tst-dlmopen4-nonpic.c create mode 100644 elf/tst-dlmopen4-pic.c base-commit: dbb75513f5cf9285c77c9e55777c5c35b653f890