From patchwork Wed Jun 29 16:22:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 1650207 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=vBTBofHc; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LY6GD4tBWz9s07 for ; Thu, 30 Jun 2022 02:23:32 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8F6238485BC for ; Wed, 29 Jun 2022 16:23:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8F6238485BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656519809; bh=YTc5KxUluBn5kTKedZIKzs+gLQqiFwtOnxeXg8MFfrw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vBTBofHcbDQoWmiozHxYI1yrKPTDoBeERUxiKoqFwWRqKMpQUdxEADLI3rhn/Ble5 YXWxdwQacrVyP9tJb/Csg8yjfbagYItaj1EXbXIiK+lBfmzMezU6g+9DspP8go9ddf U/v0r/jn+aicQsWVx7gO4OX/1bqha/DehgyZzvOA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id ACD58384D193 for ; Wed, 29 Jun 2022 16:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACD58384D193 Received: by mail-ot1-x331.google.com with SMTP id m24-20020a0568301e7800b00616b5c114d4so10713184otr.11 for ; Wed, 29 Jun 2022 09:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YTc5KxUluBn5kTKedZIKzs+gLQqiFwtOnxeXg8MFfrw=; b=4dwwZ70nOT/yWSrNBkRcsvgzIaNndUOfziEU+jsyVvr/h70KQ4jRHd9aIGwgcQSWYs B2GwoRmZUQvpu308TMXJVd09hhlDU3+7tYLXcWEzHSx39hSz6w3/b4WuHhb2x009QAvi Kp4u7gjO1ExBIaRFcXZJ5WKzK2mSAdQgtccvUZoGDHfwJ4WuighoDwcP2KpDzToykU/l WyW41I5nBdNEYOnvEW9A1MGnUEzQYCDMMN0MNQO/dPuNP+/q3W5mG/BFbUM3TGulolIz 6JC6gkp6Q880ZwmPQkx1PAPb+Hfc4AlCXWpOBTZeZU/dsr6i3tmYOKvECB8KGorGpuzJ 43cQ== X-Gm-Message-State: AJIora9Ty5zkytABHrexNVMM65kwbpy4W++oMop4ZJd7gCl5v3Cz5/2y bgkxmQJNqhbftxIqAilAs7d0/lJHSYz0lTPF X-Google-Smtp-Source: AGRyM1v7aXwgJHJKG4055KLChVIDOiEGt6fHTvOsaaCNl40n/+ljzxeu0tZaESnKLU/2YiAGPbM8QQ== X-Received: by 2002:a9d:4793:0:b0:616:e39f:50cb with SMTP id b19-20020a9d4793000000b00616e39f50cbmr1875515otf.375.1656519792482; Wed, 29 Jun 2022 09:23:12 -0700 (PDT) Received: from ubuntu22-vm.. ([177.138.183.172]) by smtp.gmail.com with ESMTPSA id x31-20020a4a97e2000000b00425beedad70sm2615577ooi.32.2022.06.29.09.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 09:23:12 -0700 (PDT) To: libc-alpha@sourceware.org, Florian Weimer Subject: [PATCH v7 0/9] Add arc4random support Date: Wed, 29 Jun 2022 16:22:58 +0000 Message-Id: <20220629162307.3410023-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" This patch adds the arc4random, arc4random_buf, and arc4random_uniform functions along with optimized versions for x86_64 (sse2 and avx2), aarch64, powerpc64 (power8), and s390x (vx). The generic implementation is based on scalar Chacha20, with a per thread state cache allocated lazily. The internal state keeps a 256 bytes buffer (8 ChaCha20 blocks) plus the cipher state, which allows to better use the vectorized optimized version. It would be possible to use just 128 bytes, but it would require to rewrite the AVX2 optimization (and possible it would lower performance slight). The initial state and reseed uses getrandom or /dev/urandom as fallback and reseeds the internal state on every 16MB of consumed entropy. There is no fork detection, the internal state is reset only for fork and _Fork calls. It does not handle direct clone calls nor vfork. Although it is lock-free, arc4random is still not async-signal-safe (the per thread state is not updated atomically), although it is async-cancel-safe. The generic ChaCha20 implementation is based on the RFC8439 [1] without the last XOR step. Since the input stream will either zero bytes (initial state) or the PRNG output itself this step does not add any extra entropy. The optimized ChaCha20 implementations for x86_64, aarch64, powerpc64, and s390x use vectorized instruction and they are based on libgcrypt code. ChaCha20 is used because is the standard cipher used on different arc4random implementation (BSDs, MacOSX), and recently on Linux random subsystem. It also offers a very cheap rekey, which uses periodically uses kernel entropy to improve randomness; it is also simpler than AES, and shows better performance when no specialized instructions are present. [1] https://sourceware.org/pipermail/libc-alpha/2018-June/094879.html v7: * Merged the lock-free TCV optimization on first patch. * Added the original Copyright headers from libgcrypt on imported implementations. * Fixed typos and wording. * Use DO_NOT_OPTIMIZE_OUT from hash benchmark. v6: * Replace array usage with variables and make compiler add hardening if required to cleanup any internal state. It also shows slight better performance. * Add tests for arc4random and arc4random_uniform on thread and fork. * Fixed documentation to state the functiosn as async-signal-unsafe. v5: * Added documentation. * Fixed typos. v4: * Fixed typos and expanded comments. * Fixed powerpc multi-arch organization. v3: * Add per-thread cache to remove the lock usage. It should improve both performance and scalability. * Improve benchmark precision. * Fixed Hurd test build. v2: * Removed the last XOR operation on ChaCha20 implementation (it does not much on arc4random usage). * Add tst-arc4random-chacha20.c and refactor to check against the expected implementation. * Fixed aarch64 implementation (a last change to move symbols to hidden did not change the relocation to use it as well). * Refactor x86 SSSE3 to SSE2. * Fixed powerpc64 implementation on BE (use the correct macro to check for endianess instead the ones from libgcrpyt). * Add s390x optimized ChaCha20 implementation. Adhemerval Zanella (9): stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) stdlib: Add arc4random tests benchtests: Add arc4random benchtest aarch64: Add optimized chacha20 x86: Add SSE2 optimized chacha20 x86: Add AVX2 optimized chacha20 powerpc64: Add optimized chacha20 s390x: Add optimized chacha20 manual: Add documentation for arc4random functions LICENSES | 23 + NEWS | 4 + benchtests/Makefile | 5 +- benchtests/bench-arc4random.c | 218 +++++++ benchtests/bench-hash-funcs-kernel.h | 1 + benchtests/bench-hash-funcs.c | 2 - benchtests/bench-util.h | 6 + include/stdlib.h | 13 + malloc/thread-freeres.c | 2 +- manual/math.texi | 45 ++ nptl/allocatestack.c | 5 +- stdlib/Makefile | 9 + stdlib/Versions | 5 + stdlib/arc4random.c | 207 +++++++ stdlib/arc4random.h | 45 ++ stdlib/arc4random_uniform.c | 140 +++++ stdlib/chacha20.c | 191 ++++++ stdlib/stdlib.h | 14 + stdlib/tst-arc4random-chacha20.c | 167 +++++ stdlib/tst-arc4random-fork.c | 198 ++++++ stdlib/tst-arc4random-stats.c | 146 +++++ stdlib/tst-arc4random-thread.c | 341 ++++++++++ sysdeps/aarch64/Makefile | 4 + sysdeps/aarch64/chacha20-aarch64.S | 342 ++++++++++ sysdeps/aarch64/chacha20_arch.h | 40 ++ sysdeps/generic/chacha20_arch.h | 24 + sysdeps/generic/not-cancel.h | 2 + sysdeps/generic/tls-internal-struct.h | 3 + sysdeps/generic/tls-internal.c | 17 + sysdeps/generic/tls-internal.h | 7 +- sysdeps/mach/hurd/_Fork.c | 2 + sysdeps/mach/hurd/i386/libc.abilist | 3 + sysdeps/mach/hurd/not-cancel.h | 3 + sysdeps/nptl/_Fork.c | 2 + .../powerpc/powerpc64/be/multiarch/Makefile | 4 + .../powerpc64/be/multiarch/chacha20-ppc.c | 1 + .../powerpc64/be/multiarch/chacha20_arch.h | 42 ++ sysdeps/powerpc/powerpc64/power8/Makefile | 5 + .../powerpc/powerpc64/power8/chacha20-ppc.c | 256 ++++++++ .../powerpc/powerpc64/power8/chacha20_arch.h | 37 ++ sysdeps/s390/s390-64/Makefile | 6 + sysdeps/s390/s390-64/chacha20-s390x.S | 584 ++++++++++++++++++ sysdeps/s390/s390-64/chacha20_arch.h | 45 ++ sysdeps/unix/sysv/linux/aarch64/libc.abilist | 3 + sysdeps/unix/sysv/linux/alpha/libc.abilist | 3 + sysdeps/unix/sysv/linux/arc/libc.abilist | 3 + sysdeps/unix/sysv/linux/arm/be/libc.abilist | 3 + sysdeps/unix/sysv/linux/arm/le/libc.abilist | 3 + sysdeps/unix/sysv/linux/csky/libc.abilist | 3 + sysdeps/unix/sysv/linux/hppa/libc.abilist | 3 + sysdeps/unix/sysv/linux/i386/libc.abilist | 3 + sysdeps/unix/sysv/linux/ia64/libc.abilist | 3 + .../sysv/linux/m68k/coldfire/libc.abilist | 3 + .../unix/sysv/linux/m68k/m680x0/libc.abilist | 3 + .../sysv/linux/microblaze/be/libc.abilist | 3 + .../sysv/linux/microblaze/le/libc.abilist | 3 + .../sysv/linux/mips/mips32/fpu/libc.abilist | 3 + .../sysv/linux/mips/mips32/nofpu/libc.abilist | 3 + .../sysv/linux/mips/mips64/n32/libc.abilist | 3 + .../sysv/linux/mips/mips64/n64/libc.abilist | 3 + sysdeps/unix/sysv/linux/nios2/libc.abilist | 3 + sysdeps/unix/sysv/linux/not-cancel.h | 7 + sysdeps/unix/sysv/linux/or1k/libc.abilist | 3 + .../linux/powerpc/powerpc32/fpu/libc.abilist | 3 + .../powerpc/powerpc32/nofpu/libc.abilist | 3 + .../linux/powerpc/powerpc64/be/libc.abilist | 3 + .../linux/powerpc/powerpc64/le/libc.abilist | 3 + .../unix/sysv/linux/riscv/rv32/libc.abilist | 3 + .../unix/sysv/linux/riscv/rv64/libc.abilist | 3 + .../unix/sysv/linux/s390/s390-32/libc.abilist | 3 + .../unix/sysv/linux/s390/s390-64/libc.abilist | 3 + sysdeps/unix/sysv/linux/sh/be/libc.abilist | 3 + sysdeps/unix/sysv/linux/sh/le/libc.abilist | 3 + .../sysv/linux/sparc/sparc32/libc.abilist | 3 + .../sysv/linux/sparc/sparc64/libc.abilist | 3 + sysdeps/unix/sysv/linux/tls-internal.c | 38 +- sysdeps/unix/sysv/linux/tls-internal.h | 16 +- .../unix/sysv/linux/x86_64/64/libc.abilist | 3 + .../unix/sysv/linux/x86_64/x32/libc.abilist | 3 + sysdeps/x86_64/Makefile | 7 + sysdeps/x86_64/chacha20-amd64-avx2.S | 334 ++++++++++ sysdeps/x86_64/chacha20-amd64-sse2.S | 331 ++++++++++ sysdeps/x86_64/chacha20_arch.h | 48 ++ 83 files changed, 4078 insertions(+), 18 deletions(-) create mode 100644 benchtests/bench-arc4random.c create mode 100644 stdlib/arc4random.c create mode 100644 stdlib/arc4random.h create mode 100644 stdlib/arc4random_uniform.c create mode 100644 stdlib/chacha20.c create mode 100644 stdlib/tst-arc4random-chacha20.c create mode 100644 stdlib/tst-arc4random-fork.c create mode 100644 stdlib/tst-arc4random-stats.c create mode 100644 stdlib/tst-arc4random-thread.c create mode 100644 sysdeps/aarch64/chacha20-aarch64.S create mode 100644 sysdeps/aarch64/chacha20_arch.h create mode 100644 sysdeps/generic/chacha20_arch.h create mode 100644 sysdeps/powerpc/powerpc64/be/multiarch/Makefile create mode 100644 sysdeps/powerpc/powerpc64/be/multiarch/chacha20-ppc.c create mode 100644 sysdeps/powerpc/powerpc64/be/multiarch/chacha20_arch.h create mode 100644 sysdeps/powerpc/powerpc64/power8/chacha20-ppc.c create mode 100644 sysdeps/powerpc/powerpc64/power8/chacha20_arch.h create mode 100644 sysdeps/s390/s390-64/chacha20-s390x.S create mode 100644 sysdeps/s390/s390-64/chacha20_arch.h create mode 100644 sysdeps/x86_64/chacha20-amd64-avx2.S create mode 100644 sysdeps/x86_64/chacha20-amd64-sse2.S create mode 100644 sysdeps/x86_64/chacha20_arch.h