diff mbox

[libgcc,build] Suppress some warnings for soft-fp files

Message ID yddiovgbi3f.fsf@lokon.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth Nov. 25, 2013, 3:45 p.m. UTC 
Uros prompted me to look into why we were still getting warnings
compiling the soft-fp code in libgcc despite this in config/t-softfp:

$(soft-fp-objects) : INTERNAL_CFLAGS += -Wno-missing-prototypes -Wno-type-limit
s

It turned out that soft-fp-objects still included the $srcdir prefix.
It seems my libgcc migration missed some chunk of code to strip that,
although I still see the warnings on the 4.6 branch (i.e. before the
migration).

Anyway, the following patch fixes this.  Bootstrapped without
regressions on i386-pc-solaris2.11 and x86_64-unknown-linux-gnu and
verified the warnings are indeed gone.

Ok for mainline?

	Rainer


2013-11-22  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/t-softfp (soft-fp-objects-base): New variable.
	(soft-fp-objects): Use it.

Comments

Paolo Bonzini Nov. 25, 2013, 3:53 p.m. UTC | #1 
Il 25/11/2013 16:45, Rainer Orth ha scritto:
> Uros prompted me to look into why we were still getting warnings
> compiling the soft-fp code in libgcc despite this in config/t-softfp:
> 
> $(soft-fp-objects) : INTERNAL_CFLAGS += -Wno-missing-prototypes -Wno-type-limit
> s
> 
> It turned out that soft-fp-objects still included the $srcdir prefix.
> It seems my libgcc migration missed some chunk of code to strip that,
> although I still see the warnings on the 4.6 branch (i.e. before the
> migration).
> 
> Anyway, the following patch fixes this.  Bootstrapped without
> regressions on i386-pc-solaris2.11 and x86_64-unknown-linux-gnu and
> verified the warnings are indeed gone.
> 
> Ok for mainline?

Ok.

Paolo
diff mbox

Patch

diff --git a/libgcc/config/t-softfp b/libgcc/config/t-softfp
--- a/libgcc/config/t-softfp
+++ b/libgcc/config/t-softfp
@@ -88,8 +88,10 @@  endif
 # for the functions in the soft-fp files have not been brought across
 # from glibc.
 
-soft-fp-objects = $(addsuffix $(objext), $(softfp_file_list)) \
-  $(addsuffix _s$(objext), $(softfp_file_list))
+soft-fp-objects-base = $(basename $(notdir $(softfp_file_list)))
+
+soft-fp-objects = $(addsuffix $(objext), $(soft-fp-objects-base)) \
+  $(addsuffix _s$(objext), $(soft-fp-objects-base))
 
 $(soft-fp-objects) : INTERNAL_CFLAGS += -Wno-missing-prototypes -Wno-type-limits