Message ID | ydda7lh79c4.fsf@CeBiTec.Uni-Bielefeld.DE |
---|---|
State | New |
Headers | show |
Series | Pass GDCFLAGS and CCASFLAGS to libphobos subdirs | expand |
On Fri, 7 Dec 2018 at 14:30, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > > When trying to rebuild libphobos with -g3 -O0 for better debugging, I > noticed that GDCFLAGS weren't passed down as expected. It turned out > that they are missing from AM_MAKEFLAGS. After I fixed this, the only > file still compiled with -g -O2 was libdruntime/core/threadasm.S, so I > added CCASFLAGS, too. > > Tested on i386-pc-solaris2.11. Ok for mainline? > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2018-12-06 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS. > * Makefile.in: Regenerate. > Thanks, looks good to me.
# HG changeset patch # Parent 5910a51aed6e6de5841187a79b17799d6e2241b5 Pass GDCFLAGS and CCASFLAGS to libphobos subdirs diff --git a/libphobos/Makefile.am b/libphobos/Makefile.am --- a/libphobos/Makefile.am +++ b/libphobos/Makefile.am @@ -29,12 +29,14 @@ AM_MAKEFLAGS = \ "AR_FLAGS=$(AR_FLAGS)" \ "CC_FOR_BUILD=$(CC_FOR_BUILD)" \ "CC_FOR_TARGET=$(CC_FOR_TARGET)" \ + "CCASFLAGS=$(CCASFLAGS)" \ "CFLAGS=$(CFLAGS)" \ "CXXFLAGS=$(CXXFLAGS)" \ "CFLAGS_FOR_BUILD=$(CFLAGS_FOR_BUILD)" \ "CFLAGS_FOR_TARGET=$(CFLAGS_FOR_TARGET)" \ "GDC_FOR_TARGET=$(GDC_FOR_TARGET)" \ "GDC=$(GDC)" \ + "GDCFLAGS=$(GDCFLAGS)" \ "INSTALL=$(INSTALL)" \ "INSTALL_DATA=$(INSTALL_DATA)" \ "INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \