From patchwork Thu Dec 23 11:28:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 76505 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id DB3E6B7093 for ; Thu, 23 Dec 2010 22:28:23 +1100 (EST) Received: (qmail 23400 invoked by alias); 23 Dec 2010 11:28:21 -0000 Received: (qmail 23390 invoked by uid 22791); 23 Dec 2010 11:28:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Dec 2010 11:28:14 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 130E6A0A; Thu, 23 Dec 2010 12:28:12 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZUbAQ+WCp1R3; Thu, 23 Dec 2010 12:28:10 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 0CA51A09; Thu, 23 Dec 2010 12:28:10 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id oBNBS9Uh014562; Thu, 23 Dec 2010 12:28:09 +0100 (MET) From: Rainer Orth To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini , Nicola Pero Subject: Re: [build, objc] Link libobjc*.la with -shared-libgcc References: Date: Thu, 23 Dec 2010 12:28:09 +0100 In-Reply-To: (Andrew Pinski's message of "Wed, 22 Dec 2010 13:13:46 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Andrew Pinski writes: > On Wed, Dec 22, 2010 at 7:15 AM, Rainer Orth > wrote: >> >> As described in the third link, 6 bootstraps (i386 and sparc, sun ld >> with as, gas, gld with gas) are currently running.  Ok for mainline if >> they all pass? >> >> Thanks. >>        Rainer >> >> >> 2010-12-22  Rainer Orth   >> >>        * Makefile.in (libobjc$(libsuffix).la): Link with -shared-libgcc. >>        (libobjc_gc$(libsuffix).la): Likewise. > > Yes this is ok. Thanks. Actual testing revealed that a plain -shared-libgcc is swallowed by libtool, but using -Wc,-shared-libgcc works as expected. So here's the actual patch I've checked in. Libtool continues to remain a mystery to me ;-) Rainer 2010-12-22 Rainer Orth * Makefile.in (libobjc$(libsuffix).la): Link with -Wc,-shared-libgcc. (libobjc_gc$(libsuffix).la): Likewise. diff -r ba5f37177ba3 libobjc/Makefile.in --- a/libobjc/Makefile.in Wed Dec 22 12:22:52 2010 +0100 +++ b/libobjc/Makefile.in Wed Dec 22 17:08:02 2010 +0100 @@ -1,6 +1,6 @@ # Makefile for GNU Objective C runtime library. # Copyright 1993, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, -# 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc. +# 2005, 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc. #This file is part of GCC. @@ -325,13 +325,13 @@ libobjc$(libsuffix).la: $(OBJS) $(LIBTOOL_LINK) $(CC) -o $@ $(OBJS) \ - -rpath $(toolexeclibdir) \ + -Wc,-shared-libgcc -rpath $(toolexeclibdir) \ -version-info $(LIBOBJC_VERSION) $(extra_ldflags_libobjc) \ $(LTLDFLAGS) libobjc_gc$(libsuffix).la: $(OBJS_GC) $(LIBTOOL_LINK) $(CC) -o $@ $(OBJS_GC) $(OBJC_BOEHM_GC_LIBS) \ - -rpath $(toolexeclibdir) \ + -Wc,-shared-libgcc -rpath $(toolexeclibdir) \ -version-info $(LIBOBJC_GC_VERSION) $(extra_ldflags_libobjc) \ $(LTLDFLAGS)