From patchwork Tue Jun 15 19:31:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1492438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=tF1cpdv6; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G4JN54x6Kz9sWk for ; Wed, 16 Jun 2021 05:31:33 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B643388983D for ; Tue, 15 Jun 2021 19:31:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B643388983D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1623785491; bh=E/w6T9R1DStZbgWeFvOD70VZRbTKMpFc7wgcqSKI2Zk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=tF1cpdv6DsGI3AS6c9lW/kfFTYYVK+73S0dyzBppYoGssS9mkTHzzQGWeiQ42lJD7 WJvkVgRIbA6JI2+SqYFkU2BmHGCWV/8jSq0Cls0BDgtsMEHJgRjPZn7xGCGCHlKyzk ebokWmeLiCC5dD21Q/GYSHFtMPRbrdJeLZYDVfgk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id E2BE7385783A; Tue, 15 Jun 2021 19:31:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E2BE7385783A X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.85.130] ([93.207.85.130]) by web-mail.gmx.net (3c-app-gmx-bap21.server.lan [172.19.172.91]) (via HTTP); Tue, 15 Jun 2021 21:31:08 +0200 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] PR fortran/101084 - [10/11/12 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1124 Date: Tue, 15 Jun 2021 21:31:08 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:B5/AofVk21iTU9wHiytXTIKmkO9eFLCWjpLiAVLhHseqI06mylroUs2NmYx0P0BzKBuKu 3cQv3y/FpqfpQyZELQLoL7tqvuNp5bMh3vWtdYWraeyLfxKfXhGbSJqnfYD2PYFPJNsFTBYP8Uuo OcJZIYDLqSVaLOJl9U+rUnRdWO30TcHQ2k7H2mOhe+f2UnWfTV/rhzBe+6AmsJ2PcfMaP0pIPaCp b8G5Lmnuz5SYM94vvzm1jgqiwL+0/O8gkWSpqvzT8gc8K0Eo7IeW3HfdLZtqDKlfk+l/y/H6+Jmj 9s= X-UI-Out-Filterresults: notjunk:1;V03:K0:53Two3UwejE=:o1UFe4rwdK1ENp9z83qGvi O6K8d4FFIM22R3FvSY7vMVwkTVgdUkrvBPrb0YRl9c7y2pHFiGCRehJ2YRKD74OdC61V9opBD lc8KbbN+hJnz5ZtyQSkM5CiaAFjKJSqa8E10f/in+ySJ4ljUJLHe1D9aQWWh9WnIt+Tc3BGik yonSgTzbs9wO0h1m57fdeTaRYdtODI81JMOa1FxIODcJlTrcmEuq5HLD3OrBWRkdx5sX+mGmS fDBW6TP+CFVkafGQYOGelXSQfSJTeQFUiCpa6sGSQmgSt0YVbNV5fPedOLNJbuahULG4fj1EJ YBUZN3G9fn6vH/iAuOQjXSdDi51ul3F35Mc444txiEO1NSEgC/n4crDSjOJulOKUVKU1sJQC/ z+s1O2G+FKzXsgqkvSufEudRiCB747EY1L/61J7QNZzxGvOwlogmOB371e28Pfha7Hgpt28ze AuUwuKNIw7bzhuxzQg69IkeRiwgesiSTEz/rY54WEhj3CapgfOvHEGbl33R/6sKz2t2H3MIcj kGuIbakXJFswGHxi0j6xHQjd5y7mdG6KgN7pZPH+jzm5d7SVqLdidUa+MEIHLA5TAoD/ZEBL9 asjj5mV0hBM4mwprx1Z7g2V9ewaMpMSEOt15+Do/G2XrLb3j+SyGNjg2w++K+1IdfxinbdR70 Xxjl2BE0eVet3eJ7t1ce8ywx+A6E8dg4GFWcOMl17WC1CpR8w9Tfr567FpoIX1yaV8eylaKfG CmJsCTUH/FsJfmhQKa3d5ioulvI9dBUALIddS7/dtMCUhZWGEbPneGxUSMP1B5bgDfdDVholl TeVmKxJgb/HXTyPldt5Um6iS+LS+g== X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_PSBL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" A recent change to the checking of legacy FORMAT tags did not handle cases where the type is not set. Adjust the check. Regtested on x86_64-pc-linux-gnu. OK for mainline / 11- / 10-branch? Thanks, Harald Fortran: reject FORMAT tag of unknown type. gcc/fortran/ChangeLog: PR fortran/101084 * io.c (resolve_tag_format): Extend FORMAT check to unknown type. gcc/testsuite/ChangeLog: PR fortran/101084 * gfortran.dg/fmt_nonchar_3.f90: New test. diff --git a/gcc/fortran/io.c b/gcc/fortran/io.c index 40cd76eb585..fc97df79eca 100644 --- a/gcc/fortran/io.c +++ b/gcc/fortran/io.c @@ -1763,7 +1763,7 @@ resolve_tag_format (gfc_expr *e) if (e->ts.type != BT_CHARACTER) { if (e->ts.type == BT_DERIVED || e->ts.type == BT_CLASS - || e->ts.type == BT_VOID) + || e->ts.type == BT_VOID || e->ts.type == BT_UNKNOWN) { gfc_error ("Non-character non-Hollerith in FORMAT tag at %L", &e->where); diff --git a/gcc/testsuite/gfortran.dg/fmt_nonchar_3.f90 b/gcc/testsuite/gfortran.dg/fmt_nonchar_3.f90 new file mode 100644 index 00000000000..3b3c260ef7f --- /dev/null +++ b/gcc/testsuite/gfortran.dg/fmt_nonchar_3.f90 @@ -0,0 +1,7 @@ +! { dg-do compile } +! PR fortran/101084 + +program p + integer, parameter :: a(0) = 1 + print int(a) ! { dg-error "Non-character non-Hollerith in FORMAT tag" } +end