diff mbox series

[gensupport] drop suppport for define_cond_exec from compact syntac

Message ID patch-17410-tamar@arm.com
State New
Headers show
Series [gensupport] drop suppport for define_cond_exec from compact syntac | expand

Commit Message

Tamar Christina June 20, 2023, 5:17 p.m. UTC 
Hi All,

define_cond_exec does not support the special @@ syntax
and so can't support {@.  As such just remove support
for it.

Bootstrapped and no issues.

Ok for master?

Thanks,
Tamar

gcc/ChangeLog:

	PR bootstrap/110324
	* gensupport.cc (convert_syntax): Explicitly check for RTX code.

--- inline copy of patch -- 
diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644




--
diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644
--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -878,7 +878,8 @@ convert_syntax (rtx x, file_location loc)
   const char *templ;
   vec_conlist tconvec, convec, attrvec;
 
-  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
+  templ_index = 3;
+  gcc_assert (GET_CODE (x) == DEFINE_INSN);
 
   templ = XTMPL (x, templ_index);
 
@@ -1053,7 +1054,6 @@ process_rtx (rtx desc, file_location loc)
       break;
 
     case DEFINE_COND_EXEC:
-      convert_syntax (desc, loc);
       queue_pattern (desc, &define_cond_exec_tail, loc);
       break;

Comments

Richard Sandiford June 20, 2023, 8:22 p.m. UTC | #1 
Tamar Christina <tamar.christina@arm.com> writes:
> Hi All,
>
> define_cond_exec does not support the special @@ syntax
> and so can't support {@.  As such just remove support
> for it.
>
> Bootstrapped and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> 	PR bootstrap/110324
> 	* gensupport.cc (convert_syntax): Explicitly check for RTX code.

OK, thanks.

Richard

> --- inline copy of patch -- 
> diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
> index 980b49cd4814c9f92cae5876a1bae936338df071..e39e6dacce25009df1ef83a0ab9ed309704ca74b 100644
> --- a/gcc/gensupport.cc
> +++ b/gcc/gensupport.cc
> @@ -878,7 +878,8 @@ convert_syntax (rtx x, file_location loc)
>    const char *templ;
>    vec_conlist tconvec, convec, attrvec;
>  
> -  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
> +  templ_index = 3;
> +  gcc_assert (GET_CODE (x) == DEFINE_INSN);
>  
>    templ = XTMPL (x, templ_index);
>  
> @@ -1053,7 +1054,6 @@ process_rtx (rtx desc, file_location loc)
>        break;
>  
>      case DEFINE_COND_EXEC:
> -      convert_syntax (desc, loc);
>        queue_pattern (desc, &define_cond_exec_tail, loc);
>        break;
diff mbox series

Patch

--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -878,7 +878,8 @@  convert_syntax (rtx x, file_location loc)
   const char *templ;
   vec_conlist tconvec, convec, attrvec;
 
-  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
+  templ_index = 3;
+  gcc_assert (GET_CODE (x) == DEFINE_INSN);
 
   templ = XTMPL (x, templ_index);
 
@@ -1053,7 +1054,6 @@  process_rtx (rtx desc, file_location loc)
       break;
 
     case DEFINE_COND_EXEC:
-      convert_syntax (desc, loc);
       queue_pattern (desc, &define_cond_exec_tail, loc);
       break;