From patchwork Tue May 25 14:58:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 1483481 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=SuxdEOnb; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqHJh2Tz3z9sRN for ; Wed, 26 May 2021 00:58:28 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5732C393C034; Tue, 25 May 2021 14:58:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5732C393C034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1621954706; bh=jlRunohTVs665DDGglKwPUaijhQvonr+7C2uJOEBZnQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=SuxdEOnbnEaf1/e+AptDkQhDKs5+aXbXNkeScsA5QDtyfV6sKaIzKe3cYi+/kzb+L yoX1Wdoe3R1oLeSJ1HvyrkpISV00T3IJxQ3oi1tw8JVJR5q34GInpG629Lx7iX4YDW AFL7L8hJtUDRN2n7jDnSYvHe/wjXJO6Jl1Vw0MYk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by sourceware.org (Postfix) with ESMTPS id 719BB386101C for ; Tue, 25 May 2021 14:58:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 719BB386101C Received: from AM5PR0701CA0068.eurprd07.prod.outlook.com (2603:10a6:203:2::30) by DBBPR08MB6010.eurprd08.prod.outlook.com (2603:10a6:10:20a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Tue, 25 May 2021 14:58:21 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::ec) by AM5PR0701CA0068.outlook.office365.com (2603:10a6:203:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.11 via Frontend Transport; Tue, 25 May 2021 14:58:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 25 May 2021 14:58:20 +0000 Received: ("Tessian outbound ea2c9a942a09:v92"); Tue, 25 May 2021 14:58:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b2162531c508ee3f X-CR-MTA-TID: 64aa7808 Received: from 809a8917483c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6914E34F-7D7F-4E49-8A9A-C728FA326931.1; Tue, 25 May 2021 14:58:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 809a8917483c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 25 May 2021 14:58:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gF6JOs0PNigU98NV+kBXGUXLVRd6Jy8QUZ6DllJtERnXgoYwzXvF8Qa6Oxrm78NE3BMfFRyWWLLXHb8bX6DZrCgk6yJe0qAF7//F2V1WJtnFfRN4kTQpRSC+hdnh7KPPnYYVRjYt2orw3jxewEUau1O4uZI8rEjcHmOILMdNOBUfQ/LnTKsp+T3jMIPKR39tHV1FbV3+Zud9V/67ISjDP+2v87QmL5hQVv4Xo86eFn8nPpza0v4Dhm2KBUuPh8MH9UOVmW6FBp1XrkVT/jIr5bRkua9/3BlLMuNh51vnNtZDhTmoLHvRA16lBdAacfLEvZKDVvT1xPxQkrG6pNzwZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jlRunohTVs665DDGglKwPUaijhQvonr+7C2uJOEBZnQ=; b=Ahn9UZeL5VJtmgrBqw28jc2179WMq9vJdMUSxikciCQna9CwBcr62spYAMED7jHu9pd5dNd2x6IdU+A0LWC1a9r7+xGCl0BSGJYvbxvQGlRUruT4Gbes/WHSxhc0qSWEQiUIohx6k9wsp1pOPJYEV56kyttm22RsVh6Bu7nqy1ubLXPSc1QxObkZ3Hj1SlefpLo2pI11AoMCbHoc4+mt4yJLiTazGUmLzNJ+EJUFu3st8/HWYLiV0+OAaXPgjuHnk7whBcr34Q0UQzkTji0OdsF1ICgaQ0pUcr8FKK25h4UTW0FcE+oc90NRIzU7s6wIQYL1x1H88O2WAiwW3HJigA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by VI1PR0801MB1887.eurprd08.prod.outlook.com (2603:10a6:800:85::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Tue, 25 May 2021 14:58:06 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::f557:1fb2:62cc:5243]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::f557:1fb2:62cc:5243%9]) with mapi id 15.20.4150.027; Tue, 25 May 2021 14:58:06 +0000 Date: Tue, 25 May 2021 15:58:04 +0100 To: gcc-patches@gcc.gnu.org Subject: [PATCH][AArch32]: Correct sdot RTL on aarch32 Message-ID: Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.51] X-ClientProxiedBy: LO4P123CA0079.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::12) To VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.51) by LO4P123CA0079.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 25 May 2021 14:58:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cdbf2f0-98fa-4a0e-1fd9-08d91f8d899b X-MS-TrafficTypeDiagnostic: VI1PR0801MB1887:|DBBPR08MB6010: X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 03JndN8sbBeXQ2dfqQPx59Y2ilKjVd+nCV/5hYfY2M5+xltyb2rCo7UERTG64za2HcRgScn9J8t3qQ9xsmI5t8BiA7uqDHiaZlgsP5WXHPvMVBD7MisB/2c2UzZeaZTyAzGFuoKiNo6uQWvOfTq3r1tcnMzDgnW/CM9bCQSxfFvksOJPZTs/Qr/qINqYB3XYCgx4WtynIr7BhU5U5jcFudOgzhTVhooAot0IxGMuoPMiHRsHWiiI90tsQuiis1i0JQ6NX7XhRlsFaY0yDJIcCVNCTbiWpG7ChrqIedy6gEixYOehezbEQ1bP87+VUgLUw9aHzRegWz+6tN/pcf97EhFzmFuTUmmVAJRkxT4wazjpjiDq8ghvS3pBiXGPCri+V8K9W57nR49oZN07kKz6dbVD2xUi5DtfYElUyRPuiPkMkEcW1HBJhwjB+NtW9qHCiwbU/exkAMcV9MVGEujJv/4+HLzeO2zch7I+T0Il/VIjKEg2iVoW5wKordbxHW850GKZM7fG5TgEs5RnHDAFtLnJMaeghTZx5GWRIbkd7+Di7+Tbg+EmnHyfy+MHfmMh3i57ASYuJQ940k/VtOULByYRPltOOZ5EVVuMNpcmZKxqC5amkh5mKM6/mVJ9VxtMS84T8476s0MoB0w/4eTv0Oh3uFXkmpkbsL0REJowItl5Ha0hxtRdgDb5DOQYoESxc4vXukpPDvo1kEoc1n5f6g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5325.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(16526019)(8886007)(66476007)(316002)(66556008)(186003)(66616009)(956004)(66946007)(44832011)(5660300002)(4743002)(8936002)(235185007)(26005)(478600001)(38350700002)(6916009)(2616005)(38100700002)(8676002)(86362001)(52116002)(83380400001)(33964004)(4326008)(7696005)(55016002)(44144004)(2906002)(36756003)(4216001)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?rrC11AO/7UX+LwOnfkG8sBFE4gwwqv?= =?utf-8?q?MtTFCOcv9EZSGIg+36dvwW2aiu+Pc2+M1voC0oiN24IhzlEXCTWm7F35yT1vY09K8?= =?utf-8?q?uW2ZsC0slLEhoOsktkGLS737s6nkLI4vK/UwDWapAe0Mv0ucqnwkUF48ymsgMRLYR?= =?utf-8?q?C/W1U/VUO1/Z9/qpG6yL157fYzqEVbScGcxeMMeeDdZECvC3QjrvPtL78sOhdQeS5?= =?utf-8?q?NN9NShF2dfz/kzCIOzYBzqxlwxHD6sbgt100G9hBawslNYMGrmemVgHip1Eb6M2/5?= =?utf-8?q?ZhOO5SR1g/tbEoImAwIDN/j9LZ2ejorLE5HX4sgt/19hd6/YB90TFdS0ASDBGg3gm?= =?utf-8?q?YHHdRgUi5h5Oo3Oqq8ReuBlhyoUD+vAFEybEVRZhVNyXTk4GVaNKXbM1U0lgONYwi?= =?utf-8?q?DSGwiPQJSvVv6GTnxF2isx9uQFRIxlKFGB4xAyhpl/XbnlvoTvrftHsgmuTvKX8Bs?= =?utf-8?q?Ern6YChsMYYcDw1ILwI/qHFax2LrNftXWX9u+3m1sorTTA4sr61Ec+nYDu5RZz6vZ?= =?utf-8?q?b+N1EdlX0salHvOZd50nAUsuw7qzk+8Yb8RugvK5aQ52BWF/wRJVhR0k0eW3IOOGh?= =?utf-8?q?2icH5aQzUuw5p1srtJONDqTL6Q2lx1cYp45VKRly0A9kook9bsn8kOi2kx78ksyIu?= =?utf-8?q?dG7GRhB3XM8joshdwBu9jHiU/W5CTkGz3+rhae1kzxX0JNfcz0quq5dQcR669O4VC?= =?utf-8?q?LM0EHH1epJ0pWrsEAOi9ViXDWCjqan5mOzlfIxgX9/VicMv4+Bg828O5ZqwtKPi3Y?= =?utf-8?q?3L394wCWAX8tWHOHk51CA70eIFWGSE22tgBeR93usTC74e2CYcG1wPNlH3FWSVrHS?= =?utf-8?q?vlQkTfehVm1Cb03pEtQ+kgo7CQmu1bmBCKb2P68HxPPE2tTW52oZaE7++JdBiK3Xm?= =?utf-8?q?P6B7BQmngCtzRI8pi4dJhuGZkeMagGa0/8H3UKtJuqEKmFvL8mMzD82LpNY3nLqi5?= =?utf-8?q?UtjQrN/5q3rKO7WuTtazh0ve6saxvSN3xqanGLqNQWYo8H5xJYPcCyFsbFnB0vOT7?= =?utf-8?q?L6F/xSGuyKDGLPDZMOnrIjQ2vyhx3WUcjBBcvUSN4wDPurLPhjeoc+mJSO9UVNzT9?= =?utf-8?q?qDCjgTGUimMtm2C3NCVd40inkT3wH9Y+fq/MsADcR2Q9gLHRgEVrPDLtxTRsl1Q4j?= =?utf-8?q?F0UmXTWczSk4LummjurI9ZuPCxlhvTBsLkcjT/eR/+ae1Fi0PdLZoby0GI42So2ap?= =?utf-8?q?CBCkmAGIkeQaVsQaZbJk3Ak2sXvj8FqKzFF0AZtuk+/+clLtH1mZIpHeDQHFgbLYd?= =?utf-8?q?r391PveMxBAGC8?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1887 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ca23c487-2d8a-406b-d308-08d91f8d8122 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0aRI5/sRV2AG7dxdsKMoclpeLL3ZrKRj6dwP+W2TT/5sqZ0yP2mTLQ1ril5Xf7NV9y1rD73l+nziNaWKIHTOjpTXz6t224Nk1NTTEULOBhHoRMgIrwdzpnGgRK5ZgJdpHjf0iDRfX9/xBKP8u8L+/b7FBRlGhuzu+q6CIRP5CqKGLf6FhnPLzJ7Faan63KYNVzDZjdXxXASG7O90srtRzgKIep1ELPgKyOBR6LeBGkznNEU2ugytx+6AgJSTd26iOmXtY/TzXR9EZrRjKpXx4t5MCPsjIZKGjjC2QLlz0XVfzAPMqfuVfO/KPKxw3pWqWCfAl/ASR78KlP4cJefAAyaPlEQ2EH3m1XVSO3GGUhcObtwT5AHOvhSjf3zWgZ0VYkioomhzQn9b1hHXUTTkkZgsnN1D52idJM17MtcAX3Y8/m28JdSB2uMw17mDCdqHgrcrKc7fsU4ztHCg5YAx7ET9ln9bl/x3B4ya/dnK62EddyGccBxqx1GOQekI10WAI5cDZGT2G7UFKRzQxrN5TazeeI4HuZnOk7I+COsIZ1LbydcS2VyLC2DoD7TvgEKdK7CVYdsMq211RfcnUMsKVqdIF7jpx+PIU8MK3yITtjlmTDpStXdgeb8qTuI9f1odISlf5ynEOxA9gn3I1lRAZalyggvhBpwZGAqFesspPzJ8JTrAxWL93HR96c94mzMOHQNVrCoIortT8OA757t8IQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(36840700001)(46966006)(235185007)(70586007)(66616009)(7696005)(83380400001)(5660300002)(70206006)(2906002)(6916009)(478600001)(44144004)(33964004)(186003)(4743002)(8936002)(36756003)(8886007)(356005)(81166007)(47076005)(16526019)(956004)(86362001)(336012)(55016002)(82310400003)(2616005)(36860700001)(26005)(316002)(82740400003)(8676002)(4326008)(44832011)(4216001)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 14:58:20.7831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cdbf2f0-98fa-4a0e-1fd9-08d91f8d899b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6010 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_NUMSUBJECT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tamar Christina via Gcc-patches From: Tamar Christina Reply-To: Tamar Christina Cc: Richard.Earnshaw@arm.com, nd@arm.com, Ramana.Radhakrishnan@arm.com Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi All, The RTL Generated from dot_prod is invalid as operand3 cannot be written to, it's a normal input. For the expand it's just another operand but the caller does not expect it to be written to. Bootstrapped Regtested on arm-none-linux-gnueabihf and no issues. Ok for master? and backport to GCC 11, 10, 9? Thanks, Tamar gcc/ChangeLog: * config/arm/neon.md (dot_prod): Drop statements. --- inline copy of patch -- diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 61d81646475ce3bf62ece2cec2faf0c1fe978ec1..9602e9993aeebf4ec620d105fd20f64498a3b851 100644 diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 61d81646475ce3bf62ece2cec2faf0c1fe978ec1..9602e9993aeebf4ec620d105fd20f64498a3b851 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -3067,13 +3067,7 @@ (define_expand "dot_prod" DOTPROD) (match_operand:VCVTI 3 "register_operand")))] "TARGET_DOTPROD" -{ - emit_insn ( - gen_neon_dot (operands[3], operands[3], operands[1], - operands[2])); - emit_insn (gen_rtx_SET (operands[0], operands[3])); - DONE; -}) +) ;; Auto-vectorizer pattern for usdot (define_expand "usdot_prod"