From patchwork Mon Dec 14 15:17:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 1415995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=cGzf7//0; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CvlQB4VsWz9sSf for ; Tue, 15 Dec 2020 02:18:10 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 68FA8388701B; Mon, 14 Dec 2020 15:18:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68FA8388701B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1607959088; bh=XFq6r7JG0KKa+VQfpOEXDgTIYMoiruaTdclBLv1UKAU=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=cGzf7//0gm3vWdZULGzxleHKXiQeYoX+yJzpUehVuwPFl9Ni4fOzO5/uCIjLzK1Tb b8g/I5dGmysDccKljVo0pon0vNsTwdLoWCy9EzVHwc2MYKzFpUbjPwRWIMHsyZFTTo oMjnoV8lSd2d9gfCtXLHxr6RH0FMMXaHkpMIipL8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by sourceware.org (Postfix) with ESMTPS id BCC2E384B13D for ; Mon, 14 Dec 2020 15:18:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BCC2E384B13D Received: from DB6PR0202CA0044.eurprd02.prod.outlook.com (2603:10a6:4:a5::30) by VE1PR08MB4926.eurprd08.prod.outlook.com (2603:10a6:802:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Mon, 14 Dec 2020 15:18:02 +0000 Received: from DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::a0) by DB6PR0202CA0044.outlook.office365.com (2603:10a6:4:a5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Mon, 14 Dec 2020 15:18:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT019.mail.protection.outlook.com (10.152.20.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Mon, 14 Dec 2020 15:18:02 +0000 Received: ("Tessian outbound 76bd5a04122f:v71"); Mon, 14 Dec 2020 15:18:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c97d4721fe69120c X-CR-MTA-TID: 64aa7808 Received: from 9bf988b49b03.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1EF35FC9-C792-4222-8A99-AF5099DE8D80.1; Mon, 14 Dec 2020 15:17:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9bf988b49b03.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Dec 2020 15:17:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hw/cZtpMR7SfbuEcjXnYoC/DlyKroIHBzkj4B0emtJFNgc3diI+bed7bgHZL9Lkg2w95Qq82HnLyywDh2bxqBxL6LN7B+tHjJYvqtSaKkggVdGTCpzc/mCFGnfmzxTTgFFss/N2gMoR+3xFFzENhpDZBvuNsS0S2mEagYdg4jZNYkbR6loYaXe2ODB6JZbdv0XzUEzf/UPhYtqbiU+UKYN0tGLbz0CeaafO9sIG9T5yks4nsVFbjbrS69UcYOcnfBO4bGBor4DITxpsNoiVL8OehN997DeP1fwXZnMAjJxn4Do1hNRQ3M3uZqU1sfzy3WYtmRuUxFB10c5SHnTFTWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFq6r7JG0KKa+VQfpOEXDgTIYMoiruaTdclBLv1UKAU=; b=hpYRDWU7G0sr6f9UmsnoB5ot4beXEV44flFuWwCI3Z029F49JX7ZXvr7bvmQ4vw7MQ4FIa/LDBPVZ5ogkOcKobU8Y4quDSMmgafUPVKHtH/Qp6kRwVKZ8URTHvoNf96YTUH1404qBjSiVGNUsWh2+W7lzyBZMuBzV6kzgSk0VDhSRjAeJuc/flU5i5CgpWK0PAovqZD66HYMvBa+bp7+ezEPMjMLf9wqnxMcMQEyQ9mKAzXGzDuN+ibhflWt+WNw/uUckQa6gcH4aJ25cw+G3WOVJ9y3782k3YGynSMZIP9oKoW7UQXsIYUJ5wbXfAaQn3qX3XOgwMuyNHA2gbQaJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by VE1PR08MB5133.eurprd08.prod.outlook.com (2603:10a6:803:109::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.15; Mon, 14 Dec 2020 15:17:22 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::f937:5b3:12e1:8297]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::f937:5b3:12e1:8297%6]) with mapi id 15.20.3654.025; Mon, 14 Dec 2020 15:17:22 +0000 Date: Mon, 14 Dec 2020 15:17:13 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH]middle-end vect: Exclude TOP permute from blend considerations Message-ID: Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.53] X-ClientProxiedBy: SN4PR0501CA0001.namprd05.prod.outlook.com (2603:10b6:803:40::14) To VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.53) by SN4PR0501CA0001.namprd05.prod.outlook.com (2603:10b6:803:40::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.9 via Frontend Transport; Mon, 14 Dec 2020 15:17:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bce24ccf-ba2e-4ba7-4c15-08d8a04372ff X-MS-TrafficTypeDiagnostic: VE1PR08MB5133:|VE1PR08MB4926: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2uZ4pEHzuOIKxkNwZjYcpZVdF3YuCRFoYld0BX3BLDPE8sIKA0frtKfZK9BHa602mUonA62Qu5HuyjE7V3hIV07iW9YLZ9+v1AzDT2ZYV1WU3P7q/oCtzeLWtr74lpZz68mTAJTxf9CVCTHvhuLT40u4v37dP+PAwe2wHXDVf51JeUfUkzFHWUzepHsbtOwtgRskRF3o6n8wBG2HH77ybgVCB82s79pBj7KDYpjEYFU4rFfG+ejg1XAZ8SuJruorBOEVcdwGXFOSvSDTopo+jkwP+q9EBEXiDoGYFpJLbis7oQCo9EmZEBjAf6V7QmQq9EOVxhXGOkvrqfrpJS1iIbP0gr6VxKMT9DanE+PodksX+h4b5l8I4XIQOPnG25Ig3IQY1uTEpiBXtYnGg551kQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5325.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(235185007)(2906002)(55016002)(956004)(316002)(44832011)(6666004)(16526019)(8676002)(6916009)(44144004)(4326008)(8886007)(33964004)(186003)(7696005)(66946007)(26005)(478600001)(66616009)(66556008)(66476007)(8936002)(2616005)(36756003)(5660300002)(4743002)(52116002)(86362001)(4216001)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?iN7xAEnx9L/VuJkUWnmQ7OI1KJuO0m?= =?utf-8?q?a20NBwq5XPDx7OyOdgbUxudNca94QIRvNwJMQ1Ijzdy6Nvr6v6VhE8XX5hCfLNqg1?= =?utf-8?q?eX5ma+oDrDLDN+Fv23WSfIC61l44GkQGTr2Gtawnvq6nGFzqB4459VRkJ5bqd3MYG?= =?utf-8?q?VRgub66Sydnpjz7hi0tduxXhy8fDMnkMvVWcRMbuLcGbvjhyNgMXq6SF6XEoB1NZ7?= =?utf-8?q?NOB/60heyriRHL/ZzwqRYhWWGVOW9/60KW7sQwnr2hkdz93qjgoV/2XEtNm6fTG+N?= =?utf-8?q?2vdXB0q7FvgCn/bF21k0kX12J2Rc1yyizuKWbcQmas+FvAZruUoByYs56xre2e77D?= =?utf-8?q?mhypRw47NolxuRo/frcWeeSR7MMd3YSPnUbklo8or7XALSwUCpqf7G/85PPUAT6ui?= =?utf-8?q?4JIP1cZ3Ru4aow4N85S1F8q2PZlxhWF88yc+HeXzEzS8tW6+dJsw9gv+m6xd26wdW?= =?utf-8?q?qiuAtFWAgBIV1s29PU2DBN1rTQGEQnvS9QqE+SZlkPh5jaMLlE1fHLogPXCiQVQXs?= =?utf-8?q?GQ+6ETei0rxmpbJKfflZTPJtjPy9qCevZd9wAW6IDsO/5h9ed+T6VMoztnIYIN5tA?= =?utf-8?q?IgvbUkhpPNsdLboF4x4qU68628OFLMx5SfrxMM5o8zE8qBsQr8TNLTCiewwlSyAR1?= =?utf-8?q?yYtFEl28V5QwVPrxSk6Ylf11ibhZrvQFQCk/BojGpUXf1/5D/uUMJG3yo2nTEBy/Y?= =?utf-8?q?HL+qY2f7QxMhHutxSyhfod/DOU/KkBU5VxGOTTYSZRwsaL5hPsh6/222ncqMOQCrh?= =?utf-8?q?zV85nSNuOYrFmKLWFEGbTVkkjq+qwmqyABLQ0ifgV/OtoVx3zVBcyxJNp2IEfKyVP?= =?utf-8?q?hhfnZJHKvOkg9XQedpcjKHCIMcp21eQaIe7F/nDBhcKcj3DSCeVZWsAU8oF9bgQKP?= =?utf-8?q?1Xp//XKqDkUt/Vm/hhdBjUaf8Ag3uSMFFdc8A+mQduLFf2lhiUAzYahgKtQdTfmrJ?= =?utf-8?q?K6PIFHCOBXrgE6qucWd?= X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5133 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 58149e2c-758a-4bfb-98a3-08d8a0435ad5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rnoiAsFPqwkFfNiTTnvdsVZSmE/h/q/uhG1yP0b7Uf8rvC9tVzUaVgRYUlDoQnab+g7UexnW5wfXB2B2FbDvmVE+E6vQTwNfLO5t4umb8i+HqJ098zSH+32ZCh4EyzxS8LMEmSUefnl2empjjX96/RuGfN1CHZP4TG+uLf92fm6cp9r+rgvLV6itKiDbmfJX9cz94y4UJvu10oEuaPUTbaywpxo/oWgf8/mCxMaxzBErm5ZYYqlCGQzqx2iK0pCvP/7puKgAxHjhmGC9b2VC33uuTBjgtnq9rXk6sMX0yNDHoE6RfP1tSgR2k0SezHs8IP086ujCWlOgLk1Ldc+EuCbjcz4LfGvDiHTUgQRwjvyTc7/e0aRRIzBzGJjd+hLNJu6RY5IkxD7h9hilNhH4yN9BrrfAJ5RHmbo/Tb03vSWlOVVMLuRra4NDDBlnTOTw X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(46966005)(478600001)(8936002)(5660300002)(82310400003)(36756003)(44144004)(33964004)(8886007)(66616009)(70586007)(70206006)(2906002)(235185007)(186003)(16526019)(6916009)(26005)(7696005)(8676002)(316002)(6666004)(356005)(82740400003)(47076004)(44832011)(336012)(81166007)(55016002)(2616005)(956004)(4743002)(86362001)(4326008)(4216001)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2020 15:18:02.5447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bce24ccf-ba2e-4ba7-4c15-08d8a04372ff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4926 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_LOTSOFHASH, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tamar Christina via Gcc-patches From: Tamar Christina Reply-To: Tamar Christina Cc: nd@arm.com, rguenther@suse.de, ook@ucw.cz Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi All, Similarly to UNKNOWN permutes, TOP needs to be excluded from being considered for blends because it produces no permute to check. Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu and no issues. Committed under the GCC obvious rules. Thanks, Tamar gcc/ChangeLog: PR middle-end/98264 * tree-vect-slp-patterns.c (linear_loads_p): Exclude TOP permute. gcc/testsuite/ChangeLog: * gcc.target/i386/pr98264.c: New test. --- inline copy of patch -- diff --git a/gcc/testsuite/gcc.target/i386/pr98264.c b/gcc/testsuite/gcc.target/i386/pr98264.c new file mode 100644 index 0000000000000000000000000000000000000000..ea235277911f2a48b4b6f2ccd75a4f9000918599 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr98264.c @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-O3 -w" } */ + +a[], g[], h[]; +double b, c; +double j[]; +i; +l() { + int e = 0; + for (; e < 80; e += 4) { + a[0] = h[e]; + a[1] = h[e + 1]; + j[0] = a[0] - c; + j[1] = a[1] + b; + __attribute__(()) k = *(double *)a, e, f = e = 0; + *g = k; + double *d = j; + for (; e < 2; e++) + if (d[e]) + i = f; + } +} diff --git a/gcc/tree-vect-slp-patterns.c b/gcc/tree-vect-slp-patterns.c index bb2830d1d35d1607d1566868ffbcead97e4790d7..fede88923af8521ee4954c8ae27b0e589f975610 100644 --- a/gcc/tree-vect-slp-patterns.c +++ b/gcc/tree-vect-slp-patterns.c @@ -240,7 +240,8 @@ linear_loads_p (slp_tree_to_load_perm_map_t *perm_cache, slp_tree root) { complex_load_perm_t res = linear_loads_p (perm_cache, child); kind = vect_merge_perms (kind, res.first); - if (kind == PERM_UNKNOWN) + /* Unknown and Top are not valid on blends as they produce no permute. */ + if (kind == PERM_UNKNOWN || kind == PERM_TOP) return retval; all_loads.safe_push (res.second); }