From patchwork Tue Apr 16 03:49:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1923967 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VUrm6x/H; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJVRJ1bNmz1yZC for ; Tue, 16 Apr 2024 13:49:48 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16A3E3847725 for ; Tue, 16 Apr 2024 03:49:46 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id 8BB8D3858D39 for ; Tue, 16 Apr 2024 03:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BB8D3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BB8D3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713239365; cv=none; b=AwU3xIc9QoW/0kA76+IuXXKmaxOhfrMsn1/I7CIKRBV2gnt89e4W/c4DkOpKfvlU8sL8Nwed2pqnDiCAW4QVczZVGFGbzuCeklRD2A3bYk71jTCARck/sB9rYOAp1mgGqFWCJHBIxT/e2Umc8JtUZWNufUgkWX8L3iIeCE0Bx4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713239365; c=relaxed/simple; bh=W9km1hUZUHfgbczHe3XDGMdZzv6DxFZyCcQDXYsFed0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pRQhMW/asQb6iGEUVrYATBBgKQfbyY9NuVwCFBkOlfGeiOvuEpW+hFe6/WZQujF42WKy+zvmhdovfdEIWxDVKeXBcT8Ag4nwTnYfrUIBqTUTJEYYJm9hxo3mZnokxLK3txDjn7Wp+VZZOyttptVU7aRKQE+ZkLV28BKw9vhE1Ss= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-22ed075a629so2387040fac.3 for ; Mon, 15 Apr 2024 20:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713239362; x=1713844162; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:date:organization:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=0/c3O7OvT4yVz4IGE2hCHODnpoP103WRRfHtsDtGWSA=; b=VUrm6x/Hmihv7D/PdiVbPkyg5HadalaXz5Tk9sdCa092fG1iL/iQbMjrBZAXkBzfaI JRsvsx2sNTa8LfA1Da05Tpa5zt7MXHxSm/jEBRkDGFqId+kMoOmLkuUp+BbcJ2iZHPAW 1zLPO3FFDK/2tFUstcLdbIvdYelaBX/pFzLXEM2xP5Nm8YH2VkD0QkKOoLopei9Ht2mC q/h9iucE8u7n4JJcV/EC8faoe23fdaoTIy4eaQ34EXcZi/bmSjSG6qz87OLe2AlXzQIU 8ccteghmOtXMimws34dXawoo7wRQ93Uorx0BD9zdDyNnSxrpTKBZPME6AbfpMwg9XuVe HcKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713239362; x=1713844162; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0/c3O7OvT4yVz4IGE2hCHODnpoP103WRRfHtsDtGWSA=; b=UHzlWvvW/tI67BG7DHlkv7v0qhdzoHPSy2oB8NVeXcwEaPSGtuby8/P9sxAzRck3NP qkuFyox7O+YHtLefdUmfByXyQ5Y0XjAinO21f4FqPQO6Y6/T7y9qiGCrlFqLBOScqzlR R5igpyCzsqd3llXddSEDqIP3mpVBiwNIXs413rEyynPGqwrjnvT8UjcyCfi1rUZGG49b aAQdTsfCrnAEdVGUPG8kPQrIQeU6h7e5x+YzMd+6Qrt04A5ZkbOXtgOGIdaXsaaqx64R T2RIqbcrvlvEhwV/Y95H3HCRPgjwvbauJvS/ExE3FWpL9a+pv5AtYLulklJdZ4ILF72g nvPg== X-Gm-Message-State: AOJu0YwymRxHO1svCvBn9bNpZn0bK//sQF6hkKSYIvcH6YGJIntLxl7O gbZQzepxGycxFtA8yfceXcliYf/C5l+XLuMb6S5l/QYO2RN+z43kz5upz7R4z7HDrPWNau0lkXx 2pQ== X-Google-Smtp-Source: AGHT+IELDzAVlMRVJRUwPzlm+mgnajU0kJx7+jfxvZZV2YHIDrpnad5j+0VqyTpMdDFrCKcQRS/f+Q== X-Received: by 2002:a05:6870:1094:b0:233:1901:7523 with SMTP id 20-20020a056870109400b0023319017523mr11723982oaq.55.1713239362566; Mon, 15 Apr 2024 20:49:22 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id o2-20020a62f902000000b006efd89cea71sm3071372pfh.84.2024.04.15.20.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 20:49:22 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43G3nCCh2388164 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 00:49:13 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: [PATCH] [libstdc++] [testsuite] disable SRA for compare_exchange_padding Organization: Free thinker, does not speak for AdaCore Date: Tue, 16 Apr 2024 00:49:12 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On arm-vx7r2, the uses of as.load() as initializer get SRAed, so the padding bits in the tests are not what we might expect from full-word struct copies. I tried adding a function to perform bitwise copying, but even taking the as.load() argument by const&, we'd still construct a temporary with SRAed field-wise copying. Unable to find another way to ensure we wouldn't get a temporary, I went for disabling SRA. Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, aarch64-, x86- and x86_64-vxworks7r2. Ok to install? for libstdc++-v3/ChangeLog * testsuite/29_atomics/atomic/compare_exchange_padding.cc: Disable SRA. --- .../29_atomics/atomic/compare_exchange_padding.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc b/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc index 2f18d426e7f7e..a6081968ca869 100644 --- a/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc +++ b/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc @@ -1,6 +1,7 @@ // { dg-do run { target c++20 } } // { dg-require-atomic-cmpxchg-word "" } // { dg-add-options libatomic } +// { dg-additional-options "-fno-tree-sra" } #include #include @@ -26,10 +27,10 @@ main () s.s = 42; std::atomic as{ s }; - auto ts = as.load(); + auto ts = as.load(); // SRA might prevent copying of padding bits here. VERIFY( !compare_struct(s, ts) ); // padding cleared on construction as.exchange(s); - auto es = as.load(); + auto es = as.load(); // SRA might prevent copying of padding bits here. VERIFY( compare_struct(ts, es) ); // padding cleared on exchange S n;