| Message ID | ork0onviyo.fsf@lxoliva.fsfla.org |
|---|---|
| State | New |
| Headers | show |
| Series | omit frame pointer in pr89676 | expand |
On Tue, Apr 27, 2021 at 5:35 PM Alexandre Oliva <oliva@adacore.com> wrote: > > > This i386 test expects only two movl instructions. > > In configurations that --enable-frame-pointer, -O2 won't implicitly > enable -fomit-frame-pointer, so we end up with a third movl to set up > the frame pointer. > > This patch enables -fomit-frame-pointer explicitly, so that the result > no longer depends on that configuration option. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to x86-vx7r2. > Ok to install? OK. Thanks, Uros. > > for gcc/testsuite/ChangeLog > > * gcc.target/i386/pr89676.c: Add -fomit-frame-pointer. > --- > gcc/testsuite/gcc.target/i386/pr89676.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/i386/pr89676.c b/gcc/testsuite/gcc.target/i386/pr89676.c > index 164a9da468046..7afa1a1778d71 100644 > --- a/gcc/testsuite/gcc.target/i386/pr89676.c > +++ b/gcc/testsuite/gcc.target/i386/pr89676.c > @@ -1,6 +1,6 @@ > /* PR rtl-optimization/89676 */ > /* { dg-do compile { target ia32 } } */ > -/* { dg-options "-O2 -mno-stv" } */ > +/* { dg-options "-O2 -mno-stv -fomit-frame-pointer" } */ > > unsigned long long > foo (unsigned long long i) > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
On 4/27/2021 9:35 AM, Alexandre Oliva wrote: > This i386 test expects only two movl instructions. > > In configurations that --enable-frame-pointer, -O2 won't implicitly > enable -fomit-frame-pointer, so we end up with a third movl to set up > the frame pointer. > > This patch enables -fomit-frame-pointer explicitly, so that the result > no longer depends on that configuration option. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to x86-vx7r2. > Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.target/i386/pr89676.c: Add -fomit-frame-pointer. OK jeff
diff --git a/gcc/testsuite/gcc.target/i386/pr89676.c b/gcc/testsuite/gcc.target/i386/pr89676.c index 164a9da468046..7afa1a1778d71 100644 --- a/gcc/testsuite/gcc.target/i386/pr89676.c +++ b/gcc/testsuite/gcc.target/i386/pr89676.c @@ -1,6 +1,6 @@ /* PR rtl-optimization/89676 */ /* { dg-do compile { target ia32 } } */ -/* { dg-options "-O2 -mno-stv" } */ +/* { dg-options "-O2 -mno-stv -fomit-frame-pointer" } */ unsigned long long foo (unsigned long long i)