diff mbox series

fixed-point/composite-type: add -Wno-array-parameter

Message ID or5yntle7a.fsf@lxoliva.fsfla.org
State New
Headers show
Series fixed-point/composite-type: add -Wno-array-parameter | expand

Commit Message

Alexandre Oliva April 1, 2022, 2:39 a.m. UTC
On machines that support fixed-point and the test runs, it's failing
because of warnings issued by -Warray-parameter=[12], enabled by
-Wall.

The warnings state "mismatch in bound 1 of argument 1 declared as...",
referring to the redeclaration of f2_##NAME.  The purpose of the
redeclaration is not clear to me.

It doesn't look like the test intends to catch mismatches between
parameter's array lengths, despite the explicit array bound and the
incompatible calls, so I'm adding -Wno-array-parameter to avoid this
distraction and enable the test to pass.

Tested on arm-eabi, where the patch removes the excess errors fail.  Ok
to install?


for gcc/testsuite/ChangeLog

	* gcc.dg/fixed-point/composite-type.c: Add -Wno-array-parameter.
---
 gcc/testsuite/gcc.dg/fixed-point/composite-type.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Biener April 1, 2022, 6:16 a.m. UTC | #1
On Fri, Apr 1, 2022 at 4:40 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> On machines that support fixed-point and the test runs, it's failing
> because of warnings issued by -Warray-parameter=[12], enabled by
> -Wall.
>
> The warnings state "mismatch in bound 1 of argument 1 declared as...",
> referring to the redeclaration of f2_##NAME.  The purpose of the
> redeclaration is not clear to me.
>
> It doesn't look like the test intends to catch mismatches between
> parameter's array lengths, despite the explicit array bound and the
> incompatible calls, so I'm adding -Wno-array-parameter to avoid this
> distraction and enable the test to pass.
>
> Tested on arm-eabi, where the patch removes the excess errors fail.  Ok
> to install?

Sounds reasonable.  OK.

Richard.

>
> for gcc/testsuite/ChangeLog
>
>         * gcc.dg/fixed-point/composite-type.c: Add -Wno-array-parameter.
> ---
>  gcc/testsuite/gcc.dg/fixed-point/composite-type.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> index 026bdaf564420..59351ff09b390 100644
> --- a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> +++ b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> @@ -1,5 +1,5 @@
>  /* { dg-do compile } */
> -/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0" } */
> +/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0 -Wno-array-parameter" } */
>
>  /* C99 6.2.7: Compatible type and composite type.  */
>
>
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
index 026bdaf564420..59351ff09b390 100644
--- a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
+++ b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
@@ -1,5 +1,5 @@ 
 /* { dg-do compile } */
-/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0" } */
+/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0 -Wno-array-parameter" } */
 
 /* C99 6.2.7: Compatible type and composite type.  */