diff mbox series

[pushed] vect: Fix early free

Message ID mptmtisroek.fsf@arm.com
State New
Headers show
Series [pushed] vect: Fix early free | expand

Commit Message

Richard Sandiford Feb. 15, 2022, 6:10 p.m. UTC 
When updating the target costs interface, I failed to move the
free of the scalar costs beyond the new last use.

Tested on aarch64-linux-gnu and x86_64-linux-gnu, pushed as obvious.

Richard


gcc/
	* tree-vect-slp.cc (vect_bb_vectorization_profitable_p): Fix
	use after free.
---
 gcc/tree-vect-slp.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index e2cc7218c2b..273543d37ea 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -5380,7 +5380,6 @@  vect_bb_vectorization_profitable_p (bb_vec_info bb_vinfo,
       unsigned dummy;
       finish_cost (scalar_target_cost_data, nullptr,
 		   &dummy, &scalar_cost, &dummy);
-      delete scalar_target_cost_data;
 
       /* Complete the target-specific vector cost calculation.  */
       class vector_costs *vect_target_cost_data = init_cost (bb_vinfo, false);
@@ -5393,6 +5392,7 @@  vect_bb_vectorization_profitable_p (bb_vec_info bb_vinfo,
 	     && li_vector_costs[vi].first == vl);
       finish_cost (vect_target_cost_data, scalar_target_cost_data,
 		   &vec_prologue_cost, &vec_inside_cost, &vec_epilogue_cost);
+      delete scalar_target_cost_data;
       delete vect_target_cost_data;
 
       vec_outside_cost = vec_prologue_cost + vec_epilogue_cost;