From patchwork Wed Sep 15 21:00:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 64904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4E568B6EEA for ; Thu, 16 Sep 2010 07:01:19 +1000 (EST) Received: (qmail 8600 invoked by alias); 15 Sep 2010 21:01:09 -0000 Received: (qmail 8588 invoked by uid 22791); 15 Sep 2010 21:01:07 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Sep 2010 21:00:58 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id o8FL0tLJ002534 for ; Wed, 15 Sep 2010 14:00:56 -0700 Received: from qwf7 (qwf7.prod.google.com [10.241.194.71]) by wpaz37.hot.corp.google.com with ESMTP id o8FL0fte025749 for ; Wed, 15 Sep 2010 14:00:54 -0700 Received: by qwf7 with SMTP id 7so485297qwf.28 for ; Wed, 15 Sep 2010 14:00:54 -0700 (PDT) Received: by 10.229.246.134 with SMTP id ly6mr1633932qcb.109.1284584454006; Wed, 15 Sep 2010 14:00:54 -0700 (PDT) Received: from coign.google.com (dhcp-172-22-123-203.mtv.corp.google.com [172.22.123.203]) by mx.google.com with ESMTPS id q8sm1791714qcs.24.2010.09.15.14.00.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 15 Sep 2010 14:00:53 -0700 (PDT) From: Ian Lance Taylor To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org Subject: Re: Patch committed: Do not capitalize warning messages References: Date: Wed, 15 Sep 2010 14:00:51 -0700 In-Reply-To: (Joseph S. Myers's message of "Wed, 15 Sep 2010 15:31:00 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org "Joseph S. Myers" writes: > On Wed, 15 Sep 2010, Ian Lance Taylor wrote: > >> - "Bad option %s to optimize attribute.", p); >> + "bad option %s to optimize attribute.", p); > > There's still an inappropriate trailing "." here.... Oh yeah. Fixed like so. Bootstrapped and tested on x86_64-unknown-linux-gnu. Committed as obvious. Ian Index: c-family/c-common.c =================================================================== --- c-family/c-common.c (revision 164316) +++ c-family/c-common.c (working copy) @@ -7730,7 +7730,7 @@ parse_optimize_options (tree args, bool ret = false; if (attr_p) warning (OPT_Wattributes, - "bad option %s to optimize attribute.", p); + "bad option %s to optimize attribute", p); else warning (OPT_Wpragmas, "bad option %s to pragma attribute", p);