From patchwork Fri Apr 20 21:20:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 154166 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 880C8B708F for ; Sat, 21 Apr 2012 07:21:37 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1335561698; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=NTO4c85EvFckrGHg8bTxLOgftp8=; b=jkdUXX0TD4L4vAc c2YEfwvkXm5gVvnNHR2TwR/oPsdtTFPXzsz8QD+fqmV6Swhb7cIapN0nXTh2YM85 5Jze4zXmyr5Jq9+clKVvXHVifG9li3WpFX6BFoLcZsx6ZgQIf3pARnIyM7e/tfyS mceVMF7CrxrdtB2mlDJo1PIu3VkQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Mg+6uguzi/UNvo2KK5O1ZpPryRJNevzFWodc7TOHG5+lAc4qy7ISObc+vcEvhq IPsA6K5XHhe1NziCSPbhLRPD47yKiVNTprerL7ae+abmAtoY7LIcjSKr3kIzq2dQ NuwYsVIPeORYO+UYnYz2zgtkbQAtJMdzJYTpd4XjFnCRQ=; Received: (qmail 4417 invoked by alias); 20 Apr 2012 21:21:30 -0000 Received: (qmail 4401 invoked by uid 22791); 20 Apr 2012 21:21:29 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Apr 2012 21:20:55 +0000 Received: by yhjj56 with SMTP id j56so5905055yhj.20 for ; Fri, 20 Apr 2012 14:20:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:x-gm-message-state; bh=y4XY7RimRTYKH6aJP2e0Ltq+iyu89/kZxL8uzfQ6wxc=; b=g6UkFIV8GGWW8B/DFnqQ98jVVg2iw9c05jIL2RxECtW78/Hgpfre8Z1WiODyU+iz3K oub025iNrk2lPynYN0HcTa4qE2RmyATlpCBGeObDOxFS9sBiPP+ps3JyqVMW0mIB2n0O ul2sCi90Xy7HcZTjYn6z8wlztsNTienhzizgWgh5qEmNbbCoAfNnQPhyY6kODnDKkhAV dNH1l0bij9ENpJ0K60qFVGDk0uwQIpriFmtkJ4Egz/tsq4lp6YunqHohrPba4+NLYO9q DrG6qd6SF1bjqzx/62923qCPbAt1vGb338xUod1K/iQRc1UPk5gATCQSG+lr6sUy9nz6 hkng== Received: by 10.50.191.169 with SMTP id gz9mr351212igc.5.1334956854410; Fri, 20 Apr 2012 14:20:54 -0700 (PDT) Received: by 10.50.191.169 with SMTP id gz9mr351203igc.5.1334956854303; Fri, 20 Apr 2012 14:20:54 -0700 (PDT) Received: from coign.google.com ([2620:0:1000:2301:f2de:f1ff:fe40:72a8]) by mx.google.com with ESMTPS id iu5sm335252igc.14.2012.04.20.14.20.53 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Apr 2012 14:20:53 -0700 (PDT) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Go patch committed: Don't call cgraph_mark_needed_node Date: Fri, 20 Apr 2012 14:20:52 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQnDW/Aj4mlv28slP4nmqDQYZx4WTDRLK5yrg04lkNPv0gJaUvNTH+wjzLFDdY+ZaHCSerGc9jnk/8V+ZskYQz2/s7JkgsgZTi11n3T/e5b8lo4wDS2UW8jnJ6Ck+eeI20oVF4ykK6c7okvGvCHaMQ6Ic7Q9MyaS7sA3N8hhUyEqd++E+Zk= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Honza removed the function cgraph_mark_needed_node from mainline. The Go frontend called it, but that call was left over from days long ago when package initialization was run as a global constructor. Package initialization is now done by a direct call from the main function (found in libgo/runtime/go-main.c), so the function is no longer special from a cgraph point of view. This patch just removes the call to cgraph_mark_needed_node. Bootstrapped and ran Go testsuite on x86_64-unknown-linx-gnu. Committed to mainline. Ian diff -r 2247d6aae86d go/gogo-tree.cc --- a/go/gogo-tree.cc Fri Apr 20 13:09:25 2012 -0700 +++ b/go/gogo-tree.cc Fri Apr 20 14:19:43 2012 -0700 @@ -495,7 +495,6 @@ gimplify_function_tree(fndecl); cgraph_add_new_function(fndecl, false); - cgraph_mark_needed_node(cgraph_get_node(fndecl)); current_function_decl = NULL_TREE; pop_cfun();