From patchwork Wed Sep 21 00:11:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 115649 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0D8A0B6F8F for ; Wed, 21 Sep 2011 10:12:11 +1000 (EST) Received: (qmail 16036 invoked by alias); 21 Sep 2011 00:12:05 -0000 Received: (qmail 16028 invoked by uid 22791); 21 Sep 2011 00:12:03 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Sep 2011 00:11:43 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id p8L0BgEB008926 for ; Tue, 20 Sep 2011 17:11:42 -0700 Received: from iagf6 (iagf6.prod.google.com [10.12.208.6]) by wpaz24.hot.corp.google.com with ESMTP id p8L0B5O7012645 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 20 Sep 2011 17:11:41 -0700 Received: by iagf6 with SMTP id f6so1702257iag.18 for ; Tue, 20 Sep 2011 17:11:40 -0700 (PDT) Received: by 10.231.83.19 with SMTP id d19mr26351ibl.7.1316563900877; Tue, 20 Sep 2011 17:11:40 -0700 (PDT) Received: by 10.231.83.19 with SMTP id d19mr26345ibl.7.1316563900727; Tue, 20 Sep 2011 17:11:40 -0700 (PDT) Received: from coign.google.com ([65.50.220.113]) by mx.google.com with ESMTPS id z11sm4235086iba.6.2011.09.20.17.11.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Sep 2011 17:11:39 -0700 (PDT) From: Ian Lance Taylor To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: Go patch committed: Better error for unknown name in package References: <201109210039.24263.ebotcazou@adacore.com> Date: Tue, 20 Sep 2011 17:11:34 -0700 In-Reply-To: <201109210039.24263.ebotcazou@adacore.com> (Eric Botcazou's message of "Wed, 21 Sep 2011 00:39:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Eric Botcazou writes: >> This patch improves the error message that the Go frontend issues when >> an unknown name in a package is used as type. It also fixes some >> followon errors. > > s/identifer/identifier/ in the error message. Fixed with the obvious patch. Committed to mainline. Thanks for noticing. Ian diff -r b9933a6f280c go/parse.cc --- a/go/parse.cc Tue Sep 20 15:33:25 2011 -0700 +++ b/go/parse.cc Tue Sep 20 17:09:53 2011 -0700 @@ -340,7 +340,7 @@ else { const std::string& packname(package->package_value()->name()); - error_at(location, "reference to undefined identifer %<%s.%s%>", + error_at(location, "reference to undefined identifier %<%s.%s%>", Gogo::message_name(packname).c_str(), Gogo::message_name(name).c_str()); issue_error = false;