diff mbox

Fix PR c/50332 (FAIL: gcc.dg/attr-invalid.c)

Message ID m3wrdircqd.fsf@redhat.com
State New
Headers show

Commit Message

Dodji Seketeli Sept. 8, 2011, 8:38 p.m. UTC
Hello,

To support -Wunused-local-typedefs we mark used typedef decls as being
used.  Logically, __attribute__((used)) is no more ignored on typedef
decls.  I forgot to adjust the relevant test of the test suite.  My
testing should have caught that, but it somehow felt below my radar.
Sorry for that.

Tested against trunk on x86_64-unknown-linux-gnu.

From: Dodji Seketeli <dodji@redhat.com>
Date: Thu, 8 Sep 2011 21:52:16 +0200
Subject: [PATCH] Fix PR c/50332

gcc/testsuite/

	* gcc.dg/attr-invalid.c: Adjust as __attribute__((used) is no more
	ignored on typedefs.
---
 gcc/testsuite/gcc.dg/attr-invalid.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Comments

Jason Merrill Sept. 8, 2011, 9 p.m. UTC | #1
On 09/08/2011 04:38 PM, Dodji Seketeli wrote:
> +typedef int ATSYM(type) ATTR; /* used attribute is no more

"no longer"

OK with that change.

Jason
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.dg/attr-invalid.c b/gcc/testsuite/gcc.dg/attr-invalid.c
index 6568c1a..cca82aa 100644
--- a/gcc/testsuite/gcc.dg/attr-invalid.c
+++ b/gcc/testsuite/gcc.dg/attr-invalid.c
@@ -35,9 +35,11 @@  int ATSYM(fn_vars) (void) {
 #undef AT
 #define AT used
 
-typedef int ATSYM(type) ATTR; /* { dg-warning "attribute ignored" "" } */
+typedef int ATSYM(type) ATTR; /* used attribute is no more
+				 ignored.  */
 
-typedef int (*ATSYM(fntype))(void) ATTR; /* { dg-warning "attribute ignored" "" } */
+typedef int (*ATSYM(fntype))(void) ATTR; /* used attribute is no more
+					    ignored.  */
 
 struct ATSYM(struct) {
   char dummy ATTR; /* { dg-warning "attribute ignored" "" } */