From patchwork Sun Dec 18 12:24:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 132063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8A2E6B7040 for ; Sun, 18 Dec 2011 23:25:17 +1100 (EST) Received: (qmail 13651 invoked by alias); 18 Dec 2011 12:25:13 -0000 Received: (qmail 13612 invoked by uid 22791); 18 Dec 2011 12:25:11 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 18 Dec 2011 12:24:57 +0000 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 7CD70186DEC5 for ; Sun, 18 Dec 2011 13:24:55 +0100 (CET) X-Auth-Info: y/iPpHsao/ewikhfrYxJxmizo9oylKZIT+QhMh4aJe8= Received: from igel.home (ppp-88-217-112-166.dynamic.mnet-online.de [88.217.112.166]) by mail.mnet-online.de (Postfix) with ESMTPA id B6CC41C0004D for ; Sun, 18 Dec 2011 13:24:55 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 272B0CA29C; Sun, 18 Dec 2011 13:24:55 +0100 (CET) From: Andreas Schwab To: gcc-patches@gcc.gnu.org Subject: [toplevel] Check for warning flags without no- prefix X-Yow: I like your SNOOPY POSTER!! Date: Sun, 18 Dec 2011 13:24:54 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Since gcc silently accepts any -Wno-* flag on purpose, it is ineffective to check for support of a warning flag using the negative form. Instead always use the positive form when running the check (but keep the original spelling for the result). (Requires regeneration of fixincludes/configure gcc/configure libcpp/configure libdecnumber/configure libiberty/configure lto-plugin/configure) Andreas. 2011-12-18 Andreas Schwab * warnings.m4 (ACX_PROG_CC_WARNING_OPTS) (ACX_PROG_CC_WARNING_ALMOST_PEDANTIC): Run the test without the no- prefix. diff --git a/config/warnings.m4 b/config/warnings.m4 index 3801c85..292e5a4 100644 --- a/config/warnings.m4 +++ b/config/warnings.m4 @@ -1,6 +1,6 @@ # Autoconf include file defining macros related to compile-time warnings. -# Copyright 2004, 2005, 2007, 2009 Free Software Foundation, Inc. +# Copyright 2004, 2005, 2007, 2009, 2011 Free Software Foundation, Inc. #This file is part of GCC. @@ -28,7 +28,13 @@ AC_SUBST(acx_Var)dnl m4_expand_once([acx_Var= ],m4_quote(acx_Var=))dnl save_CFLAGS="$CFLAGS" -for option in $1; do +for real_option in $1; do + # Do the check with the no- prefix removed since gcc silently + # accepts any -Wno-* option on purpose + case $real_option in + -Wno-*) option=-W`expr $real_option : '-Wno-\(.*\)'` ;; + *) option=$real_option ;; + esac AS_VAR_PUSHDEF([acx_Woption], [acx_cv_prog_cc_warning_$option]) AC_CACHE_CHECK([whether $CC supports $option], acx_Woption, [CFLAGS="$option" @@ -37,14 +43,14 @@ for option in $1; do [AS_VAR_SET(acx_Woption, no)]) ]) AS_IF([test AS_VAR_GET(acx_Woption) = yes], - [acx_Var="$acx_Var${acx_Var:+ }$option"]) + [acx_Var="$acx_Var${acx_Var:+ }$real_option"]) AS_VAR_POPDEF([acx_Woption])dnl done CFLAGS="$save_CFLAGS" m4_popdef([acx_Var])dnl ])# ACX_PROG_CC_WARNING_OPTS -# ACX_PROG_CC_WARNING_ALMOST_PEDANTIC(WARNINGS, [VARIABLE = WARN_PEDANTIC) +# ACX_PROG_CC_WARNING_ALMOST_PEDANTIC(WARNINGS, [VARIABLE = WARN_PEDANTIC]) # Append to VARIABLE "-pedantic" + the argument, if the compiler is GCC # and accepts all of those options simultaneously, otherwise to nothing. AC_DEFUN([ACX_PROG_CC_WARNING_ALMOST_PEDANTIC], @@ -53,11 +59,14 @@ m4_pushdef([acx_Var], [m4_default([$2], [WARN_PEDANTIC])])dnl AC_SUBST(acx_Var)dnl m4_expand_once([acx_Var= ],m4_quote(acx_Var=))dnl -AS_VAR_PUSHDEF([acx_Pedantic], [acx_cv_prog_cc_pedantic_$1])dnl +# Do the check with the no- prefix removed from the warning options +# since gcc silently accepts any -Wno-* option on purpose +m4_pushdef([acx_Woptions], [m4_bpatsubst([$1], [-Wno-], [-W])])dnl +AS_VAR_PUSHDEF([acx_Pedantic], [acx_cv_prog_cc_pedantic_]acx_Woptions)dnl AS_IF([test "$GCC" = yes], -[AC_CACHE_CHECK([whether $CC supports -pedantic $1], acx_Pedantic, +[AC_CACHE_CHECK([whether $CC supports -pedantic ]acx_Woptions, acx_Pedantic, [save_CFLAGS="$CFLAGS" -CFLAGS="-pedantic $1" +CFLAGS="-pedantic acx_Woptions" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([],[])], [AS_VAR_SET(acx_Pedantic, yes)], [AS_VAR_SET(acx_Pedantic, no)]) @@ -66,6 +75,7 @@ AS_IF([test AS_VAR_GET(acx_Pedantic) = yes], [acx_Var="$acx_Var${acx_Var:+ }-pedantic $1"]) ]) AS_VAR_POPDEF([acx_Pedantic])dnl +m4_popdef([acx_Woptions])dnl m4_popdef([acx_Var])dnl ])# ACX_PROG_CC_WARNING_ALMOST_PEDANTIC