diff mbox series

[2/2] xtensa: Fix RTL insn cost estimation about relaxed MOVI instructions

Message ID ca23aa70-0910-b1bc-25a5-8b76e439269f@yahoo.co.jp
State New
Headers show
Series [1/2] xtensa: Apply a few minor fixes | expand

Commit Message

Takayuki 'January June' Suwa June 19, 2022, 7:13 p.m. UTC 
These instructions will all be converted to L32R ones with litpool entries
by the assembler.

gcc/ChangeLog:

	* config/xtensa/xtensa.cc (xtensa_is_insn_L32R_p):
	Consider relaxed MOVI instructions as L32R.
---
 gcc/config/xtensa/xtensa.cc | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

Comments

Max Filippov June 19, 2022, 11:27 p.m. UTC | #1 
On Sun, Jun 19, 2022 at 12:15 PM Takayuki 'January June' Suwa
<jjsuwa_sys3175@yahoo.co.jp> wrote:
>
> These instructions will all be converted to L32R ones with litpool entries
> by the assembler.
>
> gcc/ChangeLog:
>
>         * config/xtensa/xtensa.cc (xtensa_is_insn_L32R_p):
>         Consider relaxed MOVI instructions as L32R.
> ---
>  gcc/config/xtensa/xtensa.cc | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)

Regtested for target=xtensa-linux-uclibc, no new regressions.
Committed to master.
diff mbox series

Patch

diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc
index 2c534ff9c60..13f2b2b832c 100644
--- a/gcc/config/xtensa/xtensa.cc
+++ b/gcc/config/xtensa/xtensa.cc
@@ -4286,17 +4286,23 @@  xtensa_is_insn_L32R_p (const rtx_insn *insn)
 {
   rtx x = PATTERN (insn);
 
-  if (GET_CODE (x) == SET)
+  if (GET_CODE (x) != SET)
+    return false;
+
+  x = XEXP (x, 1);
+  if (MEM_P (x))
     {
-      x = SET_SRC (x);
-      if (MEM_P (x))
-	{
-	  x = XEXP (x, 0);
-	  return (SYMBOL_REF_P (x) || CONST_INT_P (x))
-		 && CONSTANT_POOL_ADDRESS_P (x);
-	}
+      x = XEXP (x, 0);
+      return (SYMBOL_REF_P (x) || CONST_INT_P (x))
+	     && CONSTANT_POOL_ADDRESS_P (x);
     }
 
+  /* relaxed MOVI instructions, that will be converted to L32R by the
+     assembler.  */
+  if (CONST_INT_P (x)
+      && ! xtensa_simm12b (INTVAL (x)))
+    return true;
+
   return false;
 }