From patchwork Mon Aug 14 01:09:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Makarov X-Patchwork-Id: 1820819 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=N3k554ZF; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RPGWr6pQgz1yfP for ; Mon, 14 Aug 2023 11:09:28 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26ADF3858C2B for ; Mon, 14 Aug 2023 01:09:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26ADF3858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1691975366; bh=qU6O1ptMao/6DUFd69VgR4WtqiaFcAC416IqSQ5YjSU=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=N3k554ZFntdK9t76ooYIC8BEQjWCjj117Blb+DV+SnEHMrNPMFtlYCn3M1ftSZ3rW FYD40z78lc9z4R7goyYPI9Lxrx2CMh8R3TiqmF0uc1rT7kgDPlrpKTNFvZURhw2MQ5 WVXlkMCdKxosQAuOpv8tV4Rf1zNKB5wT7l4wQWmo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 20C2F3858D39 for ; Mon, 14 Aug 2023 01:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20C2F3858D39 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-wFNNE7DtN0aqMZBaxtHYsQ-1; Sun, 13 Aug 2023 21:09:02 -0400 X-MC-Unique: wFNNE7DtN0aqMZBaxtHYsQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-63d0c38e986so37918646d6.1 for ; Sun, 13 Aug 2023 18:09:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691975341; x=1692580141; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sXSNBTGAU4MoFck5yQ9UvHBweB0oPoIIRp+bYE3BS2I=; b=huZzOMjO5pes+Pddhty3Id06hqO29KydIIZhfBNBUzjJEkylYvi+bOOJFSzzOqMMqZ haFtVEThvYsjjsdEklPTJ21vI+oBUg4umlVc7t2cFn2JqB0JDwPPLBFrYmE0mOFgk1vR zI1yLoC34lWHi0rt1WwTLDQXQSjUxtqjfRZIBuFJT3fH4T/5v1MjGNb3xjsg2E8eP+Yn FaahbCVTobU7kWv118Lx2+uEi5dkhJXYZFe6jq8L3cCNpYJANaq4KI29ngTsANYuy4Ph dPE9RbZatiX3WR7OvwGG7s7qqH7/KzJepti+u15ytOOvF3WR4mD1CmJa3xGPxWiIWnj3 clQA== X-Gm-Message-State: AOJu0YyXnZ4Antp+6mMxI3dbtpsdYKQZG/W65b+YiCZwPiCO8ieXY8iG mbLkeIJVfLQA8E4YHMB2DhFAN90YPh0bBiSs8eA/msiLDJX/WCJ5tpcaTSb7ITY8c/vURuk5a9o 19yEFZJVQpuxoxIbzdDs9HQa9ZHQmfuhCoenR3jUBFBSkF55tjzADgbDcFsjVA+lJ0v5OB6eBP7 sdag== X-Received: by 2002:a0c:cd0e:0:b0:63f:a4be:d799 with SMTP id b14-20020a0ccd0e000000b0063fa4bed799mr7351076qvm.18.1691975341760; Sun, 13 Aug 2023 18:09:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExvK+YLQtaEukWKff4Oj/1TpfVX2li1XnNou8rc3RQHo7nRWrrlPjSV2GGF4mdPevKIt/13Q== X-Received: by 2002:a0c:cd0e:0:b0:63f:a4be:d799 with SMTP id b14-20020a0ccd0e000000b0063fa4bed799mr7351065qvm.18.1691975341380; Sun, 13 Aug 2023 18:09:01 -0700 (PDT) Received: from [192.168.1.88] (192-0-143-139.cpe.teksavvy.com. [192.0.143.139]) by smtp.gmail.com with ESMTPSA id o11-20020a0ccb0b000000b0062de6537febsm2972714qvk.58.2023.08.13.18.09.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Aug 2023 18:09:01 -0700 (PDT) Message-ID: Date: Sun, 13 Aug 2023 21:09:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: "gcc-patches@gcc.gnu.org" Subject: [pushed]LRA]: Fix asserts for output stack pointer reloads X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vladimir Makarov via Gcc-patches From: Vladimir Makarov Reply-To: Vladimir Makarov Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The following patch fixes useless asserts in my latest patch implementing output stack pointer reloads. commit 18b417fe1a46d37738243267c1f559cd0acc4886 Author: Vladimir N. Makarov Date: Sun Aug 13 20:54:58 2023 -0400 [LRA]: Fix asserts for output stack pointer reloads The patch implementing output stack pointer reloads contained superfluous asserts. The patch makes them useful. gcc/ChangeLog: * lra-constraints.cc (curr_insn_transform): Set done_p up and check it on true after processing output stack pointer reload. diff --git a/gcc/lra-constraints.cc b/gcc/lra-constraints.cc index 26239908747..8d9443adeb6 100644 --- a/gcc/lra-constraints.cc +++ b/gcc/lra-constraints.cc @@ -4852,6 +4852,7 @@ curr_insn_transform (bool check_only_p) && SET_DEST (set) == stack_pointer_rtx) { lra_assert (!done_p); + done_p = true; curr_id->sp_offset = 0; lra_insn_recog_data_t id = lra_get_insn_recog_data (insn); id->sp_offset = sp_offset; @@ -4860,7 +4861,7 @@ curr_insn_transform (bool check_only_p) " Moving sp offset from insn %u to %u\n", INSN_UID (curr_insn), INSN_UID (insn)); } - lra_assert (!done_p); + lra_assert (done_p); } return change_p; }