From patchwork Mon Dec 3 10:40:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 203317 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EB54B2C007B for ; Mon, 3 Dec 2012 21:45:05 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1355136307; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=a4HagYPc+Bq42asbTgE/M66yZGY=; b=oJrtEwH1v1Dxvn1 pYotab72Td1wzSpNnrDGeAZzUrq3DP3S8y2mmNUU0B9I1AsOApB0APN5vMXaQB+d gh6fovxbJUz9qq8dWeR0GuWt9aNYc4rRVRHO3SlA0tBh65hx4fjpNkZxD6o6Eku1 mTRaecrlbvTHYjZmLUasQTCUFFW8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=qJo8OlKuSgBvG7I96DBrQ1i0p8fTYtYlVSpV2AuyvWtZ1oyBkxXptiZX3jeaMq rMEyxZzpEN000gHJKYgsYZVCQcPcCIeEgFO7+rJwFCmQHznoa8OxJwaE989e1DEW TSE4z09PtK0JnysFo5WWj74YSyWOzq1ZRrR1ZKayFmQ7A=; Received: (qmail 26532 invoked by alias); 3 Dec 2012 10:44:44 -0000 Received: (qmail 26469 invoked by uid 22791); 3 Dec 2012 10:44:43 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 10:44:37 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 56895A398E; Mon, 3 Dec 2012 11:44:35 +0100 (CET) Date: Mon, 3 Dec 2012 11:40:28 +0100 (CET) From: Richard Biener To: David Edelsohn Cc: GCC Patches , "Joseph S. Myers" Subject: Re: [PATCH] Fix PR35634 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sat, 1 Dec 2012, David Edelsohn wrote: > Richard, > > The testcases assume default signed char and fail on systems with > different semantics. I believe that both testcases need to declare c > as signed char to consistently test the desired behavior, right? Fixed as follows. Richard. 2012-12-03 Richard Biener * gcc.dg/torture/pr35634.c: Use signed char. * g++.dg/torture/pr35634.C: Likewise. Index: gcc/testsuite/gcc.dg/torture/pr35634.c =================================================================== --- gcc/testsuite/gcc.dg/torture/pr35634.c (revision 194077) +++ gcc/testsuite/gcc.dg/torture/pr35634.c (working copy) @@ -14,6 +14,6 @@ void foo (int i) int main () { - char c; + signed char c; for (c = 0; ; c++) foo (c); } Index: gcc/testsuite/g++.dg/torture/pr35634.C =================================================================== --- gcc/testsuite/g++.dg/torture/pr35634.C (revision 194077) +++ gcc/testsuite/g++.dg/torture/pr35634.C (working copy) @@ -14,6 +14,6 @@ void foo (int i) int main () { - char c; + signed char c; for (c = 0; ; c++) foo (c); }