From patchwork Tue May 20 00:28:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 350447 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DBB5E140088 for ; Tue, 20 May 2014 10:29:27 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; q=dns; s=default; b=pOgSXVkiCKqZIUlT FqC2Uo8mRa1LHl4EgHwcxADGw4sBlmdHBEqJ76XYqX3Ohoj/2jMbQ7UP97MInUZd Ilu//IEQ7FPn279MiVoE5WM/WUKJ6/RNyO8IAHR+9imAZNqDVsWyjM6p6L5KUQ+V DK71vYdnxw/6lF1+WYlQ6tdeXvc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; s=default; bh=HdaN6WrtcFkn+iLjsxTGzB hZKhU=; b=A8Jq3yaxGR+NNSKMpL9QyLzfzFTkk04l3yvStcsj4Skjugf+sQ0MWY 4abyf+YOoVuXleoYS08e7WKv6h3uYVDkfN5d0asIrh3OO1FUBvo4LW8hU1KicxPx 1MDq9zhJEItVTAAJ7fiVE61HWJh5fP5bnOzBhzxtN2v1cqJYFoch0= Received: (qmail 6492 invoked by alias); 20 May 2014 00:29:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6479 invoked by uid 89); 20 May 2014 00:29:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 00:29:17 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WmXva-00028v-MG from Maciej_Rozycki@mentor.com ; Mon, 19 May 2014 17:29:10 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 19 May 2014 17:29:10 -0700 Received: from localhost (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 20 May 2014 01:29:08 +0100 Date: Tue, 20 May 2014 01:28:12 +0100 From: "Maciej W. Rozycki" To: Ian Lance Taylor CC: Richard Biener , Subject: Re: [PATCH] Fix ARM NAN fraction bits In-Reply-To: <1024398b-c40a-45a9-9bde-03d39d24867b@email.android.com> Message-ID: References: <000b01cf3367$439c5280$cad4f780$@arm.com> <1024398b-c40a-45a9-9bde-03d39d24867b@email.android.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Ian, On Sat, 17 May 2014, Richard Biener wrote: > On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" wrote: > >On Fri, 16 May 2014, Joseph S. Myers wrote: > > > >> > 2014-05-16 Maciej W. Rozycki > >> > > >> > PR libgcc/60166 > >> > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D) > >> > (_FP_NANSIGN_Q): Set the quiet bit. > >> > >> OK for glibc. > > > > Joseph, thanks for your review, this is now in. > > > >Richard, you wrote yesterday that pushing changes to 4.8 would require > >explicit approval from release managers, however it is not clear to me > >who > >they are for that branch. This fix corrects a regression introduced > >after > >4.8.2. Can you approve it? If not, then who can? > > If it's not broken in 4.8.2 but broken on the branch head then it's OK > for the branch. I thought I'd double-check with you that it is fine to push this change to trunk first. OK to apply? 2014-05-20 Maciej W. Rozycki PR libgcc/60166 libgcc/ * config/arm/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D) (_FP_NANSIGN_Q): Set the quiet bit. Maciej gcc-soft-fp-arm-nanfrac.diff Index: gcc-fsf-trunk-quilt/libgcc/config/arm/sfp-machine.h =================================================================== --- gcc-fsf-trunk-quilt.orig/libgcc/config/arm/sfp-machine.h 2014-05-16 15:59:06.000000000 +0100 +++ gcc-fsf-trunk-quilt/libgcc/config/arm/sfp-machine.h 2014-05-20 01:23:36.618434199 +0100 @@ -21,10 +21,10 @@ typedef int __gcc_CMPtype __attribute__ /* According to RTABI, QNAN is only with the most significant bit of the significand set, and all other significand bits zero. */ -#define _FP_NANFRAC_H 0 -#define _FP_NANFRAC_S 0 -#define _FP_NANFRAC_D 0, 0 -#define _FP_NANFRAC_Q 0, 0, 0, 0 +#define _FP_NANFRAC_H _FP_QNANBIT_H +#define _FP_NANFRAC_S _FP_QNANBIT_S +#define _FP_NANFRAC_D _FP_QNANBIT_D, 0 +#define _FP_NANFRAC_Q _FP_QNANBIT_Q, 0, 0, 0 #define _FP_NANSIGN_H 0 #define _FP_NANSIGN_S 0 #define _FP_NANSIGN_D 0