diff mbox series

[committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail

Message ID a72fd1a5-12a2-6e06-63ed-6cb832f8b0af@codesourcery.com
State New
Headers show
Series [committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail | expand

Commit Message

Tobias Burnus June 4, 2021, 11:20 a.m. UTC 
This adds a bunch of 'implicit none' to the testcases,
a missing 'integer i' and fixes a typo in a loop variable,
which permitted to remove an xfail.

Currently, there are two classes of xfail:
* !$omp parallel master taskloop (simd)
   → parallel misses shared(...)
     for firstprivate/lastprivate/reduction variable
* !$omp target ...
   → Missing 'map(tofrom:'
     for firstprivate/lastprivate/reduction
   → Wrong firstprivate in that case

Committed as r12-1210-g78b622e37381e1c0e9992f6634972dfbe0338d0b

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf

Comments

Tobias Burnus June 4, 2021, 11:32 a.m. UTC | #1 
On 04.06.21 13:20, Tobias Burnus wrote:

> This adds a bunch of 'implicit none' to the testcases,
> a missing 'integer i' and fixes a typo in a loop variable,
> which permitted to remove an xfail.

Or actually it didn't, as I seemingly did a last-minute change in the
wrong way after running the testsuite or missed a 'git add' or ...  :-(

The xfail is fixed – but only with this follow-up commit
r12-1211-gad3f0ad4bafe377072a53ded468fd9948e659f46.

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
diff mbox series

Patch

commit 78b622e37381e1c0e9992f6634972dfbe0338d0b
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Fri Jun 4 13:10:57 2021 +0200

    gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail
    
    gcc/testsuite/ChangeLog:
    
            * gfortran.dg/gomp/pr99928-1.f90: Add 'implicit none'.
            * gfortran.dg/gomp/pr99928-11.f90: Likewise.
            * gfortran.dg/gomp/pr99928-4.f90: Likewise.
            * gfortran.dg/gomp/pr99928-6.f90: Likewise.
            * gfortran.dg/gomp/pr99928-8.f90: Likewise.
            * gfortran.dg/gomp/pr99928-2.f90: Likewise. Add missing decl.
            * gfortran.dg/gomp/pr99928-5.f90: Add implicit none;
            fix loop-variable and remove xfail.

diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
index 5cbffb09b3f..e5be42fba53 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: f00, f01, f02, f03, f04, f05, f06, f07, f08, f09
   integer :: f12, f13, f14, f15, f16, f17, f18, f19
   integer :: f20, f21, f22, f23, f24, f25, f26, f27, f28, f29
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
index 864ae4b6c99..22a40e2b49c 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: r00, r01, r02
 
 contains
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
index 5dbf78ba291..fe8a715279a 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
@@ -3,12 +3,14 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: l00, l01, l02, l03, l04, l05, l06, l07
   integer :: l10, l11, l12, l13, l14, l15, l16, l17, l18
 
 contains
 
 subroutine foo ()
+  integer :: i
   ! { dg-final { scan-tree-dump "omp distribute\[^\n\r]*lastprivate\\(l00\\)" "gimple" } }
   ! { dg-final { scan-tree-dump "omp parallel\[^\n\r]*lastprivate\\(l00\\)" "gimple" } } ! FIXME: This should be on for instead. 
   ! { dg-final { scan-tree-dump-not "omp for\[^\n\r]*lastprivate\\(l00\\)" "gimple" } } ! FIXME. 
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
index 5b82dd6581c..ead8f030e63 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: l00, l01, l05, l06, l07, l08
 
 contains
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
index 9f45e48feb4..c612aaf9556 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: j00, j01, j02, j03, j04, j06, j07, j08, j09
   integer :: j10
 
@@ -85,9 +86,9 @@  subroutine bar ()
   end do
   ! { dg-final { scan-tree-dump "omp taskloop\[^\n\r]*shared\\(j10\\)" "gimple" } } ! NOTE: This is implementation detail. 
   ! { dg-final { scan-tree-dump "omp taskloop\[^\n\r]*lastprivate\\(j10\\)" "gimple" } }
-  ! { dg-final { scan-tree-dump "omp simd\[^\n\r]*linear\\(j10:1\\)" "gimple" { xfail *-*-* } } }
+  ! { dg-final { scan-tree-dump "omp simd\[^\n\r]*linear\\(j10:1\\)" "gimple" } }
   !$omp taskloop simd linear (j10) default(none)
-  do j010 = 1, 64
+  do j01 = 1, 64
   end do
   ! { dg-final { scan-tree-dump "omp teams\[^\n\r]*shared\\(j11\\)" "gimple" } }
   ! { dg-final { scan-tree-dump "omp distribute\[^\n\r]*lastprivate\\(j11\\)" "gimple" } }
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
index 37a93e6b1ac..0e60199476b 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: j00, j01, j02, j03, j04, j06, j07, j08, j09
   integer :: j10
 
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
index de27ffed629..a5b028b564d 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
@@ -3,6 +3,7 @@ 
 ! { dg-options "-fopenmp -fdump-tree-gimple" }
 
 module m
+  implicit none
   integer :: r00, r01, r02, r03, r04, r05
   integer :: r13, r14, r15, r16, r17, r18, r19
   integer :: r20, r21, r22, r23, r24