From patchwork Tue Jul 23 07:58:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wilken Gottwalt X-Patchwork-Id: 1963648 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=posteo.net header.i=@posteo.net header.a=rsa-sha256 header.s=2017 header.b=pawcRbsm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WSqL46qV6z1yXp for ; Tue, 23 Jul 2024 17:59:24 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B89D3860C34 for ; Tue, 23 Jul 2024 07:59:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by sourceware.org (Postfix) with ESMTPS id AB35A3858403 for ; Tue, 23 Jul 2024 07:58:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB35A3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=posteo.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB35A3858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721721541; cv=none; b=YCS/62aRsc1LA9NKnZ6Y8eG6WGZzN8jhnFycn721quiz+2MrtQ6+d7cDLCUrdQqGtqzyzNqjGWomvjf8IfJbA0yEEtmAgzdQdI6ltwn/ryA0TkJQdoEt/25g0QuQ4GnCMLxSfliq6txpCHiC1mUrVRgLC8Eh0LdOr/RVR1JNm2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721721541; c=relaxed/simple; bh=INCQgct8WdhtuRsLwo2D6jwxHKuQIqu5SqzV6V7uX70=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=LbFMw29NZEzL6rMdNqMp6CWP1YCnyoBD2arvjZRNLQslZxCOUq3WlpkE94BCWidYCSB/REV1AEBKkDyU4LVXsoyNUggFemdcNIP+977k6bgaiZHfSu2suaJ3nwv3lb65tozzLT7U00Up2YdNX7tYW7Wiq6Ink8EqHptYoNjDs0U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BB26F240103 for ; Tue, 23 Jul 2024 09:58:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1721721535; bh=INCQgct8WdhtuRsLwo2D6jwxHKuQIqu5SqzV6V7uX70=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=pawcRbsm2cCnvSySRBnZFggPAfeS3A5J5i08zDtKhQC15OrTBCUD8bBAWofO8HIK3 T7nCdpOQYsUvjwCzdkmCGBNQ0aXN4vfCO0484PC45UwURWcFuSuIG7k6tEuoxBk5ec f5TtFgIvGXy9ddCMIZnxVbZU55Nqnhi8OlkZbZH1pl1Dpgnt91kD+43WXWWz8fAcEf o9ZnrE74RfqdGjj+yD40F3eliXuAWaVpivd3akVJicnLKTbnT0bpJ2xI5bQfPOfJg+ yr5qCSo52iJZhlz8UAH+r7ycuGcLR1cLmOqfQafcgTzxkk8uC4Urhm2DwtqkD7Hg9F PxdQtfCnqmNTA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WSqKV3Fkcz6tw9; Tue, 23 Jul 2024 09:58:53 +0200 (CEST) Date: Tue, 23 Jul 2024 07:58:52 +0000 From: Wilken Gottwalt To: gcc-patches@gcc.gnu.org Cc: Gaius Mulley Subject: [PATCH] gm2: fix bad programming practice identifier warning Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Fix using keywords as identifiers to prevent warnings coming from Modula-2's own libraries. m2pim/DynamicStrings.mod:1358:27: note: In procedure ‘Slice’: the symbol name ‘end’ is legal as an identifier, however as such it might cause confusion and is considered bad programming practice 1358 | start, end, o: INTEGER ; m2pim/DynamicStrings.mod:1358:27: note: either the identifier has the same name as a keyword or alternatively a keyword has the wrong case (‘END’ and ‘end’) gcc/gm2: * gm2-libs/DynamicStrings.mod: Fix bad identifier warning. Signed-off-by: Wilken Gottwalt --- gcc/m2/gm2-libs/DynamicStrings.mod | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/m2/gm2-libs/DynamicStrings.mod b/gcc/m2/gm2-libs/DynamicStrings.mod index b53f0f285b5..982284d3629 100644 --- a/gcc/m2/gm2-libs/DynamicStrings.mod +++ b/gcc/m2/gm2-libs/DynamicStrings.mod @@ -1354,8 +1354,8 @@ END Mult ; PROCEDURE Slice (s: String; low, high: INTEGER) : String ; VAR - d, t : String ; - start, end, o: INTEGER ; + d, t : String ; + start, stop, o: INTEGER ; BEGIN IF PoisonOn THEN @@ -1390,7 +1390,7 @@ BEGIN ELSE start := low - o END ; - end := Max (Min (MaxBuf, high - o), 0) ; + stop := Max (Min (MaxBuf, high - o), 0) ; WHILE t^.contents.len = MaxBuf DO IF t^.contents.next = NIL THEN @@ -1408,7 +1408,7 @@ BEGIN t := t^.contents.next END ; ConcatContentsAddress (t^.contents, - ADR (s^.contents.buf[start]), end - start) ; + ADR (s^.contents.buf[start]), stop - start) ; INC (o, s^.contents.len) ; s := s^.contents.next END