diff mbox series

wwwdocs: Add note to changes.html for __has_{feature,extension}

Message ID Zg56U+SNee6eoQJS@arm.com
State New
Headers show
Series wwwdocs: Add note to changes.html for __has_{feature,extension} | expand

Commit Message

Alex Coplan April 4, 2024, 10 a.m. UTC 
Hi,

This adds a note to the GCC 14 release notes mentioning support for
__has_{feature,extension} (PR60512).

OK to commit?

Thanks,
Alex

Comments

Alex Coplan April 15, 2024, 10:13 a.m. UTC | #1 
On 04/04/2024 11:00, Alex Coplan wrote:
> Hi,
> 
> This adds a note to the GCC 14 release notes mentioning support for
> __has_{feature,extension} (PR60512).
> 
> OK to commit?

Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
maintainers since it adds to the C++ section.

> 
> Thanks,
> Alex

> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index 9fd224c1..facead8d 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -242,6 +242,12 @@ a work-in-progress.</p>
>        <code>constinit</code> and optimized dynamic initialization</li>
>      </ul>
>    </li>
> +  <li>The Clang language extensions <code>__has_feature</code> and
> +    <code>__has_extension</code> have been implemented in GCC.  These
> +    are available from C, C++, and Objective-C(++).
> +    This is primarily intended to aid the portability of code written
> +    against Clang.
> +  </li>
>  </ul>
>  
>  <h4 id="libstdcxx">Runtime Library (libstdc++)</h4>
Eric Gallager April 15, 2024, 8:22 p.m. UTC | #2 
On Mon, Apr 15, 2024 at 6:14 AM Alex Coplan <alex.coplan@arm.com> wrote:
>
> On 04/04/2024 11:00, Alex Coplan wrote:
> > Hi,
> >
> > This adds a note to the GCC 14 release notes mentioning support for
> > __has_{feature,extension} (PR60512).
> >
> > OK to commit?
>
> Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> maintainers since it adds to the C++ section.
>

I think it's ok, but then again I can't approve; maybe try the docs
maintainers (i.e. Gerald and/or Sandra) if you don't hear back from
the C++ ones?

> >
> > Thanks,
> > Alex
>
> > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > index 9fd224c1..facead8d 100644
> > --- a/htdocs/gcc-14/changes.html
> > +++ b/htdocs/gcc-14/changes.html
> > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> >        <code>constinit</code> and optimized dynamic initialization</li>
> >      </ul>
> >    </li>
> > +  <li>The Clang language extensions <code>__has_feature</code> and
> > +    <code>__has_extension</code> have been implemented in GCC.  These
> > +    are available from C, C++, and Objective-C(++).
> > +    This is primarily intended to aid the portability of code written
> > +    against Clang.
> > +  </li>
> >  </ul>
> >
> >  <h4 id="libstdcxx">Runtime Library (libstdc++)</h4>
>
Marek Polacek April 17, 2024, 3:41 p.m. UTC | #3 
On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> On 04/04/2024 11:00, Alex Coplan wrote:
> > Hi,
> > 
> > This adds a note to the GCC 14 release notes mentioning support for
> > __has_{feature,extension} (PR60512).
> > 
> > OK to commit?
> 
> Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> maintainers since it adds to the C++ section.
> 
> > 
> > Thanks,
> > Alex
> 
> > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > index 9fd224c1..facead8d 100644
> > --- a/htdocs/gcc-14/changes.html
> > +++ b/htdocs/gcc-14/changes.html
> > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> >        <code>constinit</code> and optimized dynamic initialization</li>
> >      </ul>
> >    </li>
> > +  <li>The Clang language extensions <code>__has_feature</code> and
> > +    <code>__has_extension</code> have been implemented in GCC.  These
> > +    are available from C, C++, and Objective-C(++).

Since the extension is for the whole c-family, not just C++, I think it
belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.

Marek
Alex Coplan April 26, 2024, 10:12 a.m. UTC | #4 
On 17/04/2024 11:41, Marek Polacek wrote:
> On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > On 04/04/2024 11:00, Alex Coplan wrote:
> > > Hi,
> > > 
> > > This adds a note to the GCC 14 release notes mentioning support for
> > > __has_{feature,extension} (PR60512).
> > > 
> > > OK to commit?
> > 
> > Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> > maintainers since it adds to the C++ section.
> > 
> > > 
> > > Thanks,
> > > Alex
> > 
> > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > index 9fd224c1..facead8d 100644
> > > --- a/htdocs/gcc-14/changes.html
> > > +++ b/htdocs/gcc-14/changes.html
> > > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> > >        <code>constinit</code> and optimized dynamic initialization</li>
> > >      </ul>
> > >    </li>
> > > +  <li>The Clang language extensions <code>__has_feature</code> and
> > > +    <code>__has_extension</code> have been implemented in GCC.  These
> > > +    are available from C, C++, and Objective-C(++).
> 
> Since the extension is for the whole c-family, not just C++, I think it
> belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.

Thanks, I agree that makes more sense.  How about this version instead then:

diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index fce0fb44..42353955 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -303,7 +303,15 @@ a work-in-progress.</p>
   <li>Further clean up and improvements to the GNAT code.</li>
 </ul>
 
-<!-- <h3 id="c-family">C family</h3> -->
+<h3 id="c-family">C family</h3>
+<ul>
+  <li>The Clang language extensions <code>__has_feature</code> and
+    <code>__has_extension</code> have been implemented in GCC.  These
+    are available from C, C++, and Objective-C(++).
+    This is primarily intended to aid the portability of code written
+    against Clang.
+  </li>
+</ul>
 
 <h4 id="c">C</h3>
 
Alex

> 
> Marek
>
Marek Polacek April 26, 2024, 1:14 p.m. UTC | #5 
On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote:
> On 17/04/2024 11:41, Marek Polacek wrote:
> > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > > On 04/04/2024 11:00, Alex Coplan wrote:
> > > > Hi,
> > > > 
> > > > This adds a note to the GCC 14 release notes mentioning support for
> > > > __has_{feature,extension} (PR60512).
> > > > 
> > > > OK to commit?
> > > 
> > > Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> > > maintainers since it adds to the C++ section.
> > > 
> > > > 
> > > > Thanks,
> > > > Alex
> > > 
> > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > > index 9fd224c1..facead8d 100644
> > > > --- a/htdocs/gcc-14/changes.html
> > > > +++ b/htdocs/gcc-14/changes.html
> > > > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> > > >        <code>constinit</code> and optimized dynamic initialization</li>
> > > >      </ul>
> > > >    </li>
> > > > +  <li>The Clang language extensions <code>__has_feature</code> and
> > > > +    <code>__has_extension</code> have been implemented in GCC.  These
> > > > +    are available from C, C++, and Objective-C(++).
> > 
> > Since the extension is for the whole c-family, not just C++, I think it
> > belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.
> 
> Thanks, I agree that makes more sense.  How about this version instead then:

Thanks, I think you can go ahead with this.
 
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index fce0fb44..42353955 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -303,7 +303,15 @@ a work-in-progress.</p>
>    <li>Further clean up and improvements to the GNAT code.</li>
>  </ul>
>  
> -<!-- <h3 id="c-family">C family</h3> -->
> +<h3 id="c-family">C family</h3>
> +<ul>
> +  <li>The Clang language extensions <code>__has_feature</code> and
> +    <code>__has_extension</code> have been implemented in GCC.  These
> +    are available from C, C++, and Objective-C(++).
> +    This is primarily intended to aid the portability of code written
> +    against Clang.
> +  </li>
> +</ul>
>  
>  <h4 id="c">C</h3>

Marek
Alex Coplan April 26, 2024, 1:31 p.m. UTC | #6 
On 26/04/2024 09:14, Marek Polacek wrote:
> On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote:
> > On 17/04/2024 11:41, Marek Polacek wrote:
> > > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > > > On 04/04/2024 11:00, Alex Coplan wrote:
> > > > > Hi,
> > > > > 
> > > > > This adds a note to the GCC 14 release notes mentioning support for
> > > > > __has_{feature,extension} (PR60512).
> > > > > 
> > > > > OK to commit?
> > > > 
> > > > Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> > > > maintainers since it adds to the C++ section.
> > > > 
> > > > > 
> > > > > Thanks,
> > > > > Alex
> > > > 
> > > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > > > index 9fd224c1..facead8d 100644
> > > > > --- a/htdocs/gcc-14/changes.html
> > > > > +++ b/htdocs/gcc-14/changes.html
> > > > > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> > > > >        <code>constinit</code> and optimized dynamic initialization</li>
> > > > >      </ul>
> > > > >    </li>
> > > > > +  <li>The Clang language extensions <code>__has_feature</code> and
> > > > > +    <code>__has_extension</code> have been implemented in GCC.  These
> > > > > +    are available from C, C++, and Objective-C(++).
> > > 
> > > Since the extension is for the whole c-family, not just C++, I think it
> > > belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.
> > 
> > Thanks, I agree that makes more sense.  How about this version instead then:
> 
> Thanks, I think you can go ahead with this.

Great, I've pushed that to wwwdocs.

>  
> > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > index fce0fb44..42353955 100644
> > --- a/htdocs/gcc-14/changes.html
> > +++ b/htdocs/gcc-14/changes.html
> > @@ -303,7 +303,15 @@ a work-in-progress.</p>
> >    <li>Further clean up and improvements to the GNAT code.</li>
> >  </ul>
> >  
> > -<!-- <h3 id="c-family">C family</h3> -->
> > +<h3 id="c-family">C family</h3>
> > +<ul>
> > +  <li>The Clang language extensions <code>__has_feature</code> and
> > +    <code>__has_extension</code> have been implemented in GCC.  These
> > +    are available from C, C++, and Objective-C(++).
> > +    This is primarily intended to aid the portability of code written
> > +    against Clang.
> > +  </li>
> > +</ul>
> >  
> >  <h4 id="c">C</h3>
> 
> Marek
>
diff mbox series

Patch

diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index 9fd224c1..facead8d 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -242,6 +242,12 @@  a work-in-progress.</p>
       <code>constinit</code> and optimized dynamic initialization</li>
     </ul>
   </li>
+  <li>The Clang language extensions <code>__has_feature</code> and
+    <code>__has_extension</code> have been implemented in GCC.  These
+    are available from C, C++, and Objective-C(++).
+    This is primarily intended to aid the portability of code written
+    against Clang.
+  </li>
 </ul>
 
 <h4 id="libstdcxx">Runtime Library (libstdc++)</h4>