| Message ID | ZfsJ6TFQ0sJqvNnr@tucnak |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] visium: Fix up visium_setup_incoming_varargs [PR114175] | expand |
On 3/20/24 10:08 AM, Jakub Jelinek wrote: > Hi! > > Like for x86-64, alpha or rs6000, visium seems to be affected too. > > Just visually checked differences in c23-stdarg-9.c assembly in a cross > without/with the patch, committed to trunk. > > 2024-03-20 Jakub Jelinek <jakub@redhat.com> > > PR target/114175 > * config/visium/visium.cc (visium_setup_incoming_varargs): Only skip > TARGET_FUNCTION_ARG_ADVANCE for TYPE_NO_NAMED_ARGS_STDARG_P functions > if arg.type is NULL. No gdbsim, so no execution results. Builds fine though. jeff
--- gcc/config/visium/visium.cc.jj 2024-01-03 11:51:47.166514192 +0100 +++ gcc/config/visium/visium.cc 2024-03-20 16:14:51.613422079 +0100 @@ -1482,7 +1482,8 @@ visium_setup_incoming_varargs (cumulativ /* The caller has advanced ARGS_SO_FAR up to, but not beyond, the last named argument. Advance a local copy of ARGS_SO_FAR past the last "real" named argument, to find out how many registers are left over. */ - if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))) + if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)) + || arg.type != NULL_TREE) TARGET_FUNCTION_ARG_ADVANCE (local_args_so_far, arg); /* Find how many registers we need to save. */