diff mbox series

i386: i386-expand formatting fixes

Message ID YlRcv7NCYIZjzQkH@tucnak
State New
Headers show
Series i386: i386-expand formatting fixes | expand

Commit Message

Jakub Jelinek April 11, 2022, 4:52 p.m. UTC
Hi!

While working on the PR105214 patch, I've noticed incorrect formatting
for a bunch of functions where the function names aren't at the start of
lines.

The following patch fixes it, though of course it isn't a regression.

Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk or
ok for GCC 13 once stage1 reopens?

2022-04-11  Jakub Jelinek  <jakub@redhat.com>

	* config/i386/i386-expand.cc (ix86_emit_i387_sinh, ix86_emit_i387_cosh,
	ix86_emit_i387_tanh, ix86_emit_i387_asinh, ix86_emit_i387_acosh,
	ix86_emit_i387_atanh, ix86_emit_i387_log1p, ix86_emit_i387_round,
	ix86_emit_swdivsf, ix86_emit_swsqrtsf,
	ix86_expand_atomic_fetch_op_loop, ix86_expand_cmpxchg_loop):
	Formatting fix.
	* config/i386/i386.cc (warn_once_call_ms2sysv_xlogues): Likewise.


	Jakub

Comments

Uros Bizjak April 11, 2022, 8:04 p.m. UTC | #1
On Mon, Apr 11, 2022 at 6:52 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> Hi!
>
> While working on the PR105214 patch, I've noticed incorrect formatting
> for a bunch of functions where the function names aren't at the start of
> lines.
>
> The following patch fixes it, though of course it isn't a regression.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk or
> ok for GCC 13 once stage1 reopens?
>
> 2022-04-11  Jakub Jelinek  <jakub@redhat.com>
>
>         * config/i386/i386-expand.cc (ix86_emit_i387_sinh, ix86_emit_i387_cosh,
>         ix86_emit_i387_tanh, ix86_emit_i387_asinh, ix86_emit_i387_acosh,
>         ix86_emit_i387_atanh, ix86_emit_i387_log1p, ix86_emit_i387_round,
>         ix86_emit_swdivsf, ix86_emit_swsqrtsf,
>         ix86_expand_atomic_fetch_op_loop, ix86_expand_cmpxchg_loop):
>         Formatting fix.
>         * config/i386/i386.cc (warn_once_call_ms2sysv_xlogues): Likewise.

This has a very low probability of a regression, so OK for the trunk.

Thanks,
Uros.

> --- gcc/config/i386/i386-expand.cc.jj   2022-04-11 15:17:43.943430658 +0200
> +++ gcc/config/i386/i386-expand.cc      2022-04-11 15:29:54.226204466 +0200
> @@ -17036,7 +17036,8 @@ ix86_emit_fp_unordered_jump (rtx label)
>
>  /* Output code to perform an sinh XFmode calculation.  */
>
> -void ix86_emit_i387_sinh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_sinh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17084,7 +17085,8 @@ void ix86_emit_i387_sinh (rtx op0, rtx o
>
>  /* Output code to perform an cosh XFmode calculation.  */
>
> -void ix86_emit_i387_cosh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_cosh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17106,7 +17108,8 @@ void ix86_emit_i387_cosh (rtx op0, rtx o
>
>  /* Output code to perform an tanh XFmode calculation.  */
>
> -void ix86_emit_i387_tanh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_tanh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17152,7 +17155,8 @@ void ix86_emit_i387_tanh (rtx op0, rtx o
>
>  /* Output code to perform an asinh XFmode calculation.  */
>
> -void ix86_emit_i387_asinh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_asinh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17204,7 +17208,8 @@ void ix86_emit_i387_asinh (rtx op0, rtx
>
>  /* Output code to perform an acosh XFmode calculation.  */
>
> -void ix86_emit_i387_acosh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_acosh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17230,7 +17235,8 @@ void ix86_emit_i387_acosh (rtx op0, rtx
>
>  /* Output code to perform an atanh XFmode calculation.  */
>
> -void ix86_emit_i387_atanh (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_atanh (rtx op0, rtx op1)
>  {
>    rtx e1 = gen_reg_rtx (XFmode);
>    rtx e2 = gen_reg_rtx (XFmode);
> @@ -17281,7 +17287,8 @@ void ix86_emit_i387_atanh (rtx op0, rtx
>
>  /* Output code to perform a log1p XFmode calculation.  */
>
> -void ix86_emit_i387_log1p (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_log1p (rtx op0, rtx op1)
>  {
>    rtx_code_label *label1 = gen_label_rtx ();
>    rtx_code_label *label2 = gen_label_rtx ();
> @@ -17322,7 +17329,8 @@ void ix86_emit_i387_log1p (rtx op0, rtx
>  }
>
>  /* Emit code for round calculation.  */
> -void ix86_emit_i387_round (rtx op0, rtx op1)
> +void
> +ix86_emit_i387_round (rtx op0, rtx op1)
>  {
>    machine_mode inmode = GET_MODE (op1);
>    machine_mode outmode = GET_MODE (op0);
> @@ -17436,7 +17444,8 @@ void ix86_emit_i387_round (rtx op0, rtx
>  /* Output code to perform a Newton-Rhapson approximation of a single precision
>     floating point divide [http://en.wikipedia.org/wiki/N-th_root_algorithm].  */
>
> -void ix86_emit_swdivsf (rtx res, rtx a, rtx b, machine_mode mode)
> +void
> +ix86_emit_swdivsf (rtx res, rtx a, rtx b, machine_mode mode)
>  {
>    rtx x0, x1, e0, e1;
>
> @@ -17487,7 +17496,8 @@ void ix86_emit_swdivsf (rtx res, rtx a,
>  /* Output code to perform a Newton-Rhapson approximation of a
>     single precision floating point [reciprocal] square root.  */
>
> -void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
> +void
> +ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
>  {
>    rtx x0, e0, e1, e2, e3, mthree, mhalf;
>    REAL_VALUE_TYPE r;
> @@ -23242,9 +23252,10 @@ ix86_expand_divmod_libfunc (rtx libfunc,
>    *rem_p = rem;
>  }
>
> -void ix86_expand_atomic_fetch_op_loop (rtx target, rtx mem, rtx val,
> -                                      enum rtx_code code, bool after,
> -                                      bool doubleword)
> +void
> +ix86_expand_atomic_fetch_op_loop (rtx target, rtx mem, rtx val,
> +                                 enum rtx_code code, bool after,
> +                                 bool doubleword)
>  {
>    rtx old_reg, new_reg, old_mem, success;
>    machine_mode mode = GET_MODE (target);
> @@ -23288,10 +23299,11 @@ void ix86_expand_atomic_fetch_op_loop (r
>     it will be relaxed to an atomic load + compare, and skip
>     cmpxchg instruction if mem != exp_input.  */
>
> -void ix86_expand_cmpxchg_loop (rtx *ptarget_bool, rtx target_val,
> -                              rtx mem, rtx exp_input, rtx new_input,
> -                              rtx mem_model, bool doubleword,
> -                              rtx_code_label *loop_label)
> +void
> +ix86_expand_cmpxchg_loop (rtx *ptarget_bool, rtx target_val,
> +                         rtx mem, rtx exp_input, rtx new_input,
> +                         rtx mem_model, bool doubleword,
> +                         rtx_code_label *loop_label)
>  {
>    rtx_code_label *cmp_label = NULL;
>    rtx_code_label *done_label = NULL;
> --- gcc/config/i386/i386.cc.jj  2022-04-06 09:59:32.483658110 +0200
> +++ gcc/config/i386/i386.cc     2022-04-11 15:29:09.093836460 +0200
> @@ -6524,7 +6524,8 @@ ix86_initial_elimination_offset (int fro
>  }
>
>  /* Emits a warning for unsupported msabi to sysv pro/epilogues.  */
> -void warn_once_call_ms2sysv_xlogues (const char *feature)
> +void
> +warn_once_call_ms2sysv_xlogues (const char *feature)
>  {
>    static bool warned_once = false;
>    if (!warned_once)
>
>         Jakub
>
diff mbox series

Patch

--- gcc/config/i386/i386-expand.cc.jj	2022-04-11 15:17:43.943430658 +0200
+++ gcc/config/i386/i386-expand.cc	2022-04-11 15:29:54.226204466 +0200
@@ -17036,7 +17036,8 @@  ix86_emit_fp_unordered_jump (rtx label)
 
 /* Output code to perform an sinh XFmode calculation.  */
 
-void ix86_emit_i387_sinh (rtx op0, rtx op1)
+void
+ix86_emit_i387_sinh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17084,7 +17085,8 @@  void ix86_emit_i387_sinh (rtx op0, rtx o
 
 /* Output code to perform an cosh XFmode calculation.  */
 
-void ix86_emit_i387_cosh (rtx op0, rtx op1)
+void
+ix86_emit_i387_cosh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17106,7 +17108,8 @@  void ix86_emit_i387_cosh (rtx op0, rtx o
 
 /* Output code to perform an tanh XFmode calculation.  */
 
-void ix86_emit_i387_tanh (rtx op0, rtx op1)
+void
+ix86_emit_i387_tanh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17152,7 +17155,8 @@  void ix86_emit_i387_tanh (rtx op0, rtx o
 
 /* Output code to perform an asinh XFmode calculation.  */
 
-void ix86_emit_i387_asinh (rtx op0, rtx op1)
+void
+ix86_emit_i387_asinh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17204,7 +17208,8 @@  void ix86_emit_i387_asinh (rtx op0, rtx
 
 /* Output code to perform an acosh XFmode calculation.  */
 
-void ix86_emit_i387_acosh (rtx op0, rtx op1)
+void
+ix86_emit_i387_acosh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17230,7 +17235,8 @@  void ix86_emit_i387_acosh (rtx op0, rtx
 
 /* Output code to perform an atanh XFmode calculation.  */
 
-void ix86_emit_i387_atanh (rtx op0, rtx op1)
+void
+ix86_emit_i387_atanh (rtx op0, rtx op1)
 {
   rtx e1 = gen_reg_rtx (XFmode);
   rtx e2 = gen_reg_rtx (XFmode);
@@ -17281,7 +17287,8 @@  void ix86_emit_i387_atanh (rtx op0, rtx
 
 /* Output code to perform a log1p XFmode calculation.  */
 
-void ix86_emit_i387_log1p (rtx op0, rtx op1)
+void
+ix86_emit_i387_log1p (rtx op0, rtx op1)
 {
   rtx_code_label *label1 = gen_label_rtx ();
   rtx_code_label *label2 = gen_label_rtx ();
@@ -17322,7 +17329,8 @@  void ix86_emit_i387_log1p (rtx op0, rtx
 }
 
 /* Emit code for round calculation.  */
-void ix86_emit_i387_round (rtx op0, rtx op1)
+void
+ix86_emit_i387_round (rtx op0, rtx op1)
 {
   machine_mode inmode = GET_MODE (op1);
   machine_mode outmode = GET_MODE (op0);
@@ -17436,7 +17444,8 @@  void ix86_emit_i387_round (rtx op0, rtx
 /* Output code to perform a Newton-Rhapson approximation of a single precision
    floating point divide [http://en.wikipedia.org/wiki/N-th_root_algorithm].  */
 
-void ix86_emit_swdivsf (rtx res, rtx a, rtx b, machine_mode mode)
+void
+ix86_emit_swdivsf (rtx res, rtx a, rtx b, machine_mode mode)
 {
   rtx x0, x1, e0, e1;
 
@@ -17487,7 +17496,8 @@  void ix86_emit_swdivsf (rtx res, rtx a,
 /* Output code to perform a Newton-Rhapson approximation of a
    single precision floating point [reciprocal] square root.  */
 
-void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
+void
+ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip)
 {
   rtx x0, e0, e1, e2, e3, mthree, mhalf;
   REAL_VALUE_TYPE r;
@@ -23242,9 +23252,10 @@  ix86_expand_divmod_libfunc (rtx libfunc,
   *rem_p = rem;
 }
 
-void ix86_expand_atomic_fetch_op_loop (rtx target, rtx mem, rtx val,
-				       enum rtx_code code, bool after,
-				       bool doubleword)
+void
+ix86_expand_atomic_fetch_op_loop (rtx target, rtx mem, rtx val,
+				  enum rtx_code code, bool after,
+				  bool doubleword)
 {
   rtx old_reg, new_reg, old_mem, success;
   machine_mode mode = GET_MODE (target);
@@ -23288,10 +23299,11 @@  void ix86_expand_atomic_fetch_op_loop (r
    it will be relaxed to an atomic load + compare, and skip
    cmpxchg instruction if mem != exp_input.  */
 
-void ix86_expand_cmpxchg_loop (rtx *ptarget_bool, rtx target_val,
-			       rtx mem, rtx exp_input, rtx new_input,
-			       rtx mem_model, bool doubleword,
-			       rtx_code_label *loop_label)
+void
+ix86_expand_cmpxchg_loop (rtx *ptarget_bool, rtx target_val,
+			  rtx mem, rtx exp_input, rtx new_input,
+			  rtx mem_model, bool doubleword,
+			  rtx_code_label *loop_label)
 {
   rtx_code_label *cmp_label = NULL;
   rtx_code_label *done_label = NULL;
--- gcc/config/i386/i386.cc.jj	2022-04-06 09:59:32.483658110 +0200
+++ gcc/config/i386/i386.cc	2022-04-11 15:29:09.093836460 +0200
@@ -6524,7 +6524,8 @@  ix86_initial_elimination_offset (int fro
 }
 
 /* Emits a warning for unsupported msabi to sysv pro/epilogues.  */
-void warn_once_call_ms2sysv_xlogues (const char *feature)
+void
+warn_once_call_ms2sysv_xlogues (const char *feature)
 {
   static bool warned_once = false;
   if (!warned_once)